From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E150C25B75 for ; Mon, 3 Jun 2024 17:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AF746B0092; Mon, 3 Jun 2024 13:58:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 736576B0093; Mon, 3 Jun 2024 13:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588D36B0095; Mon, 3 Jun 2024 13:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3860B6B0092 for ; Mon, 3 Jun 2024 13:58:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E0FD8120B97 for ; Mon, 3 Jun 2024 17:58:19 +0000 (UTC) X-FDA: 82190336718.10.405CC94 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id A998CC0028 for ; Mon, 3 Jun 2024 17:58:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QwQdzdg6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717437497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZhKzrinOPa+LJLxiGlKxPpoFhujVeaZR4zaTStdiN/w=; b=Ano/SN3pUVopt941s7+gZS7jsVUMMlFs4G1SBayLhy4WSvEtq0aXO7O24vldK6xzJCaj8c UuiyqXqqxsPJ+rXsU3qfiusslrfpiul5N3vO45MqkzBuN1rNk4+NSSxOLCy2j2URKojTu9 AZhhnIh19fHTYKdrAz6P79U6Y2JY35E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QwQdzdg6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717437497; a=rsa-sha256; cv=none; b=TvQClFrEVLFMfOH7M/ieLHiYsh+kkp61Vhc53oGrgJ74uFuhG2LOvfdmCv4ieFeBNv+b2i BhrB2/Q51Tc+N4Sxk5nYqnyhtPZmuguAaasnkjED7FHwUSFvdyDYNevTMHZP7KYi1EhUtV F9fQWtgb+uho7PGFQunfGeWhYqVkH3M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717437497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZhKzrinOPa+LJLxiGlKxPpoFhujVeaZR4zaTStdiN/w=; b=QwQdzdg6cO4kQnbJrvA4tBrFiWtVkusfBxamLj0KYR6Lrbh36aAXjakAoedWhpjZCG5MI5 0mtiW+0rUhxHFcOL1uzH5fUX6ujD+ZRnDFXH8518dRB7Rgc0D+gwxomQhH2ol6wfr5oVD3 DQWYqE/Zi2OqgqkHEWS3SigycGGC2dY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-KiliiS36O7aYhW0I5wUHwA-1; Mon, 03 Jun 2024 13:58:15 -0400 X-MC-Unique: KiliiS36O7aYhW0I5wUHwA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4212a3dd9b6so20832915e9.3 for ; Mon, 03 Jun 2024 10:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717437494; x=1718042294; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZhKzrinOPa+LJLxiGlKxPpoFhujVeaZR4zaTStdiN/w=; b=P1Tbrbo1rHClJ8d0mPlnA76O3cKBjZrTLBhqT/5y5uenlz8pmyPnK3+A+eftKis/Tk sqBaR3u1TBcFf3CGGQPc65k1Q3tyCwoJTWAfy4IYKIX/yLs6R0L330AtqAicXkHvtPvk NzqtfvAgEswG5yaFRBt3mvolPLUi4kpB26w2f7QTR/U0minDELx35q83pfZSfpf8zB77 L5onmBWz9ceNR56prbp6gHI9Gml7rkALR5XxG2RxUx29VD6qU/uVVC0jhtUfcPDFTaQ/ QxJuMhiHLC/IklgRKerZuXS1AoTr+vfLsPFohwH5spZeKgIwaoP74hR8Ri278aSrv2C1 yx4Q== X-Forwarded-Encrypted: i=1; AJvYcCWcGrSA3+uvjwigISRLoLeEn+q+HazJ2RXhEdui1hdPP/sU6AJ5vyvJ8pdX//SOD5hL42Lt9NXYUkxb02QSXHnbM7Q= X-Gm-Message-State: AOJu0Yz9Bpted84fZJClyYpGha3OgNGMHrvdCaYmes9UvOrij4yFi/4k fRbs51GfmHgFefQvK/36D2cYkeEgPuijxHByPYgxe9P1PlUS0yFzK3Kp4Ec+SmVf/JuZUTJQ0Ue 85to4U+BsizlcjPzCvQiw7irD5pIKxzGu9J9Hn/zED5Ieu/lF X-Received: by 2002:a05:600c:3b22:b0:41a:8b39:8040 with SMTP id 5b1f17b1804b1-4212e0619bbmr79988985e9.20.1717437493885; Mon, 03 Jun 2024 10:58:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbA5kYzyT3IQZ0xDZw/dNHFGjxWu9vmLppArFpBQzO4G92OPsYCQUslLVo+bgBqm18bo3YVQ== X-Received: by 2002:a05:600c:3b22:b0:41a:8b39:8040 with SMTP id 5b1f17b1804b1-4212e0619bbmr79988865e9.20.1717437493520; Mon, 03 Jun 2024 10:58:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:3d00:918f:ce94:4280:80f0? (p200300cbc7313d00918fce94428080f0.dip0.t-ipconnect.de. [2003:cb:c731:3d00:918f:ce94:4280:80f0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4212b8b5747sm123145165e9.45.2024.06.03.10.58.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 10:58:13 -0700 (PDT) Message-ID: Date: Mon, 3 Jun 2024 19:58:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory_hotplug: prevent accessing by index=-1 To: Oscar Salvador Cc: Anastasia Belova , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20240603112830.7432-1-abelova@astralinux.ru> <3c2b1b1e-c9b3-442e-8f7b-5c7518d3fbdb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A998CC0028 X-Stat-Signature: 5rijy5cjqzyrnq4c8py1rg43xf87wug7 X-HE-Tag: 1717437497-872052 X-HE-Meta: U2FsdGVkX1/6zBRF48e/jEeXhBcsG7VERfrn13rxTbMzTJCOvHWa5Dvr5xKKMly24mpJ8035GegSv6tuB8yw6EkEvguk3nl8zS6iCI3zQKP0epScqhr1H41ckWLFwQjBiCHKCLixLeNxpN1Ol8Jz/IranJD4SZbajyyZM985IaWb3Evo4WuHIkk7pGvPzpZVgiAA7JRjmJWC5xNg7DoASF60b0b2bi9KHitgOwVZ2c/K9nzT1nT0lfpeD8Ul3UbIBBPh4rykacS/lc8bjlLAU/8UMEf1N77W4e/o3IEYtDwU4jowaenqpk32np7o20Vwnvl5GWBvXa0VhfGhLOXkfnJ9YHBjhOzqWRK6CCW0/RXjzZbetg6RkL17k3wC1quAqVV43tlHmWHhNyqVFNxadPHqezzdMbMbMybx0IJMl2fDhXvFd2dURc3QhKwMkA6upuRWSUQ9YZHMocjLoUeYyxxq4bLmkG1g+UDnfvWkUIYNeM64KX96UFnkVUaVvF4dA2PXfeailOF0xf5s0MPGPlqPA74jW66ySKLA2SWdzgFzqLnJQqno441dBIEs/tagIpGdrzZe2Y0e8KANzMhDHgPVgE6bG8Fy5sNCdG0OXaMeCHcd6QjFklc4U8bsybmufBnGIC/PoMVbd0jiOWudZcfG0G5r8hT7XIrNfj+8Lit9RN9MAs6KPy3SSr/bj2R/BN3pFlOCd74b9vTqMv3lUl0Qq9S1k+N3gNlp7rpGEG7lsntDBLyVLaPQr+eVWn8FDPSS2/DnPIUp+mWNJ4BTvsS8SlnC8yI5CulXFSlPZ5XnsgUlVpOLjjFUjCLsm1inSfHRZLykQWTXxOqlZzvHwHrSBQVmM6fSJVTACKgXPsLtEk12vAYNrdYZmCBy1K4taNbeqO7SqnErhuW64aS+nAVRW1P26XH3TsjYfEoIjABfQVFdyI8CHsZvJA6Crrn/uzft7uyoFOn1fpB1B66 tUHKCEL/ ujmJTuaLaYDHltoFdW8CxOtVbMFZBVjrtfmNsWbyu+DlapxDBXilY6P6rEogBO9PlwBW3hoJ3Ejy1CJFIzbsp791yqZTvUb1eai9UcuwWAz1U/P2yt0MHioq9BDsHpDHKxAxB1pCUnFxaB3l35p1v4fY+HzRZuetdGORUpD/4LZNt/b5CWEI2tpL5xTdLBlgRPWgtscD04AJ6RUpGgGvAlgtTx1B4MIvpghRs0Z9X674PCLRxqAII2RPS+UKrzaShjs5skwl4YjPEwbVJtTxxS8cfk5gAwy5ROkSXTKhIoPOH9esQfehzGnk2uAjKJXT03hXPvlPZux21jw38VfBCpIjj4104Obm5wiQP2KbzGHf7HB81PP+n0H0g3Hzy30wihptJ+8aWIulkn/qjTz4sOGVKyzxBALRsAXAlk027C2AMwtZUc/2aRN1HocYHiswR7PKzlOYlFk1Ljnf5gn+5EtmpIyNjuD+rNDXf4sYM9rLcggc6jMhDKCd8MbCr7TtncB8Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.24 19:53, Oscar Salvador wrote: > On Mon, Jun 03, 2024 at 06:07:39PM +0200, David Hildenbrand wrote: >> pgdat is never dereferenced when "nid == NUMA_NO_NODE". > > Right. > >> NODE_DATA is defined as >> >> arch/arm64/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)]) >> arch/loongarch/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)]) >> arch/mips/include/asm/mach-ip27/mmzone.h:#define NODE_DATA(n) (&__node_data[(n)]->pglist) > > All look fine, but mips. $ git grep MEMORY_HOTPLUG | grep mips | wc -l 0 I think it owuld be problematic, if mips would support memory hotplug. Or am I missing something? -- Cheers, David / dhildenb