From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.com>
Cc: Anastasia Belova <abelova@astralinux.ru>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] mm/memory_hotplug: prevent accessing by index=-1
Date: Mon, 3 Jun 2024 19:58:12 +0200 [thread overview]
Message-ID: <bec46a43-bd0d-483d-bc75-cd8cb6557e34@redhat.com> (raw)
In-Reply-To: <Zl4DM_4ll3gFnYLw@localhost.localdomain>
On 03.06.24 19:53, Oscar Salvador wrote:
> On Mon, Jun 03, 2024 at 06:07:39PM +0200, David Hildenbrand wrote:
>> pgdat is never dereferenced when "nid == NUMA_NO_NODE".
>
> Right.
>
>> NODE_DATA is defined as
>>
>> arch/arm64/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
>> arch/loongarch/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
>> arch/mips/include/asm/mach-ip27/mmzone.h:#define NODE_DATA(n) (&__node_data[(n)]->pglist)
>
> All look fine, but mips.
$ git grep MEMORY_HOTPLUG | grep mips | wc -l
0
I think it owuld be problematic, if mips would support memory hotplug.
Or am I missing something?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-03 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240603112830.7432-1-abelova@astralinux.ru>
2024-06-03 16:07 ` David Hildenbrand
2024-06-03 17:53 ` Oscar Salvador
2024-06-03 17:58 ` David Hildenbrand [this message]
[not found] ` <20240603-4f7a5fd957aa1f9cbc8d5f14-pchelkin@ispras.ru>
2024-06-03 20:15 ` David Hildenbrand
[not found] ` <20240606080659.18525-1-abelova@astralinux.ru>
2024-06-07 7:34 ` [PATCH v2] " Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bec46a43-bd0d-483d-bc75-cd8cb6557e34@redhat.com \
--to=david@redhat.com \
--cc=abelova@astralinux.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lvc-project@linuxtesting.org \
--cc=osalvador@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox