From: Antonio Quartulli <antonio@mandelbit.com>
To: Zi Yan <ziy@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Kirill Shutemov <k.shutemov@gmail.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory: refactor after-split (page) cache code.
Date: Wed, 16 Jul 2025 21:01:25 +0200 [thread overview]
Message-ID: <bec0d00b-1284-4d45-bd42-f3089898ff3f@mandelbit.com> (raw)
In-Reply-To: <20250716171112.3666150-1-ziy@nvidia.com>
On 16/07/2025 19:11, Zi Yan wrote:
> Smatch/coverity checkers report NULL mapping referencing issues[1][2][3]
> every time the code is modified, because they do not understand that
> mapping cannot be NULL when a folio is in page cache in the code.
> Refactor the code to make it explicit.
>
> No functional change is intended.
>
> [1]https://lore.kernel.org/linux-mm/2afe3d59-aca5-40f7-82a3-a6d976fb0f4f@stanley.mountain/
> [2]https://lore.kernel.org/oe-kbuild/64b54034-f311-4e7d-b935-c16775dbb642@suswa.mountain/
> [3]https://lore.kernel.org/linux-mm/20250716145804.4836-1-antonio@mandelbit.com/
>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
Much easier to grasp - Thanks a lot!
I am sure Coverity will be happy too at this point, because the
ambiguity has been fully removed.
In a previous email you asked me how to prevent Coverity from
complaining about certain code: my thinking is fully aligned with Dan's
reply. IMHO refactoring the code was the best choice - thanks again.
Regards,
--
Antonio Quartulli
CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com
next prev parent reply other threads:[~2025-07-16 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:11 Zi Yan
2025-07-16 17:59 ` Dan Carpenter
2025-07-16 19:12 ` Zi Yan
2025-07-16 18:14 ` David Hildenbrand
2025-07-16 19:14 ` Zi Yan
2025-07-16 19:01 ` Antonio Quartulli [this message]
2025-07-16 19:13 ` Zi Yan
2025-07-17 14:46 ` Lorenzo Stoakes
2025-07-17 15:30 ` Zi Yan
2025-07-17 15:45 ` Zi Yan
2025-07-17 19:22 ` Dan Carpenter
2025-07-17 19:27 ` Zi Yan
2025-07-17 19:33 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bec0d00b-1284-4d45-bd42-f3089898ff3f@mandelbit.com \
--to=antonio@mandelbit.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dan.carpenter@linaro.org \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=k.shutemov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox