From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2792C7115C for ; Wed, 25 Jun 2025 07:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 880AF6B00C4; Wed, 25 Jun 2025 03:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8328A6B00C5; Wed, 25 Jun 2025 03:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71FD26B00C6; Wed, 25 Jun 2025 03:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5DE626B00C4 for ; Wed, 25 Jun 2025 03:43:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC4D95F83D for ; Wed, 25 Jun 2025 07:43:34 +0000 (UTC) X-FDA: 83593133148.18.0D65FA5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 7E2C240002 for ; Wed, 25 Jun 2025 07:43:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh0SzgwG; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750837412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+VWyYD7FtmHGvesh+xzgd8YBBQ92N0ZCiKER/Pbh68U=; b=pUWP3Wtrm34cfdyL+b5/4JTiMJPVTdCwhxL0jNE2qA7UIN1hFZslbfMQZnBdiJW8wfdMc/ IlKiHLDVMCImWgRp7BUnSncFwoW70it6J5pAc4Rq3WSV2Dc48Xpq5OLqpijSBcyvAxLbPW uJ/UqjGNXrG9R5qhMJ0bHn8SVM5JCZg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750837412; a=rsa-sha256; cv=none; b=5BVciG/NR8trqsIKtrbxtFlj1cYvVL1YzeyDyuS28wfT29BbCARf+DCB9nyHuzaGxejnTS eHmmEpgwbw/eN7Ls1F2DrCA98YJuK/BjCWxINT/pAPgRnF1Sh42j2n6WXSSuqTuhHkACl7 cSZMIBUC1mYXHdxcAjZpLCFUm7ouFb8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh0SzgwG; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750837411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+VWyYD7FtmHGvesh+xzgd8YBBQ92N0ZCiKER/Pbh68U=; b=Eh0SzgwGBQRKYtTLoFohq/ejY4GIx0geBhCpVw3m6hMlFDX7QLMofbHApFthBfBDqNzDB9 0dJGXAuUxtEjOT3Yi+LeMVFpU2TKTr9SUROISQ0mYCTGabcXzpgm9kjFJ4Iw+/2cg8Lem9 e2Tl6oeI115cT+6asDKZppItE0jpet8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-E3CuYl_8NNibl39TjqBrFg-1; Wed, 25 Jun 2025 03:43:30 -0400 X-MC-Unique: E3CuYl_8NNibl39TjqBrFg-1 X-Mimecast-MFC-AGG-ID: E3CuYl_8NNibl39TjqBrFg_1750837409 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a5058f9ef4so544534f8f.2 for ; Wed, 25 Jun 2025 00:43:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750837409; x=1751442209; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+VWyYD7FtmHGvesh+xzgd8YBBQ92N0ZCiKER/Pbh68U=; b=r+FLpVj6+54smtspEKKnq+KN0ZjIsPIqIsXZ0djkZM9g1wEX9Mn9NfzIxku9Krh5mt 1MLOxx6yW9rdnvUGkHNCEe9lFtVlHJqdSWeTwjEhjh08nDsDXas+PQ8jjrLPRMUbG5Yz /ucwCXqr9f2UOj7onQV24XaKoueYy0Tzxc+ARjIPYQHcH5GhJqNsMjfqEsz+pJjYbA4q wriye98/R1Fl9ZAW2VIim+EXnBkhO87cmvrcXwuckGlrmOF/kBjGVdkxPGZL5jCgK1BJ 6ay1ORjPfdNysykGrHo1XxAShyBu+Od9I74DpjTrv0dnQ4rUMWNKvxAewun99o3WUzd8 9OQw== X-Forwarded-Encrypted: i=1; AJvYcCWzphKaP2j808r2CQEghPTX/kYI4iKGumuIgQ2aVq4WOke+nZcUcZltZ9zCkAdevjuGAPuUjQY1qg==@kvack.org X-Gm-Message-State: AOJu0YxMmqjGuoHL6H1mbCDL6tzCSfQivn2KdRpJY8RQ2PPKEDrhzWDl rz1QgVblc8Z+Ppg+zFsi9k5R5PjWULBWKehAGAQhu682c7iD42v42SBfpSw0pLtUgvbd09Zvm3z DA1qK177+ruxO0TsGgmQjBXuzyRzx4tgincpH15i2jM7h5j7FAt+7 X-Gm-Gg: ASbGncs5Y9p+uud1C/tkg9NcF0Xy+iBvH/tWWRypvSOMWwydLB3DyZSc0ugxjxN0BDP zUEqSXnEut4wsBiMvDCkP2Dt4AUZcFYzAi48gZ3+BXnfVpkwYMSb39riIqc6Csrefq0wFnUIjC6 JdMn80etkor4p8+2sDPGWVx/LvBznUbiQLeqtgAAXhiW64PwKKRYBpYhTM+PlHmqLJWUbitpoAZ JOMFtQN5gearwqEO+FZbTiumsX1L1BNdhE5q4ccf4H/oTtuXusTmlmt5XieYHKh5fVwVToabEms seG8xve1FxczMts414sDyA+3jqRplZeDvBvkVj8eWPnMsjc8maJJxGnG3gnR/J7SWmYBpLzeb3A DPY39hdz1OKHNPs32ChlOPvrKBpGb7VvZyY3hKLNJphkq X-Received: by 2002:a5d:5c02:0:b0:3a5:2182:bd11 with SMTP id ffacd0b85a97d-3a6ed62252fmr1347701f8f.20.1750837408863; Wed, 25 Jun 2025 00:43:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIp7DbbYf8RkCcHIGYXE8Zg5wPhCbUB0jKNR96tEG2aN19m8kumRsKhWJIAr3MONXFci4j4A== X-Received: by 2002:a5d:5c02:0:b0:3a5:2182:bd11 with SMTP id ffacd0b85a97d-3a6ed62252fmr1347683f8f.20.1750837408475; Wed, 25 Jun 2025 00:43:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45382382299sm11335015e9.40.2025.06.25.00.43.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 00:43:28 -0700 (PDT) Message-ID: Date: Wed, 25 Jun 2025 09:43:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm/madvise: remove the visitor pattern and thread anon_vma state To: Lorenzo Stoakes , Andrew Morton Cc: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , SeongJae Park , Suren Baghdasaryan References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: imBMEpexZ1C-NYj6kzao9dxVQalhpdjmPXVTVVdEnqg_1750837409 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7E2C240002 X-Stat-Signature: 8cx1sxpzi8341bh4a8536tppfpmxhddy X-Rspam-User: X-HE-Tag: 1750837412-301340 X-HE-Meta: U2FsdGVkX19aHMKGjENbPHVwBf8kCohGWEnwNL8s8VJxohXsjTcyoBXQjS30yMg3eSkrm8x4o4mRxZ2tyVSTXbAIVCkEALequKl/0XnWS5PeXNuBguYJoJcGlk4I0jAvazQO90bPgU36zFqwTHYyTabeDVdwYLm09dYPE5xqz0wq6XKV4NVYb4chQQQzINFt9xRzeLZD6xfr1+S2XASzufg656wim5VgqWgLYvOv5S+uCVlZPNAYm8y33+62k+j6hMfeefE3P7tB68W1jZrhKnGiT46FIEtfIn3jxNHVu365h89/etrOkfWRKGzXOKYRN3K+MbJS+RhWqTAxNtRQk0+t+rKaFfJkRMG5lfbMimCn3L9d61qU4Py31fFYgdhle9SGVPqcabDmb19nGYeCUKjuuVn1LbK2a8dfye9f+S01Y/yspZyDMAS0ebcAfv5g1PW1Zbbcre0Uz7Fd5AbgLIqdn/rVi6Nw34JHPhE/3CWIV2bi3rNndQxKwBnSINwNcJ8G+2pQi+oorYrkHDRvDxYw2DcyU1IXE027pNhe/5/hfbe0qcr3YwwiREY0VpO0SfHe6LNYLUyQ8+y0k70P+YQx2sM4QkbCBUPv+67m0gRV3o6Kq71EDyV+ow8TRPKm/ET8brEKNv9qocxe87bz9m7T4vwap44J3cj8TGCtxKEL0apO3RjZAMMselHWusyp05CwKdzOrlYA3jD4H0FeaqvtWd2pZrNFni6VAmIEM3TSgxJacBS/XKLlTb1XUUPCo6sBeVDjftlAYE/m1Y3uuXbnRZMfYPpKCaEH6qir5WmvTZj2wqf6UeyUbOF1EBHa9ssdqs1TqxC9Ohkv4ZJW1cZ/7F91ejM60YUKiN8OS94VFZXbETUyK1a9WnZz0MPp/XByCJx8Sq4qL917S98erNIEootHp/uksqk/8QzMfbk04dqzuvmGaGsP4WcjSSsqlU/47QJHWFahSxGvrXS gX+z4UEf Zb41M5rTcSYSwDFl59dhmAVlnDnE1quWMjAtU0GlBVgmg6BdJr1/4NRZsrUa1WcxoLII8cc5ZrXjWnTKHXz6KTD7AXEG884bWQaiPfnqUlFxxywcIhdWx4cbFqkTNAzI8UHfv44Q5VueTUsAw29PBQ9N/PyW1sxnOQrA3B7Rt9pWvBIA5epFoRlYE+ci2eX3KfiSVFgey+5kL+NieNeJsNMMGiP4nhOxvxOEUcvabyE2yD+9w2a1pFYb8ZoAGaoci2vrJj/XOve2LH0WbfZeC2c+d6Mpd7TTBmtLdZ1+eEGtgbee0v6JKE/agEFOrtNADCK5oVquviN7xoXNyGM4G/mtwkWZqzWFnOCxWCOZpbywLocXiICl3g0F/ldDU0VpwFnEoXuM8DJA2DbEXlAdImCZiKthLd2db5aztX/WM7Fl2oH0eFuWW7Ckltp855DUMfNpt8d+uPWzmjZ4QoAD43svHGYej941myntW3/e4t9NW4KJIGdPFncPaig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 17:33, Lorenzo Stoakes wrote: > Now we have the madvise_behavior helper struct we no longer need to mess > around with void* pointers in order to propagate anon_vma_name, and this > means we can get rid of the confusing and inconsistent visitor pattern > implementation in madvise_vma_anon_name(). > > This means we now have a single state object that threads through most of > madvise()'s logic and a single code path which executes the majority of > madvise() behaviour (we maintain separate logic for failure injection and > memory population for the time being). > > We are able to remove the visitor pattern by handling the anon_vma_name > setting logic via an internal madvise flag - __MADV_SET_ANON_VMA_NAME. This > uses a negative value so it isn't reasonable that we will ever add this as > a UAPI flag. > > Additionally, the madvise_behavior_valid() check ensures that > user-specified behaviours are strictly only those we permit which, of > course, this flag will be excluded from. > > We are able to propagate the anon_vma_name object through use of the > madvise_behavior helper struct. > > Doing this results in a can_modify_vma_madv() check for anonymous VMA name > changes, however this will cause no issues as this operation is not > prohibited. > > We can also then reuse more code and drop the redundant > madvise_vma_anon_name() function altogether. > > Additionally separate out behaviours that update VMAs from those that do > not. > > Signed-off-by: Lorenzo Stoakes > --- Oh, that is very nice Acked-by: David Hildenbrand -- Cheers, David / dhildenb