From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6E6C27C4F for ; Thu, 13 Jun 2024 08:27:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 702FC6B0089; Thu, 13 Jun 2024 04:27:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B11A6B009B; Thu, 13 Jun 2024 04:27:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551886B009C; Thu, 13 Jun 2024 04:27:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 384E56B009B for ; Thu, 13 Jun 2024 04:27:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CBC4B80746 for ; Thu, 13 Jun 2024 08:27:23 +0000 (UTC) X-FDA: 82225185966.27.F842657 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 88D0C4000E for ; Thu, 13 Jun 2024 08:27:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HWo05YC0; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718267241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mVWbEwLkmTG3QxviBeXZ0j8iNWtBX8pqTS6OYMhDmzI=; b=MVLUXUV1XNPvaLOfn3jiEDUPFxft/Op5Hk+LsSRvTwn/axfvWi/0ECOrywH+H3jD/NI34Y QlDmjEro1mcCnh51SkIRlD7/cGENToNZqpxK3hcI7p2J8999Y42+ao9dgf1/xmp9llKfOr aUESQH+uKCToj0EMVhPIvZrxMNapqxg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HWo05YC0; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718267241; a=rsa-sha256; cv=none; b=trs4pW81Lat6lSHJREMNYts41PjKsN3Ca2JLVsz5OmyzKaUxxAqZO2nNTXf2pTxSfqzhph y46ggvAdtzNokkAeXg/3qICSdqFRSDVn86nslcI9WKOUhb/+YdyOl+xEZo1NHj8YCsE21N b8w5ZzCdW5HO1hfzItJ5Kz26JQ3t9KE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718267240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mVWbEwLkmTG3QxviBeXZ0j8iNWtBX8pqTS6OYMhDmzI=; b=HWo05YC0X6UF3NYosutFFf8E6Yidv1C1szXHIECAKdUWoXVFaSkztUgHlq2XweUjlPGEzT v0wNrdzYPeqNWXPMMUaru62llefO3Xd5bdomdtyRJKa1k33oEKKmZGKGHzAOkPegUMH5Ie RVNci52uIsRUbqnBpHrGu9k9cXzx0Xo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-X5t2ZXvePESC9pSSG9xJ0w-1; Thu, 13 Jun 2024 04:27:19 -0400 X-MC-Unique: X5t2ZXvePESC9pSSG9xJ0w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35f0b9c5bd4so407469f8f.2 for ; Thu, 13 Jun 2024 01:27:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718267238; x=1718872038; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mVWbEwLkmTG3QxviBeXZ0j8iNWtBX8pqTS6OYMhDmzI=; b=VAvWO3EsXDsvg9dkuTkFOXCuLzhWDbQBjmO8Dszyefu6tzkrCSjCMewCKS5u2RBJHC akZ70AIU168yETab0yllMfTc5tjGxdSdPQXbg5Bx723aK8kM1OO1NbUjmxR6x4kgdXti tliM7N3Il4uFbOPvRBXNDdfgsgZqcvxfqoWEPoHma6M6FLsn9ETHmLJl3AEV86k4e3S+ bO1S0NnjnQgkjS7ChzbT9SA4fkP2eUiL6q329uTE+QK589DgYSjpw+NbIJ0HLtlUN634 CC/w8pt2pja7rWWEsPQO1QPEUFhSDfYEgmiR6J6f2Ns6DlHeBRZwxb4Rl1TAp49XhLSq 6tCQ== X-Forwarded-Encrypted: i=1; AJvYcCX4e5qU3Fpk7NsTytJlwUgZaGR4ZFk9mst8H7py1FuJbelgRoaph+wzJmLGd5/Quf4Ai9U3d8QcNs7ofDwOGU9fv3U= X-Gm-Message-State: AOJu0YwFnlR5Wnv+VMPMYV+l1gCXx88/1uBAoHnlTUkRnCm0pfoAtSYh nTK+dQPrlzdXZIDqyQWBD/CQdhCpRzVpRyDiIXu0Gev2Ro0+M4Dp/xpl0gzgOZMVG0RzEjJ+I+c 5z9FTONy1ER8lgorZE7fiQNaBpLBbmqBCrdiUyxeMxd5ovgMD X-Received: by 2002:a5d:4a4a:0:b0:35f:6bd:e5bd with SMTP id ffacd0b85a97d-35fdf7886e0mr3331031f8f.28.1718267238124; Thu, 13 Jun 2024 01:27:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDUhe1bL30rQmXpqr/MZocb4PwSZe7VvtVDrLJh4moreiNqON5efdkqCl2GrLvnkyKLDNAUQ== X-Received: by 2002:a5d:4a4a:0:b0:35f:6bd:e5bd with SMTP id ffacd0b85a97d-35fdf7886e0mr3331006f8f.28.1718267237726; Thu, 13 Jun 2024 01:27:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:fe00:10fe:298:6bf1:d163? (p200300cbc703fe0010fe02986bf1d163.dip0.t-ipconnect.de. [2003:cb:c703:fe00:10fe:298:6bf1:d163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750f2271sm976489f8f.85.2024.06.13.01.27.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 01:27:17 -0700 (PDT) Message-ID: Date: Thu, 13 Jun 2024 10:27:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop To: Barry Song <21cnbao@gmail.com>, Lance Yang Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240610120209.66311-1-ioworker0@gmail.com> <20240610120209.66311-2-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 88D0C4000E X-Stat-Signature: wfjtjs71prqu7y6bfnuf94agdr6rq8co X-HE-Tag: 1718267241-887293 X-HE-Meta: U2FsdGVkX19AHIQHx8QTZfJMa24ki8PR6bxSEYZGPLGZbD4Aj5vxiWwFn4XKCPwrxfnsLR3bnw+WE/XY15oqpvW0X5F1eKJjvC6CvF9ZOAFveCQczLrnRT8/ErxpPfrmt2yImawgGzBIA+nWIP1OZzNI96iHjakfPgFHnylyBMlGVyapeBAngQ5/mQka3cf5DSvSfNIDu/ObK1JqFHePI7tL8haxoeK9juzAD0iSqafFzbf4tlIIy+5FMSWf0lbeDE7ktN8EGsOWZYdF/HAR7V00Zd1nBLwXuWeQlRojhS3UtfPF2HWiMDTvvTbnss7MHhPMTXI1FVC5tQrXTaDAdhcrmscaXra4Y1Fx1/QXOucu1iJR+ttMQCV5pjHkuLxE/4AYKKbF/cxAGkAnhIkF+kAe+wgK1f0QUQj5tMjPZDEagmdqpKx5QbCeC757KuY/p11W/afXHxI/IMoRodn462pI0wP/9qi6t9Ev9pQjzzAPNabriU/RoEqYTM4+pZbGVufDMQNauB+7UxreCz0luQDA1b3aVZ4k2Uj1PxIHt4sGs+CnRDgWBok2Phjcvbo5amDtjh18DCgb1yDSyFuIaYzgsPhtv6DqfJe1+4XVV8LS69OIoN4K2ncr8hZPcTiPdH4V3HHSZ4EcfMhhLWvH4m3WXi4eQWlLEl1I0Lny1TvRGFXUGQ99QKntNMr71JWXqiVbPNp78WVghXj7Li9TTxLzrj5ojcsHPmRYsI/vCqcDmcdVcWS6xDSH4acY4jZDUabKSOp4f8ci1RvplBZmKlbi1ulL9nGiazA/XA+G4rb8iDqwBlMRd+VT7Cqykc84KFwY38ha0zJ4yxaxdUKlEUfgz1K/jtKO4c/HoDh7Pbo88Kq5UOppkvhfBGbvHNHSCEvcRWHgmV+6ZkZ+TpL0bw49UKm4tVWeqrIw3XD8sb19tTcI+GJk/+mIl0wvCHnWdkWn+RtiIpxE5D+ERbe 0KcQFpEL 8nFjgHZ/b90BKeR5+VMNfir7QzV3DHSSP6IUnGTJC66XURuKAWdeObIk0qh0+/kHdc07zhiaXt2KBbJhu4hoiVf7yTqkw3/f7eP/sg5Oo+vnXqWN/C5Z5fhu9gshZ/+yNOqcTIJyVd+OpixjfJV9iZg8oXUniM8v+fCpBHDJ8G5ZI7MbEbSFJyF4dfcqSrhxjGON7j59b57gDs8ZvCMrXnYUKNTUJaceWMHrxMOU6lZfiV3pEtZsTAqAasaSd6MkXkC6OooPqnJIKvclCbeusK+EjWMXeOTR3UbAtsEQN3nvLOck1/YMYD9GS2qCYs6RHaeyAzuK/yWv+EIG6l2x5q8AJ3GKzoi9zUEfNgBxjv+SSuVhcGQw4KM+o/XvS1+HUhbvLjLT2kREDLpzp+H61AXvgqjBnVpZ0GpA8MZgTg76q+6Mk9tfKow9x9aBt+Ar+g9/1cRMXtxEjs6TLf+8ZeuXnVsuO1TsxN4LAr4Onotu5w8YuDnjS7t/w1GZrXc4d+iBANrguzccdgVv793IOCbAwH+OuVh4t92yhhJOIVJtbyqIcPxCMnZ2IxCcCk5rjTCweoVVLHFrfz8w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.24 09:52, Barry Song wrote: > On Tue, Jun 11, 2024 at 12:02 AM Lance Yang wrote: >> >> Introduce the labels walk_done and walk_done_err as exit points to >> eliminate duplicated exit code in the pagewalk loop. >> >> Reviewed-by: Zi Yan >> Reviewed-by: Baolin Wang >> Reviewed-by: David Hildenbrand >> Signed-off-by: Lance Yang > > I don't think "return false" necessarily indicates an error, so > "walk_done_err" doesn't seem like an appropriate name. > However, this is a minor issue. Agreed. As we only have a single walk_done user, should we instead remove "walk_done", keep the "page_vma_mapped_walk_done" for that single user, and rename "walk_done_err" to "abort_walk" ? -- Cheers, David / dhildenb