From: Dave Hansen <dave.hansen@intel.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/mm: clarify "prev" usage in switch_mm_irqs_off()
Date: Thu, 22 Feb 2024 10:47:03 -0800 [thread overview]
Message-ID: <be7188d7-5636-457e-9df9-11242cd4947b@intel.com> (raw)
In-Reply-To: <ZdeVwiaPvUVQRiWJ@google.com>
On 2/22/24 10:43, Yosry Ahmed wrote:
>> /*
>> * This optimizes when not actually switching mm's. Some architectures
>> * use the 'unused' argument for this optimization, but x86 must use
>> * 'cpu_tlbstate.loaded_mm' instead because it does not always keep
>> * ->active_mm up to date.
>> */
> Yes, this is more clear, thanks! However, Andrew already merged that
> patch into mm-stable, so it cannot be amended. I can send a separate
> patch to rewrite the comment tho if you'd like, WDYT?
>
>> Also, I think it might be useful to have the rule that arch/x86 code
>> _always_ calls switch_mm_irqs_off() with the first argument (the
>> newly-named 'unused') set to NULL. I think there's only one site:
> Agreed. I can also send a separate patch for this. Thanks!
That would be great. I'd be happy to ack them.
prev parent reply other threads:[~2024-02-22 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 8:06 [PATCH 1/2] x86/mm: delete unused cpu argument to leave_mm() Yosry Ahmed
2024-01-26 8:06 ` [PATCH 2/2] x86/mm: clarify "prev" usage in switch_mm_irqs_off() Yosry Ahmed
2024-02-22 16:48 ` Dave Hansen
2024-02-22 18:43 ` Yosry Ahmed
2024-02-22 18:47 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be7188d7-5636-457e-9df9-11242cd4947b@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox