From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35486C43334 for ; Thu, 7 Jul 2022 16:43:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 911CC6B0072; Thu, 7 Jul 2022 12:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C1486B0073; Thu, 7 Jul 2022 12:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0486B0074; Thu, 7 Jul 2022 12:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B9816B0072 for ; Thu, 7 Jul 2022 12:43:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3352E34CCA for ; Thu, 7 Jul 2022 16:43:42 +0000 (UTC) X-FDA: 79660875084.30.BB3D977 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf10.hostedemail.com (Postfix) with ESMTP id 496DFC0012 for ; Thu, 7 Jul 2022 16:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657212221; x=1688748221; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qRe5FE3ajVPGJtkZND3oU10bPFiWLZfh5hGmh1fXKJI=; b=Uptv8hxCaOaaSjC38Cc6KrkVPyYuscHfXVQnVAToNanonn4DWbtjqfbO I9jUwSowxJM3xqfl8baz/VbuFKc7wghpcMydbGhNf9Qqc1Xe8/+6YWQXI f+1QYyy4mmZAkhMCvuVccCHF7d7PXWhmsp673CO/7UIweZgOGiK9QLhJ6 DRp+t0LFhjbUm/s3Gfe/bTpcGLxvbLTxdrrYkBOSWChXc+TKQO13eFzVB V0LbEfr7wJVSLNCdWz2Sq/J3OYoNzWq/hndA809uJq87X19z3I3+cNoZr UXb43JJqP/1BFpCQ7cpYZUoNhlI/dE/dJlI/wpOzt+cULb4IGlFRmeXve g==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="284811661" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="284811661" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 09:43:39 -0700 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="620864809" Received: from nmajidi-mobl.amr.corp.intel.com (HELO [10.251.17.238]) ([10.251.17.238]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 09:43:38 -0700 Message-ID: Date: Thu, 7 Jul 2022 09:43:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms Content-Language: en-US To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-doc@vger.kernel.org Cc: corbet@lwn.net, arnd@arndb.de, linux-kernel@vger.kernel.org, darren@os.amperecomputing.com, yangyicong@hisilicon.com, huzhanyuan@oppo.com, lipeifeng@oppo.com, zhangshiming@oppo.com, guojian@oppo.com, realmz6@gmail.com, Barry Song , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Nadav Amit , Mel Gorman References: <20220707125242.425242-1-21cnbao@gmail.com> <20220707125242.425242-4-21cnbao@gmail.com> From: Dave Hansen In-Reply-To: <20220707125242.425242-4-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657212221; a=rsa-sha256; cv=none; b=y4GhNIQQKERk7u95aDuXkuNrs9zUQdoIjgEjo+sUiQLguEBmqKhwLyG4uVxvIbaCwyPZkJ G1Z6+mgw4QgskBpSdi511V6fO+dF3KdQ9hOQK/UUgH3w2xMKoDWd4llWUzCA15RIzlObUf YFErVJRDjwrPOsaZpltDGSui5SGqHKQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uptv8hxC; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657212221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bNxZUmR4CQY82FEi9amgselpWkXQfHxgX7X0Apv4JRQ=; b=pVHRSUNlgnFWIHk1s6/zdFrXhAaU2ynhSbtjCMul7lmij/nxrnboNp6Jfi+oD3EBBp7xA7 nVOX2vLyLjf6nUX3jQ8DXx/usNuNOvYCeMsiJjS4DljDCuRwyQmRLInH83GOupq1ZdgJT7 qvRlSSzjqv+QA9xwIQoKmeY5Nw5pVco= X-Stat-Signature: hs7st5km3cwqrksgcbaozgwttenficr3 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 496DFC0012 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uptv8hxC; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=dave.hansen@intel.com X-HE-Tag: 1657212221-618934 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/7/22 05:52, Barry Song wrote: > static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch, > - struct mm_struct *mm) > + struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long uaddr) > { It's not a huge deal, but could we pass 'vma' _instead_ of 'mm'? The implementations could then just use vma->vm_mm instead of the passed-in mm.