From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E112C5478C for ; Fri, 1 Mar 2024 06:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FAD76B008A; Fri, 1 Mar 2024 01:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AC676B008C; Fri, 1 Mar 2024 01:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84AD46B0092; Fri, 1 Mar 2024 01:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7168B6B008A for ; Fri, 1 Mar 2024 01:03:55 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 18E68C0500 for ; Fri, 1 Mar 2024 06:03:55 +0000 (UTC) X-FDA: 81847429230.20.4CFA428 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf29.hostedemail.com (Postfix) with ESMTP id 97DDE120012 for ; Fri, 1 Mar 2024 06:03:52 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KgxPId1e; spf=none (imf29.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.17) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709273033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bV1Gz6Dl7H9RUK6evukznAmO0TCbRdipIWbviWyfsj8=; b=1ZLcua4+OV65Wx5/oBJH1z6cnKQ4pgsbqHvS99OJmnN9p9H5jODKN0fqSR1ojCIEPvmd9O MkWEUueMsavLIrCOLa4CGyH+67URonyMqBF29nnlbKthwFNpr6kwwtrwI4i2uGLxesKg4q N2BPGHKE6/BNFla4MB4f34kdfoQr+L0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709273033; a=rsa-sha256; cv=none; b=YLB52bxwgfyk2fnVsABFQ5pKeHrydhSRveTXD/LoTSS3oKdkI4DLYAqecLurPfSk0bcQzc gNhT4x1zx/fp4H2JE+kgYFqEJn6Fp+EaVq9iTzFZXn5hGaTAroZekC6Wk0in8Rl0KYqPm3 fOXyXPjEU/u+yf67XLmCPA3wTMJoucI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KgxPId1e; spf=none (imf29.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.17) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709273033; x=1740809033; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=WiOE6B/1DjVmqpfsFWJaZBJmng/+ZV5XML+tT/5b928=; b=KgxPId1e7rQWZjIVI1y8CVWMk1htqje058kicVxxEyzqbzxJ9oP9TDX6 SBGdY0s15Qt3SHRChLarMOHo7FK9BMrEHwmc9QZVcCY7pF80fNuvwkzDr tWQxV9eEI3tiW2VBDdjo9z/xuI8/cu68V10mcBsPkM7YI9/3oYF1PVnrx /uhz5IS/hXXu7nF2OvR0idhlI9ZkvMq/phhLoHzbvml5wbsvauJ9Fg6l8 iRfrHXLfMVwhY2l5bjeOTVjmOCXwIZRYeYJXwz79aJL18UFZt/f624hD9 N8P8eaGg7sgcxzHfyd2X/OKPkdtMnbmVaHvLguG+EL+xP4rjdaz5YwMQJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="3966834" X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="3966834" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 22:03:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="8023261" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.125.242.247]) ([10.125.242.247]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 22:03:47 -0800 Message-ID: Date: Fri, 1 Mar 2024 14:03:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 12/29] KVM: selftests: TDX: Add basic get_td_vmcall_info test To: Sagi Shahar Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-13-sagis@google.com> From: Binbin Wu In-Reply-To: <20231212204647.2170650-13-sagis@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rx7wz143b9gigzouzhk5nzwpsj4oab36 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 97DDE120012 X-Rspam-User: X-HE-Tag: 1709273032-432374 X-HE-Meta: U2FsdGVkX1/q6OwNXDcWZkcvf16DUiHu8kJnbx8y6roqOG8qBI1CvMb+5DLuPJ/H/WNMFXStXHTl121iKLVXIhJt4TYYn6H499no5BjmMPNEhQGumgJF0NNU+OoiJ0OZ6YUVg5ataC9//oo4Ck9iqq3dw9seDtgCCuC35m3E2hLnU35PU1tFKeXG+sFDOBQ05dBNP9E3XAGU6xKaz/FbauicDLQiiaHcXx1+loiY/db7qDY1sCw52PXOiXdbKZld273PLTBcuumfiLQoSr9+hD/9vyVZ3RHyLY5SLIAONEZ1by8KS4kflS5+DEEO/GXQSH6gvQwuyDP7R+aejIFGAd1tju3pwTDcr90+IrqLdQrKp22Kv+UZrRkqMZBPVM1w/r9v8ikYD/4snudZMsepW5uXKhpAmbeIMbEt36duhGjp8I7b2AceMi1lxTSdmgyG0YeBtJh9+NhxRZl5Z6Yf1zM2ktgk60spqZMw37Uo0zlChJSZcl/HyLhsDCmALV3NdOORSffQhXYewZB0XidAFbsYEHCoUJHqB3QtfbmqSH7u+gGGdZk9w4G01OYJ2fVRb7B0kr3MKTQHzSXEDMTSER6kIhnwmRfK3q/LMRicb8XfxaogXFoJ0ZefhA1Gj20JHPh5yerOzfOicO8PpfM+fCurJqpUgcCPDvXuiRwdmuXrM087kV/1TGfPXRkjTpIoFJe/OETcA7wm7ooPz2v9L1UcFlx4xC3qTIGdmg56dQPOJ44ZdoqEQtP3e6FGrveaG2g/zHr2YI1N7h9fbWl/hFEQLTvJlTv/llZJLmSWqkRkDZ1L9NcfxKcepVddQjYjwslNI34kY0eGMRgNLSFXKMalIQ4B/5Oq/2PNlGkaHuyhDZbyetXs/EmMGIEmHORdmIq2E3TV8tnavMuRczLDAG/YYJd5y78Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/2023 4:46 AM, Sagi Shahar wrote: > The test calls get_td_vmcall_info from the guest and verifies the > expected returned values. > > Signed-off-by: Sagi Shahar > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji > --- > .../selftests/kvm/include/x86_64/tdx/tdx.h | 3 + > .../kvm/include/x86_64/tdx/test_util.h | 27 +++++++ > .../selftests/kvm/lib/x86_64/tdx/tdx.c | 23 ++++++ > .../selftests/kvm/lib/x86_64/tdx/test_util.c | 46 +++++++++++ > .../selftests/kvm/x86_64/tdx_vm_tests.c | 80 +++++++++++++++++++ > 5 files changed, 179 insertions(+) Reviewed-by: Binbin Wu Also, does it need to add another case for the non-zero value of r12 to test the VMCALL_INVALID_OPERAND path? > > diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > index 1340c1070002..63788012bf94 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > @@ -5,6 +5,7 @@ > #include > #include "kvm_util_base.h" > > +#define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 > #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 > > #define TDG_VP_VMCALL_INSTRUCTION_IO 30 > @@ -12,5 +13,7 @@ void handle_userspace_tdg_vp_vmcall_exit(struct kvm_vcpu *vcpu); > uint64_t tdg_vp_vmcall_instruction_io(uint64_t port, uint64_t size, > uint64_t write, uint64_t *data); > void tdg_vp_vmcall_report_fatal_error(uint64_t error_code, uint64_t data_gpa); > +uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, > + uint64_t *r13, uint64_t *r14); > > #endif // SELFTEST_TDX_TDX_H > diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > index af0ddbfe8d71..8a9b6a1bec3e 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > @@ -4,6 +4,7 @@ > > #include > > +#include "kvm_util_base.h" > #include "tdcall.h" > > #define TDX_TEST_SUCCESS_PORT 0x30 > @@ -111,4 +112,30 @@ void tdx_test_fatal_with_data(uint64_t error_code, uint64_t data_gpa); > */ > uint64_t tdx_test_report_to_user_space(uint32_t data); > > +/** > + * Report a 64 bit value from the guest to user space using TDG.VP.VMCALL > + * call. > + * > + * Data is sent to host in 2 calls. LSB is sent (and needs to be read) first. > + */ > +uint64_t tdx_test_send_64bit(uint64_t port, uint64_t data); > + > +/** > + * Report a 64 bit value from the guest to user space using TDG.VP.VMCALL > + * call. Data is reported on port TDX_TEST_REPORT_PORT. > + */ > +uint64_t tdx_test_report_64bit_to_user_space(uint64_t data); > + > +/** > + * Read a 64 bit value from the guest in user space, sent using > + * tdx_test_send_64bit(). > + */ > +uint64_t tdx_test_read_64bit(struct kvm_vcpu *vcpu, uint64_t port); > + > +/** > + * Read a 64 bit value from the guest in user space, sent using > + * tdx_test_report_64bit_to_user_space. > + */ > +uint64_t tdx_test_read_64bit_report_from_guest(struct kvm_vcpu *vcpu); > + > #endif // SELFTEST_TDX_TEST_UTIL_H > diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > index b854c3aa34ff..e5a9e13c62e2 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > @@ -64,3 +64,26 @@ void tdg_vp_vmcall_report_fatal_error(uint64_t error_code, uint64_t data_gpa) > > __tdx_hypercall(&args, 0); > } > + > +uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, > + uint64_t *r13, uint64_t *r14) > +{ > + uint64_t ret; > + struct tdx_hypercall_args args = { > + .r11 = TDG_VP_VMCALL_GET_TD_VM_CALL_INFO, > + .r12 = 0, > + }; > + > + ret = __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT); > + > + if (r11) > + *r11 = args.r11; > + if (r12) > + *r12 = args.r12; > + if (r13) > + *r13 = args.r13; > + if (r14) > + *r14 = args.r14; > + > + return ret; > +} > diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c > index 55c5a1e634df..3ae651cd5fac 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c > @@ -7,6 +7,7 @@ > #include > > #include "kvm_util_base.h" > +#include "tdx/tdcall.h" > #include "tdx/tdx.h" > #include "tdx/test_util.h" > > @@ -53,3 +54,48 @@ uint64_t tdx_test_report_to_user_space(uint32_t data) > TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, > &data_64); > } > + > +uint64_t tdx_test_send_64bit(uint64_t port, uint64_t data) > +{ > + uint64_t err; > + uint64_t data_lo = data & 0xFFFFFFFF; > + uint64_t data_hi = (data >> 32) & 0xFFFFFFFF; > + > + err = tdg_vp_vmcall_instruction_io(port, 4, > + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, > + &data_lo); > + if (err) > + return err; > + > + return tdg_vp_vmcall_instruction_io(port, 4, > + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, > + &data_hi); > +} > + > +uint64_t tdx_test_report_64bit_to_user_space(uint64_t data) > +{ > + return tdx_test_send_64bit(TDX_TEST_REPORT_PORT, data); > +} > + > +uint64_t tdx_test_read_64bit(struct kvm_vcpu *vcpu, uint64_t port) > +{ > + uint32_t lo, hi; > + uint64_t res; > + > + TDX_TEST_ASSERT_IO(vcpu, port, 4, TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); > + lo = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); > + > + vcpu_run(vcpu); > + > + TDX_TEST_ASSERT_IO(vcpu, port, 4, TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); > + hi = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); > + > + res = hi; > + res = (res << 32) | lo; > + return res; > +} > + > +uint64_t tdx_test_read_64bit_report_from_guest(struct kvm_vcpu *vcpu) > +{ > + return tdx_test_read_64bit(vcpu, TDX_TEST_REPORT_PORT); > +} > diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > index 1b30e6f5a569..569c8fb0a59f 100644 > --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > @@ -260,6 +260,85 @@ void verify_td_cpuid(void) > printf("\t ... PASSED\n"); > } > > +/* > + * Verifies get_td_vmcall_info functionality. > + */ > +void guest_code_get_td_vmcall_info(void) > +{ > + uint64_t err; > + uint64_t r11, r12, r13, r14; > + > + err = tdg_vp_vmcall_get_td_vmcall_info(&r11, &r12, &r13, &r14); > + if (err) > + tdx_test_fatal(err); > + > + err = tdx_test_report_64bit_to_user_space(r11); > + if (err) > + tdx_test_fatal(err); > + > + err = tdx_test_report_64bit_to_user_space(r12); > + if (err) > + tdx_test_fatal(err); > + > + err = tdx_test_report_64bit_to_user_space(r13); > + if (err) > + tdx_test_fatal(err); > + > + err = tdx_test_report_64bit_to_user_space(r14); > + if (err) > + tdx_test_fatal(err); > + > + tdx_test_success(); > +} > + > +void verify_get_td_vmcall_info(void) > +{ > + struct kvm_vm *vm; > + struct kvm_vcpu *vcpu; > + > + uint64_t r11, r12, r13, r14; > + > + vm = td_create(); > + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); > + vcpu = td_vcpu_add(vm, 0, guest_code_get_td_vmcall_info); > + td_finalize(vm); > + > + printf("Verifying TD get vmcall info:\n"); > + > + /* Wait for guest to report r11 value */ > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + r11 = tdx_test_read_64bit_report_from_guest(vcpu); > + > + /* Wait for guest to report r12 value */ > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + r12 = tdx_test_read_64bit_report_from_guest(vcpu); > + > + /* Wait for guest to report r13 value */ > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + r13 = tdx_test_read_64bit_report_from_guest(vcpu); > + > + /* Wait for guest to report r14 value */ > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + r14 = tdx_test_read_64bit_report_from_guest(vcpu); > + > + TEST_ASSERT_EQ(r11, 0); > + TEST_ASSERT_EQ(r12, 0); > + TEST_ASSERT_EQ(r13, 0); > + TEST_ASSERT_EQ(r14, 0); > + > + /* Wait for guest to complete execution */ > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_SUCCESS(vcpu); > + > + kvm_vm_free(vm); > + printf("\t ... PASSED\n"); > +} > + > int main(int argc, char **argv) > { > setbuf(stdout, NULL); > @@ -273,6 +352,7 @@ int main(int argc, char **argv) > run_in_new_process(&verify_report_fatal_error); > run_in_new_process(&verify_td_ioexit); > run_in_new_process(&verify_td_cpuid); > + run_in_new_process(&verify_get_td_vmcall_info); > > return 0; > }