From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1FFC433E1 for ; Thu, 2 Jul 2020 15:36:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F39BB20737 for ; Thu, 2 Jul 2020 15:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F39BB20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B0566B0098; Thu, 2 Jul 2020 11:36:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78EC76B00A8; Thu, 2 Jul 2020 11:36:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69CD88D0012; Thu, 2 Jul 2020 11:36:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 54BB56B0098 for ; Thu, 2 Jul 2020 11:36:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C85AC181AC9BF for ; Thu, 2 Jul 2020 15:36:01 +0000 (UTC) X-FDA: 76993536522.24.spark06_3f0562326e8a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id A0F701A4A5 for ; Thu, 2 Jul 2020 15:36:01 +0000 (UTC) X-HE-Tag: spark06_3f0562326e8a X-Filterd-Recvd-Size: 2178 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Jul 2020 15:36:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 960E4AE0E; Thu, 2 Jul 2020 15:35:59 +0000 (UTC) Subject: Re: [PATCH -next] mm, slub: make function parse_slub_debug_flags() static To: Wei Yongjun , Hulk Robot , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: linux-mm@kvack.org References: <20200702150522.4940-1-weiyongjun1@huawei.com> From: Vlastimil Babka Message-ID: Date: Thu, 2 Jul 2020 17:35:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200702150522.4940-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A0F701A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/2/20 5:05 PM, Wei Yongjun wrote: > Fix sparse build warning: > > mm/slub.c:1267:6: warning: > symbol 'parse_slub_debug_flags' was not declared. Should it be static? Right, thanks. > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Acked-by: Vlastimil Babka Could be squashed to mmotm patch: mm-slub-extend-slub_debug-syntax-for-multiple-blocks.patch > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 62d2de56549e..cd260f18e6cb 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1264,7 +1264,7 @@ static noinline int free_debug_processing( > * > * returns the start of next block if there's any, or NULL > */ > -char * > +static char * > parse_slub_debug_flags(char *str, slab_flags_t *flags, char **slabs, bool init) > { > bool higher_order_disable = false; >