From: Vlastimil Babka <vbabka@suse.cz>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Hulk Robot <hulkci@huawei.com>, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH -next] mm, slub: make function parse_slub_debug_flags() static
Date: Thu, 2 Jul 2020 17:35:58 +0200 [thread overview]
Message-ID: <be58e8e3-3611-2fad-7b5e-b18cd4ae5764@suse.cz> (raw)
In-Reply-To: <20200702150522.4940-1-weiyongjun1@huawei.com>
On 7/2/20 5:05 PM, Wei Yongjun wrote:
> Fix sparse build warning:
>
> mm/slub.c:1267:6: warning:
> symbol 'parse_slub_debug_flags' was not declared. Should it be static?
Right, thanks.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Could be squashed to mmotm patch:
mm-slub-extend-slub_debug-syntax-for-multiple-blocks.patch
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 62d2de56549e..cd260f18e6cb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1264,7 +1264,7 @@ static noinline int free_debug_processing(
> *
> * returns the start of next block if there's any, or NULL
> */
> -char *
> +static char *
> parse_slub_debug_flags(char *str, slab_flags_t *flags, char **slabs, bool init)
> {
> bool higher_order_disable = false;
>
next prev parent reply other threads:[~2020-07-02 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 15:05 Wei Yongjun
2020-07-02 15:35 ` Vlastimil Babka [this message]
2020-07-05 23:14 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be58e8e3-3611-2fad-7b5e-b18cd4ae5764@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hulkci@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox