From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B06FC7EE31 for ; Wed, 25 Jun 2025 15:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B02DB6B009A; Wed, 25 Jun 2025 11:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB35D6B00B4; Wed, 25 Jun 2025 11:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A2CA6B00B6; Wed, 25 Jun 2025 11:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8A3126B009A for ; Wed, 25 Jun 2025 11:32:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33155121621 for ; Wed, 25 Jun 2025 15:32:11 +0000 (UTC) X-FDA: 83594314062.10.C473D59 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 51123180010 for ; Wed, 25 Jun 2025 15:32:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=phqxORsX; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750865529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=QSbIY9Yl8vGdIuAQaYjHaIKe7rsAqaxI1VrCaxGNZw0=; b=DyOcH0PouKBBlayf0XZSfqBrFQSOqCkI3gHucDh7b+6IvchMxG+rS5r6cQSt1mqV1ZhpGS AXSiLPK+iKqtcKabtAhJ+h0yGTgXg1z0KVDOdZYey0o8lp1M2ljeOkyk+v7PD1gm4Bk5FY 4GUbXlENnZwW8UhH9eOlsvD26EXnj7o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750865529; a=rsa-sha256; cv=none; b=putCeMEhe/wrhs0e3SrPpc9UtpEZc3mhUvlJ49jUUw3TjdyjNNP6nnzGTfLaDrmaUTvQnv aujq+fK+vRjIOLCGkNELIbhbRYzfdYDFzVgyC37dn3SpVga+2PaJkW/b3r6PtnncJRekbU h+G0nnGNYTsr9BWs8VQMIKem+mAehes= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=phqxORsX; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-60d63174f05so7923eaf.0 for ; Wed, 25 Jun 2025 08:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750865528; x=1751470328; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=QSbIY9Yl8vGdIuAQaYjHaIKe7rsAqaxI1VrCaxGNZw0=; b=phqxORsXMStHemIk2njixPswc+iffP7IzBvH4VwiFK38D0MI084wXVbMsYbCVP7eQ/ TRMjE9iuXMeZpKOGaE64cN1hF6RdWJLF9vLYDizIe/1Z0GHOC7i1j9E0O2Alpm7FVoP4 ixUdKUbQpC/VG4PBr61Y3OPFiHhv0CZBjtry80LboHFQG5HajCE5Vv4+4Jwinul9T7UD PKbHKDkUqXaeq3f1g5FClXxnKvXRUAtw5+TmZw+pGNxYTN4L2JyC2MT1n6E3w84QRY9c 4bMHRS8eliTunfTsC4wYgK3zw2nCSJUYjdxhlm8Yw7SDp2b8M4LN3ypcVvdUgo8kzngW DOHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750865528; x=1751470328; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QSbIY9Yl8vGdIuAQaYjHaIKe7rsAqaxI1VrCaxGNZw0=; b=JRlWXYMwqbT2I6iDR7BuB3Uq2RNirL3JyksZzAktWCIsxh2SFQSAopfhy3bcTGXIuG HtFx4jHa1zIAHkSSKoZ/WigbtLhKKkW5GIxPAE3gwVjvOL6+w9xtQGosCpBAQUgPUt5C tP2U5iU4o2DjTTTozkxwNHC/IseeHW4EoSBb3qip3hvJCURLQ0LLSwi/GV7DNgwyrzRJ tLkLM4daVxmc82l7ClyJY/USfD8v0c4cP4fxz3OCCjKoSsx6oZjCLBlrGu5KUd3fb3BL 6+9cM2gDBjrUuk5PMh8LH8C3rPmblIjuxaz0BhBrUHw+4r1gPb3F7sSNOz/f+pYn/2rh lC0w== X-Forwarded-Encrypted: i=1; AJvYcCXvdBSmsQNtqww4BHugykfbCjwwpw0YTJt7wxHuYWG/aV5wpZqiVeuw+nVL++AGg4AAOJdXqMbXYw==@kvack.org X-Gm-Message-State: AOJu0Ywx5AgHIw8UN3OiGMiW7sw/jJHaNHFi6AmdBj+pA9vnsYI1HifE 3lxNAlUDnF3qBUUlo7qAg0bGQtkpdhA3lKIi2C8ZJShZjhrTfBfRDODoe/SXcSt75xE= X-Gm-Gg: ASbGncu8tQ+6gioo9DDAFKv+pwKSHlQthHD7Buj2pJacO1X82hG2m5vj+ggZVzMgo16 CB6BCU0Yaay/EGFse5aFDEuEuCZ3XjjwX5dj7ThGN5DAD2lgnU5r0NZNnLch41TgJ3WwR2v4kol JJWg1FSxZlUTapZl/qlG1jajyNGPJCMbXfV1efa56Ea6eI2O2uJK8VktH5YVOvTyI6CSaRRkqBf gWvnnAreSxLH96QIrB9zWroGudwyA0lWalXRQQxToiXgUVMLNIeLgHYDKPj0IC4Cey1WFadceUr DHVWdjR47yACDH9ETvSoXfTrK2+gN+uuNQCznFxHHtaSR99rcVMUfBtvAurpXEtRvranlA== X-Google-Smtp-Source: AGHT+IHnooEMEz17n4Y/kHC8fTdwEsKQiWCHXSACT92x6wJgEO1U5hoZYWd06+PlWgby4tspZtHXSA== X-Received: by 2002:a05:6808:81d5:b0:406:6fd3:ff18 with SMTP id 5614622812f47-40b05c740b8mr2902678b6e.34.1750865528333; Wed, 25 Jun 2025 08:32:08 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1fca:a60b:12ab:43a3]) by smtp.gmail.com with UTF8SMTPSA id 5614622812f47-40ac6d11bd8sm2252633b6e.39.2025.06.25.08.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:32:07 -0700 (PDT) Date: Wed, 25 Jun 2025 10:32:04 -0500 From: Dan Carpenter To: Oscar Salvador , David Hildenbrand Cc: Andrew Morton , Harry Yoo , Vlastimil Babka , Jonathan Cameron , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2 next] mm,memory_hotplug: set failure reason in offline_pages() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 51123180010 X-Stat-Signature: 41og3nmno87cf3kiwnhpji8dep4ob9k5 X-Rspam-User: X-HE-Tag: 1750865529-465615 X-HE-Meta: U2FsdGVkX187TvV9347pRHWivK62oY4Eg9RLyxD+zxV5mb4WFw8U4UPvo0aOyeCOEKFGp63zBrmpLLTi5/CONx3GLfUrBRkQo5cOal/LPjeVO5LxAkMJHgsSB3NNdV1cSWN2lGmSJByn+wHj/gGBjwu2pPuIGD/Vgpl9kobXh9AtpMBMrGsGwIlNBAR96s2aEGzx4FY078xNk+nViA3pzjmpRPiwAPhGBmECKbQ143mNs46GlX/xQiCUQkaWSsMLU2YYV9P5HjJpkEO8PV7/t2wjenDyfvWwkaofqU5sYbOd1/1qdbMErojpTCC39aKmwiZb6ZXwkfsYgEywQGPbkr96lm1MhI520XXMPspAtnVCa0CA+it+eRhx43LvVWbAQoedwqZVqUL6jy5xnYBGHVayAM3GmxJZBV01qMPJWqYXMdCc5m4SLFzG+Jq7OJBQQ3T6uREhZaeyjHxT0lO/ss+eVkBuSgE6rpmY0BCuRi2X0LGTRYadYDwVY8UL7B7f1XQCJ40HpurHfR+rcrf6HGNJnfR6QFtMdBPaPpl7ZI8clSZ75sIqq3PXg9T+exPagjmXqVCJ/ey8JWybZSKRsvfZ/C9V/CZg+JV93JqlnS/ahjNwYeplTW+6jt3h+Y7s5mM48MXVwT9Qx8iiMzfKG8G+vfzSWJN4AgVzfdudh/t5Ozwxhidu7oFcMwXh+R6VQL5Q8qt4hGDYcWlTbyyx+3uXm5TUpSqCrUDwUrl/yzCmgcNAey2VkVZl3C8hmi0h11Ooe9NoJ/gUkpNUV+tdx2PcW+e6kwWZmPDyBim0ngpOM6QSpNkTx6ERTbEljR7Tga1hGHrgme28jWMjBdCTfWtG54cmnZGwZG/QCL5IX/2b8kjgPB+uBran3OBWfY3HG3jWE6yl5LA0WgToQBHos2IrWsFk0pm43AwNCt8QPiJQOM1reA1rNQ46N0BQFiwbL+bDlF9XjmNWpFK7eAo e7aN402r LABeB1tRY6Ajd1MUx5hvcgD7hz7TqZN1F/datgz+3DueYZXqxM6fdam1WEUNTjHI/AkEeLPxGDIB9+QW+hfNhgxH62//ZTR7zXmsLiJoxJWyC+UpReUJiiG61zduFvaxFcIeRG2rpfro1eR9sehdPppXThuTLXwLXMLDqipvQzhIdOG+d0qRLfjD7sB2DTSZRZi6TJvsdrPf9Pk0nI8aMP7+UHniLX3N+13srW0bkyq8TzN34J/uIR4zNDLTJNS2mwOsTsiwk3P+UWGp74oSEJfL4Os5ZmiHA6c8ECh6pNOPObK0DjuDMk1RKnc6tVUfZUFGpakW44JbNYtw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The "reason" variable is uninitialized on this error path. It's supposed to explain why the function failed. Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") Signed-off-by: Dan Carpenter --- v2: I misunderstood the reason why the function was failing. Use the correct reason. mm/memory_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4d864b4fb891..e4009a44f883 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, node_arg.nid = node; ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); ret = notifier_to_errno(ret); - if (ret) + if (ret) { + reason = "node notifier failure"; goto failed_removal_isolated; + } } ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg); -- 2.47.2