From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3525AD41C27 for ; Wed, 13 Nov 2024 09:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0FB76B00C6; Wed, 13 Nov 2024 04:57:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABEBF6B00C7; Wed, 13 Nov 2024 04:57:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938036B00C9; Wed, 13 Nov 2024 04:57:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 732176B00C6 for ; Wed, 13 Nov 2024 04:57:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D862808F9 for ; Wed, 13 Nov 2024 09:57:19 +0000 (UTC) X-FDA: 82780617780.12.BB85499 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 206AB40007 for ; Wed, 13 Nov 2024 09:56:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PeK782b; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wEcWvfJa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PeK782b; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wEcWvfJa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731491660; a=rsa-sha256; cv=none; b=av2Tvbs5n/OsvMF03AUdsbMq9ihbAVbRNHNNv4eCf+qRK4SJfW0bTdFMSEBiNCYLAuUkFt sUypof6SX4vXjkOb2xhhp74QfbjRe+whUBOR2eJP14LahDCnCQKURg5PNDOhL3onopXSah bvQRFrbeMoqiu19ytqOzRLwM7dFIves= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PeK782b; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wEcWvfJa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PeK782b; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wEcWvfJa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731491660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1tVxJiCCuXNfk0qGPASJbvm0/hl/h3KyXPElURHw3g=; b=zq9zhf5S4PAUl878hX7sMSTvXYRKDYAObeyleYjvr1zIp7Y0tA9XZR5zkYJjCWwBL1SWhW cKpeMR27ttCKVkmSCiEcQPASAMW63FF07hvBB1o9rTa8U9AinHNAws29eA2uULrMRw6TCb 93yiCIE9thUyfeNM7XbhoVxfP7hpPH8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 278291F37C; Wed, 13 Nov 2024 09:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731491835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1tVxJiCCuXNfk0qGPASJbvm0/hl/h3KyXPElURHw3g=; b=2PeK782bX5eJq5QY6OTM0iGrSyt7dhMB8t+F8VUJsDGPyfkAR27PUr7WhNOhkNo+Nss9BE qMH2CInc0IqlAfV3jrkUE23Cn/6/5BFbxGm24XPS9670vlyNEBl36w31YndCes494VbdsE GYcBvJQTcLzUsMFURZRI7CymFJ0Ao4A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731491835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1tVxJiCCuXNfk0qGPASJbvm0/hl/h3KyXPElURHw3g=; b=wEcWvfJaIGLwLrNP/J3CDUW53xbr46y2qWjR+dT53TMG/uMFjqj+sXDXmrywThlHrQ1OPU bXy4NY9x8mlXEQCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731491835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1tVxJiCCuXNfk0qGPASJbvm0/hl/h3KyXPElURHw3g=; b=2PeK782bX5eJq5QY6OTM0iGrSyt7dhMB8t+F8VUJsDGPyfkAR27PUr7WhNOhkNo+Nss9BE qMH2CInc0IqlAfV3jrkUE23Cn/6/5BFbxGm24XPS9670vlyNEBl36w31YndCes494VbdsE GYcBvJQTcLzUsMFURZRI7CymFJ0Ao4A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731491835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1tVxJiCCuXNfk0qGPASJbvm0/hl/h3KyXPElURHw3g=; b=wEcWvfJaIGLwLrNP/J3CDUW53xbr46y2qWjR+dT53TMG/uMFjqj+sXDXmrywThlHrQ1OPU bXy4NY9x8mlXEQCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E781213A6E; Wed, 13 Nov 2024 09:57:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XYv7N/p3NGe6GQAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 09:57:14 +0000 Message-ID: Date: Wed, 13 Nov 2024 10:57:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 6/8] block/bdev: lift block size restrictions and use common definition To: Luis Chamberlain , willy@infradead.org, hch@lst.de, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-7-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241113094727.1497722-7-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Stat-Signature: k7p3cobotbzdu9qip647mpgxpfis5x3o X-Rspamd-Queue-Id: 206AB40007 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731491792-82031 X-HE-Meta: U2FsdGVkX18M3A1hTF6yFEkWc0Y614r2CMa59LAeXSIeDJZoF67QjIJGDRls0vy7nYNsna3aXy89RhIW1qS75DPlgY0weTEYjRql9pBimp+1XmIAHOKIu9t2aRNO1BbrKTr3xS81MR5Ur0oGA2M9dc4P1OxcLoh2yKSMg19JDoD2yXtfWTQ/8FkM2ctVCe2VhMNJ3tpkVWuw6LxzPeTmZNZKoktaznEYf0oiDggLSHs4CjP9dc941ZasjRXYfXApGggx1NvMHGzuwEixSwIOozTPcHNO6gnBZvFIpcBde/nUDufusDHJumV0AZJOZdblOUYrjsRKvZJd9vlWzNTSIJioG9v6tsCS+ol0fXv8IzyVpRQld5ObWqz8EWDPFBvejI3nnQuy9a5tZ+VbwsL8BIlJSqo/FUSQzuUxCbtsVl+PNRPC4dCBoBC9GYJUoscQ4E99/8WL9/leAF3vkc25/VXd/IFfMNWi15zOQTrTvbCo6wkZonOjgae69QmnsryJJg56aIjpYuCCoki1S+No/QsmpH3gmDjwpkR2+sFhTsyi++pQmkYYCedfK1MIC5TDHauToL4XVzdIIWVi9+kmejOqjaNwzKTvY1hW0EgamIgylrmVuJfu+70dwb8VkoLJnRMYkc8oGkRRoQyF0LpEsEU4nLsF+sajLPZpS0LrgNaYNDa/09kVNBBKeWB2vfSN97atsrxhoKKB/3Z7XqyodIDJgwicYmhTPkd67if7FhYXECXHHsZ71GTo+/fRs+URLDx9DEUpEY3gn3mCRwtvNAMNGOlMPX1GBAae+GDsQw1JE1gqhUBgLOl0lcwm6lUO5MEmwrsX37JrXuSR6ZxvVqEJ3r+Tet5cSAfQLy+s3cdr2qvOVgc/xU/g8/Fc2O86rzFg0G2wxoq/AoEhe8fbmLHPfT0xzxvDvV6ZkSYVd5uzdrrDazfZPGhop6iuety8LZjbMMUUSrsGdbtdi3H gqU03B/j oviWFEUp7OmuzWBfMkQ6Z9VAjg5P+Q2Y5dcy/Btg45z4oWmrMDeAoo1uNj9uG7jOj56w+y855ydATc4UKP9XT002ftFcZo8TFG8/qJxFKtIBZ2KS0KCiyVRzqpn/bESVZ1HtUaHW/LhkZNWS6Afjc5JFxFrjbPZbn06uyhz2NnWFN+LxeEZpiNcmYrC4hshTSARD0nC/rSnZAD1ctIGYTpdJQhyFfLl2ufkQUbFKlb3TQQPc0RvBT38AaTm+Q7u62yCEsnTwQfoTZJPNep2tTTfiSuj5G7JnXCSvTGLT2D2iyfq6TvXWjQofpHciy7xOESb2bqljYFW0jJSLACKzp804nwW0lpb/Rac/12jWzRdDnwE447u2bbXI534qE+7P1VskgCR0B6mggXICJErepE/pBt1zs+WeEUnkbr69wySBMWpWcvw6fUooc+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 10:47, Luis Chamberlain wrote: > We now can support blocksizes larger than PAGE_SIZE, so lift > the restriction up to the max supported page cache order and > just bake this into a common helper used by the block layer. > > We bound ourselves to 64k, because beyond that we need more testing. > > Signed-off-by: Luis Chamberlain > --- > block/bdev.c | 5 ++--- > include/linux/blkdev.h | 6 +++++- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/block/bdev.c b/block/bdev.c > index 167d82b46781..3a5fd65f6c8e 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -157,8 +157,7 @@ int set_blocksize(struct file *file, int size) > struct inode *inode = file->f_mapping->host; > struct block_device *bdev = I_BDEV(inode); > > - /* Size must be a power of two, and between 512 and PAGE_SIZE */ > - if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size)) > + if (blk_validate_block_size(size)) > return -EINVAL; > > /* Size cannot be smaller than the size supported by the device */ > @@ -185,7 +184,7 @@ int sb_set_blocksize(struct super_block *sb, int size) > if (set_blocksize(sb->s_bdev_file, size)) > return 0; > /* If we get here, we know size is power of two > - * and it's value is between 512 and PAGE_SIZE */ > + * and it's value is larger than 512 */ > sb->s_blocksize = size; > sb->s_blocksize_bits = blksize_bits(size); > return sb->s_blocksize; > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 50c3b959da28..cc9fca1fceaa 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > struct module; > struct request_queue; > @@ -268,10 +269,13 @@ static inline dev_t disk_devt(struct gendisk *disk) > return MKDEV(disk->major, disk->first_minor); > } > > +/* We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) */ > +#define BLK_MAX_BLOCK_SIZE (SZ_64K) > + Please make the comment a bit more descriptive, indicating that beyond 64k more testing is required, hence it's not enabled for now. We _could_ add a config option to make this conditional... > /* blk_validate_limits() validates bsize, so drivers don't usually need to */ > static inline int blk_validate_block_size(unsigned long bsize) > { > - if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) > + if (bsize < 512 || bsize > BLK_MAX_BLOCK_SIZE || !is_power_of_2(bsize)) > return -EINVAL; > > return 0; Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich