From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21A7C25B75 for ; Thu, 6 Jun 2024 06:46:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254876B00A8; Thu, 6 Jun 2024 02:46:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B9196B00A9; Thu, 6 Jun 2024 02:46:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056B36B00AB; Thu, 6 Jun 2024 02:46:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DBE2C6B00A8 for ; Thu, 6 Jun 2024 02:46:09 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 790151C1E33 for ; Thu, 6 Jun 2024 06:46:09 +0000 (UTC) X-FDA: 82199529258.26.222EF1A Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 28561A000D for ; Thu, 6 Jun 2024 06:46:06 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717656367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YhlQ5FigmchhjR+h5gewktQKTYEBGdA7gNJQk8IwBMA=; b=TSH4LswuPzWVcn8oIhV9svC0SRQR/WJRoSsOMJsFxJZh1zTXFiFmnfw29EZJia0NuZk/9l Gty063rH71w9hWP0SONPIp1QMuhknBwSRkwXJMF4fB6ZyjtJyaiEx+EE3k1y7wO5VtWfzn ASJL3DkEcyjCzD9/P655AVzaW9kNpIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717656367; a=rsa-sha256; cv=none; b=DbukOxNbqEIp8sXf3rrrw8TFQM09pfylLSdqIYSY5PljN9CTtQ70rNqiBskODRQlqO6uAD UQmtfklYcTlFZrdnVy3fESlfMRGPzzqSeXg+zVtVghOTw8Tjs648qcldIwZhvGRm9Ufm42 RLSCLQU2ZyZcaRxr8VGL6PVoCskjWtw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VvvsK22rPzPkR3; Thu, 6 Jun 2024 14:42:45 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 96EE518007E; Thu, 6 Jun 2024 14:46:03 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 6 Jun 2024 14:46:03 +0800 Message-ID: Date: Thu, 6 Jun 2024 14:46:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page() Content-Language: en-US To: Miaohe Lin , , , CC: , , , References: <20240606063247.712575-1-linmiaohe@huawei.com> <20240606063247.712575-2-linmiaohe@huawei.com> From: Kefeng Wang In-Reply-To: <20240606063247.712575-2-linmiaohe@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Stat-Signature: 5hr5i467wtdykch3goqzg1b5f719ukco X-Rspamd-Queue-Id: 28561A000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717656366-366785 X-HE-Meta: U2FsdGVkX1+UaD/k+Um51xv60knyUlQ9kEXvSRj5YYIRr2gxbwVaPIiAw+O8hu3ZFRxkszQPnglCQiyVudE+kObbqgtmxeP8P28F1RHIpe3r69eqNE9lLowy5ZLaX06saDPGo5imgobpd3TWPsrGlKaSsBV29tjbBSFIBZqTOZJxjJgkexxqXGUWf3gOGeg8YTmap4TZ/Wvzaj269qLh57DBa9OzhL4E/kYqEw65Wh0uO2PE3InmKP5R/pJkoUusH67I6lrYoiqDeaSMx22PLnFaHwtdM2P/6zNCuojDkeabP0C74s/tPIWOX2hY/EvxGkHKSf9gOA+/3ORShW+X1/tgRdu5YsuTqDp1yGWVOA2vhKavQ6mZRnWeKdCMa4xa5XqSIL6f81BlLDnvuBXxIef6YX+ZaRtvYRZxAzySCOT0PDcNENwS6kiSzUevcHoJXPWvOuC+bV9Q/HLrZ1xt+IDjvSGshzPEi6/hxOu/JLUW46GkUmqfL4ZjdrZBURvjtdSpxLk6egnBmHZLO5s501Li4q8YyCfLeOgPlHUsN9XSqIfsLmo86gXJRaio2nBeY6ZYspdW0zyr0tSMDw42x31v8rBeRQsiAkKjtIikzJKGkISvkWvct+AyfO3RoXyqjH4hjr83JC5ej6hREQNP+DiAYhCzhKPByTpUgWeRMsHQakV5R0PKE5BxMxOKm6cAykPE0kioYVrqHfZ4bu4A6pOJmGbtizRRguXBATHFZZiq/WYfeTGoDGgW9ITF3vcZ8tmyp9joEp3FVuK9u9rzbry5OeX4cR34VU3ozGreZlSqilCsv3t7yKfr6U63W2zRlzoY7t1Eyc+dvBwuI1FFCNbr4aJ4PB0pYpChh+20bNg09SLKvPaZheevQOiYE89BuEsNi/gJAi8K+GKILbAzwtubsGt5dAnBdGfMyR6ERCmHqEDs5ZRao6p3x9jxWPy6LNDloIEfLd9EFm/gOMd sjdjfoz5 UJ9UECscy3UP2DOjC3M495DmdVQ39odQrOHgJAglYM+9KgweJ2jBDAq8EqrHOtjO/KPkvwaxiGT1wJzczNQgYr+Q7R3Ja1jzBHnMfshlKq7jZS5XhFOkbrLQlopONZDdECsBlD7pJZadP1iFGm0110h8hgIYwyeD2zRo+n5pZQ+H1HGdGQLGki2e5eSGzRnCu88EUyRfMabTP3ZqiWCPoAgmhB1N4SdHM5ToMukhl92MJoyVdsQeD1yfrlsKJ5yWojGFBMf+/MFF3kXo0sGCZ5HyphzRYXS/WEyOoSB5PwUkbhoe8l4EDBC0diGI/EVjFOI1Pr1hbSjiW5Yp8z9jWUPkgOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/6 14:32, Miaohe Lin wrote: > Remove unneeded page != NULL check. pfn_to_page() won't return NULL. > No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/memory-failure.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f679b579d45d..2e6038c73119 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2120,14 +2120,10 @@ static inline unsigned long folio_free_raw_hwp(struct folio *folio, bool flag) > /* Drop the extra refcount in case we come from madvise() */ > static void put_ref_page(unsigned long pfn, int flags) Since all calllers have a valid pageļ¼Œbetter to pass the page instead of pfn? > { > - struct page *page; > - > if (!(flags & MF_COUNT_INCREASED)) > return; > > - page = pfn_to_page(pfn); > - if (page) > - put_page(page); > + put_page(pfn_to_page(pfn)); > } > > static int memory_failure_dev_pagemap(unsigned long pfn, int flags,