From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F26C02198 for ; Thu, 6 Feb 2025 03:34:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BBE16B0082; Wed, 5 Feb 2025 22:34:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66BED6B0083; Wed, 5 Feb 2025 22:34:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50C276B0085; Wed, 5 Feb 2025 22:34:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 32E2E6B0082 for ; Wed, 5 Feb 2025 22:34:13 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E48FB140DF4 for ; Thu, 6 Feb 2025 03:34:12 +0000 (UTC) X-FDA: 83088101544.22.28EBCBE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 74D1F1C000C for ; Thu, 6 Feb 2025 03:34:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HXpXFF+7; spf=pass (imf21.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738812850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgnCO7mXfPIiEEPBciloYom0SGtjBExbfCvcW+zqXLg=; b=UGGjY0XnplN8JqZVn1BCm8GNq3+kaaNJdor1KpZsfcNutflQQPvasVsL0pto4TrsrpIY9U kupZVgM1LjUA54c63KHbrkG7fVhi3BAxmVekeULCbnX8rsVUHJixdTiAZXajb4tFX+ZY+R ejgJ9eDl5kkCVSV+9312M0s7KKHLJBM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HXpXFF+7; spf=pass (imf21.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738812850; a=rsa-sha256; cv=none; b=Op/lxSIgBXx3ptVDG7kpGslAng9cbIHF1+9K2e4tCGy1ir0DdDIaNr12DZKug9ZGRYwQ3m GW1MgCWpG49hY3cgF/lcV16xsfk4ePTVAg57O03qzTeBXT3l0jKg056G0mJKfa1NPoYQ// 7gCj2cxbh7/Zq3W7wjT+VWIfEyqlRmg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738812849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rgnCO7mXfPIiEEPBciloYom0SGtjBExbfCvcW+zqXLg=; b=HXpXFF+7d8tfFG+blJQWxcoca/BtPcxyEFeixLyp6MCdPsGw1xml9mOzMifse2mxYXnMxk QqRmqIgoUIfSTMsaR05e9LgZ68aYOfCOjEO5nPv7ehmP+HE7qUc0tkugFSCWpqrkfUW6b/ ErH83kLgPNfILeJ1faZ8/7qWR72sSrs= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-hAdUJKEvPz-g2EwbQrkssA-1; Wed, 05 Feb 2025 22:34:08 -0500 X-MC-Unique: hAdUJKEvPz-g2EwbQrkssA-1 X-Mimecast-MFC-AGG-ID: hAdUJKEvPz-g2EwbQrkssA Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7b6f274f1f9so65808585a.3 for ; Wed, 05 Feb 2025 19:34:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738812848; x=1739417648; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rgnCO7mXfPIiEEPBciloYom0SGtjBExbfCvcW+zqXLg=; b=DwblQX1Gz1s28zkCFbieDsMA8f8+KwnlrfBOTHNO1tKssgQtktSZvHtmSB4IysiuCB XJv9rNnNky+z/9jMmnr5WFsalFv5uVwGfYQlqF9bPLMOaHYtWqk/RZuTYa0JvxpJpSLi ht6dNzylX6KjWDooy6ZQhRtQH2SogWQkqggNTUU1DyDNLCiz8YIhmmfsv1yh/8kCi3Ly ThBF8/mc/6pxqZQeEbq007tYRLQRoU48UKx45ZXmOaIJIFFmkeHYNnAJDNjsu0J+d6VS MNGZwYpYOfqVvVu93Z0MCQrAZB1FA06yYKrW0ubxwGcTzfuRroQRVfnvR5fG3b+AHapO AonA== X-Forwarded-Encrypted: i=1; AJvYcCULCR2qr9+3mSHleRfTRf9Darcnt5EfHWZhI/x7Z+BxfHnFQn3tpnuxW0NLPu3dgpirmoaVWyHcYA==@kvack.org X-Gm-Message-State: AOJu0YxlU7i+zODedSvGtc/2iWPuFvYn1QLq21vjPPj0wHN1vxDkC3Js KLp1EnWyEx43E5obk52tnbBC9PA7XcAz3rivvjq5bYDmDKi0++G90OJlXDaExqm4CNhNdpUAvx0 vmvq1qwoWHldbw3Y6x23UaW2KHUn055Q4GtvfD8QnbxLGT6WX X-Gm-Gg: ASbGncsHWUVEM1Vo1TodMyap2HAp0NxRbeYYJiylj2yTy/+MkeuXLA5kVDA3oEPCJPl aZbGv7EBye0499UUX54RRoHnSlzE7eyt/7AuU9mEFIyZ7GDPzFH0f208CSwxSMfWV9bPl1hLLsk 0ck9AkuUBZD6l6Fsm/uVM/08LfEjuoDiuisv9/eBEH5oyAUCt9d5yB01uX2/CyypGgiQSmF7xLv H0QN4s0IvjBIgxsoUmCK0WQQMKsaZwMwquxyc/rzK9IK+CDAcO/A3HyEcxeIypdvloL34jx5qRn y6+UG7getuYG0hNI1DKFQry/Xwyv9JzYDXdElGR4fv0aQr7A X-Received: by 2002:a05:620a:2901:b0:7b7:106a:1991 with SMTP id af79cd13be357-7c039f9810fmr663010385a.16.1738812848121; Wed, 05 Feb 2025 19:34:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6QZNT6c0eAJL+wJ+ah9660s9AYmQDkqqf8C6WgMi7hth+4A8aDxk2c+b1xsvcyPFePmHuEA== X-Received: by 2002:a05:620a:2901:b0:7b7:106a:1991 with SMTP id af79cd13be357-7c039f9810fmr663007885a.16.1738812847841; Wed, 05 Feb 2025 19:34:07 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:627d:9ff:fe85:9ade? ([2601:188:c100:5710:627d:9ff:fe85:9ade]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c041dfb128sm20577385a.30.2025.02.05.19.34.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2025 19:34:07 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Wed, 5 Feb 2025 22:34:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: A path forward to cleaning up dying cgroups? To: Muchun Song , Shakeel Butt Cc: Johannes Weiner , Hamza Mahfooz , linux-mm@kvack.org, Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Michal Hocko , Allen Pais , Yosry Ahmed References: <20250205180842.GC1183495@cmpxchg.org> <7nqk5crpp7wi65745uiqgpvlomy3cyg3oaimaoz4fg2h4mf7jp@zclymjsovknp> <91D2E468-B89A-4DD7-B1B0-B892FA4482E3@linux.dev> In-Reply-To: <91D2E468-B89A-4DD7-B1B0-B892FA4482E3@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mW15Tv8l8UTfGFC9YfCwnnA5A_QLHs_36aiDtKrRNJc_1738812848 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 74D1F1C000C X-Stat-Signature: bptok5s6jpyntno3anzy7zbipyre81i9 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738812850-964469 X-HE-Meta: U2FsdGVkX1+EOiDNk4w+jNwNGo/22RGq9XHZ6cLBmGAaC3qewMOhhqGdR+MdRMXxqzREOiRn9admZgbk4tS7LSaU9qh1NSnm714sqaJPR2pvHeCHJX8SN0l6ZH95IjtAshLFKqr+doU7b6VhYDudNYyVF0aTWHfcqArNiGztUJyejqtC91Ne/NcS5AFnBKTt5QH3OddpH4JInEaIfzgCTGFhMLztkSa1lyfumFZxd+TMMXOgqpe10tLxuspGfEOnhTJJ15/SG5EI0tIo1Tnu+1Dd9eArOssxbkou8J9nI6+I7YyvXSvImkJF6Thn90UN6B4cvMHfvSN6Tkh2bmNG+v/gFhNhgZ6JGGJ4i2fcVo9NL1r06xzmpgj4aU69XOkX3Mvr7qsWF1zx6tklAL7MvbTjBcwOALnnXqB6m0br7HhkNSDuXUuLNfPJcLZcHMZnxm5MiKKBjI+xt61/i7zxPLOjJ1OVy2elACknbXry5p5wE9rPQDtc8YOnhf4NUjhnxlvYURZ/6TWKp2fUqd87DaouAlX+K+PwF0dhdaSC8OjmlJkDHE/prh1YXi5lmUDPamdQneNRk/T8viTGTKaCuUeackBEhm/s950p8XQ2t8CQZVDeBQ3DkSovWUxUtMONzAE8I886wmyL2p4EolUea+zdRPXkCsir1ec9ANDUcczZgqMDbk/GuajXoNpDgfDxEtT/yDbvhGVgk6b2SjswxEsKU1KcbvrjQBVWEheTwJCTumfJNjvXEnGmCLVKFtQJnVCmSdKU9tkocrVrhr9xX96opf8uxhwW4BtVdzD0kBjoD9dst6TmVqJMuBI/eZupwFJUMqFABDdeYDTY+BSWDf5JrjyL77hxk/lGGP9mdm8LTj0HemXv71Nu/W7VJumqUa/baeJ4LEWIxLySs0tXJ9ReW53+0+z8a2WAcRZiXhlztboNtZu3kdJ9Q8xXOPB1dh+81phHzt4q9CZb6fh kBJkE1Wb JIAzTo/NE7hfT2/Ih6jhomAjZYCO0Ec3hoeHJ5KNLZCNi9BO0SD643r1e1JrgVvlXN763+Hfp8GNSPxTwIzbzlgKKcj+sxdZty2H/VpEP/MAsJgpNGNzwqjA+FUydpbM6/0h14OR32xGunmVV2NBLLIyXoj7vBejQ+PFJ5h3WBHqveyI/h2c6UjKb1MdrTmAJZ52rxpF6AV5GLZKcAZ5tVz9OS6O47emkgISe1gCQiwqyVGcDPJrVuivNyeNoQZMtj6W5u4QVyYq8A0TyFIekumbWTls2mfkDr5LNGT5QQCwxxXhSXJDBOGwLyEkkjazcFsFg/RGZJQ2Wqo2amoT+YvYGVpkbmYI2YK9Wueg9qoK05RvXlcdiUSYVdA0Z4fwYRVljrI//W8c2eA3WxA5Ehs3z2XarPCvv4NoV5V2ugIgyul8qABs2JdLFA+STmMGrl4HKZQ158aQmjCrGDjHs9cjGhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/5/25 10:30 PM, Muchun Song wrote: > >> On Feb 6, 2025, at 02:46, Shakeel Butt wrote: >> >> On Wed, Feb 05, 2025 at 01:08:42PM -0500, Johannes Weiner wrote: >>> On Wed, Feb 05, 2025 at 12:50:19PM -0500, Hamza Mahfooz wrote: >>>> Cc: Shakeel Butt >>>> >>>> On 2/5/25 12:48, Hamza Mahfooz wrote: >>>>> I was just curious as to what the status of the issue described in [1] >>>>> is. It appears that the last time someone took a stab at it was in [2]. >>> If memory serves, the sticking point was whether pages should indeed >>> be reparented on cgroup death, or whether they could be moved >>> arbitrarily to other cgroups that are still using them. >>> >>> It's a bit unfortunate, because the reparenting patches were tested >>> and reviewed, and the arbitrary recharging was just an idea that >>> ttbomk nobody seriously followed up on afterwards. >>> >>> We also recently removed the charge moving code from cgroup1, along >>> with the subtle page access/locking/accounting rules it imposed on the >>> rest of the MM. I'm doubtful there is much appetite in either camp for >>> bringing this back. >>> >>> So I would still love to see Muchun's patches merged. They fix a >>> seemingly universally experienced operational issue in memcg, and we >>> shouldn't hold it up unless somebody actually posts alternative code. >>> >>> Thoughts? >> I think the recharging (or whatever the alternative) can be a followup >> to this. I agree this is a good change. > I agree with you. We've been encountering dying memory issues for years > on our servers. As Roman said, I need to refresh my patches. So I need > some time for refreshing. Glad to hear that. I have been waiting for a resolution of the dying memory cgroup problems for years :-) Cheers, Longman