From: Waiman Long <longman@redhat.com>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v2] sched/core: Don't use dying mm as active_mm of kthreads
Date: Mon, 29 Jul 2019 17:06:35 -0400 [thread overview]
Message-ID: <be28b3d2-3f94-806b-874d-db2248a2c3a9@redhat.com> (raw)
In-Reply-To: <20190729081800.qbamrvsf4rjna656@e107158-lin.cambridge.arm.com>
On 7/29/19 4:18 AM, Qais Yousef wrote:
> On 07/27/19 13:10, Waiman Long wrote:
>> It was found that a dying mm_struct where the owning task has exited
>> can stay on as active_mm of kernel threads as long as no other user
>> tasks run on those CPUs that use it as active_mm. This prolongs the
>> life time of dying mm holding up memory and other resources like swap
>> space that cannot be freed.
>>
>> Fix that by forcing the kernel threads to use init_mm as the active_mm
>> if the previous active_mm is dying.
>>
>> The determination of a dying mm is based on the absence of an owning
>> task. The selection of the owning task only happens with the CONFIG_MEMCG
>> option. Without that, there is no simple way to determine the life span
>> of a given mm. So it falls back to the old behavior.
> I don't really know a lot about this code, but does the owner field has to
> depend on CONFIG_MEMCG? ie: can't the owner be always set?
>
Yes, the owner field is only used and defined when CONFIG_MEMCG is on.
Cheers,
Longman
next prev parent reply other threads:[~2019-07-29 21:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 17:10 Waiman Long
2019-07-29 8:18 ` Qais Yousef
2019-07-29 21:06 ` Waiman Long [this message]
2019-07-29 21:33 ` Qais Yousef
2019-07-29 8:52 ` Peter Zijlstra
2019-07-29 14:24 ` [PATCH] sched: Clean up active_mm reference counting Peter Zijlstra
2019-07-29 15:01 ` Mathieu Desnoyers
2019-07-29 15:16 ` Waiman Long
2019-07-29 15:22 ` Peter Zijlstra
2019-07-29 15:29 ` Rik van Riel
2019-07-29 14:27 ` [PATCH v2] sched/core: Don't use dying mm as active_mm of kthreads Peter Zijlstra
2019-07-29 15:22 ` Waiman Long
2019-07-29 15:38 ` Peter Zijlstra
2019-07-29 14:51 ` Waiman Long
2019-07-29 15:03 ` Peter Zijlstra
2019-07-29 15:28 ` Rik van Riel
2019-07-29 15:44 ` Peter Zijlstra
2019-07-29 16:10 ` Rik van Riel
2019-07-29 16:26 ` Peter Zijlstra
2019-07-29 15:37 ` Waiman Long
2019-07-29 16:12 ` Rik van Riel
2019-07-29 16:22 ` Andy Lutomirski
2019-07-29 9:12 ` Michal Hocko
2019-07-29 15:27 ` Waiman Long
2019-07-29 18:58 ` Michal Hocko
2019-07-29 20:41 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be28b3d2-3f94-806b-874d-db2248a2c3a9@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox