From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07AECDB483 for ; Mon, 16 Oct 2023 15:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384D08D00AE; Mon, 16 Oct 2023 11:54:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3351C8D0001; Mon, 16 Oct 2023 11:54:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FDCF8D00AE; Mon, 16 Oct 2023 11:54:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1173A8D0001 for ; Mon, 16 Oct 2023 11:54:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EC9C2A04F6 for ; Mon, 16 Oct 2023 15:54:50 +0000 (UTC) X-FDA: 81351772740.02.1416391 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 150B840021 for ; Mon, 16 Oct 2023 15:54:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=o77yGTKE; spf=pass (imf12.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697471689; a=rsa-sha256; cv=none; b=yVpdtPTE+iFwgg0USDHVotXZ948jd4fNKqCYTODlB7dhA2hZHLyUahTyoj7Pi2XmkaVD8q Q1u3XNrwPjlzqod8kFagh1qIalh1YT31OlZYyHKPkzkrg+cfvzOGqIiHmEQ44TzU6kp44M Kes//iXZnY2riZINA8KJCgOtGQx4Xbg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=o77yGTKE; spf=pass (imf12.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697471689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7OC5n/qlhFcABSz69e64cW22yEto0Dieu0lwxhP50A=; b=iY2ZnTf/Vo70boMMRZcx5H1+atSKCIW22ALywluamlwX1/E9fRaVZye78ijmEt7uldd5H4 zTMYcF3nUoj0XDVIridvwc5ADSG6OdylC96q1BGppP5mxw2wNolpxw4E9gaPJNghKR047m zNb8kbU/kyg/hZXbl8xWoO6WqR/ftJM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1847F61010; Mon, 16 Oct 2023 15:54:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 031F5C433C9; Mon, 16 Oct 2023 15:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697471687; bh=XF2Ub1+HsWjMHCZvPLicE8SrXCYQkNv2/+mVm86z2a4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=o77yGTKEHFiOMbIKRpvPlQ2bZkbCx09x3z8mNkKZh1NsS3xrrdOLFFR2o7jfizo70 freHLcVbHxI57o4kN/a2L81UqoIFV0fMa9rbljNXC12+F4jOrFfwCA/0EMeVqPkzA0 E/KVuHc0ZuW/ySQ+93u31MlUeeldUYbIGOAwHf5+2ZraDUkmxXa/6JbBJgzkF+KHkV lDGLHROOwMBeB85NoOmXpFEbSMnqwvOxXfsQUFiXwWwfNTrmpo982jeSl/Twi9wO8G zEvV9KZ/l0e0LKmR7egS0uLwwoU91gvu6k+zTMJmpt4DWa7tPrONXdQLx/GPOsQk8q d0jO2lIzcVirg== Message-ID: Subject: Re: [RFC PATCH 08/53] netfs: Add rsize to netfs_io_request From: Jeff Layton To: David Howells , Steve French Cc: Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Date: Mon, 16 Oct 2023 11:54:44 -0400 In-Reply-To: <20231013160423.2218093-9-dhowells@redhat.com> References: <20231013160423.2218093-1-dhowells@redhat.com> <20231013160423.2218093-9-dhowells@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 150B840021 X-Stat-Signature: oq43mq14wxj4ygprsxxeigudfbrd5dba X-Rspam-User: X-HE-Tag: 1697471688-950703 X-HE-Meta: U2FsdGVkX19lm5UWX1Wthh6AFE0a2M57i0xDHWyUntE40l6gFCq7NdcjKr2yKo1WYy+o7sLMSI4pirtl0hU06NXO5jZmWeyemtEGD3MJM3tJ3qqfVZcmYzz1zAc4JSbKYvwxs05jHu3GhR8WnaFB9V/bAdxvBzrp6SKdFcOn2di7LE3qjfxlEdiwnIWTnKPOGA9GYUqNsVbND8a8OYsDoiknqQ4Zvv9wtOECgCLHLmX9qPgylDla6fogW97n8rT8FZOxoXShyhIIBiRC2C2s1rQKNjFkJ9EKD5HB6LcHoeZW5Hv6wKs33Vqao9scCmD2Lv4svJfSr3hdrWwTls/hcPBRalU/gqb7L3shQ2oXFVu/1WmcjSb+BsgRTdiplaVycOdd3DdEJBgnnsqYNc/qRC4kTIYaf3pANTUPRg9Rc8+JMoS3sVgZDexZ0FJC/V2cjZC0VNL4qDFsZ8IPrIFhX6PeRlVjSeypMD3bwiMSIix0a8wXjDWnv2bm6bRAPTGoONQjZg0UkZxkr8A4ds/EejbHIZbNh9pWuvYoCAuZ/jRCZhPqOkec7BwgkAJx2w6jdoyMHQ1XewiKrF6iZRQEYwMcdpzt4lCe5zOcUB7X4vq7o0J8073TL1ZIFkWht3WEOzkpQL1xA3AXO8SnnVdhxFj8xUc7GKdjDqld1+xtiR8eY+6nJPpxGvhfG/2hd0kQjbIXpY45C5hMgnrQvGwXbe2f8ozyCaFg9PWq3Q7YEXZRUMagKy9XPuOnavisESqr46ysDaouXn2v/r3Y7cG5HCBk2qO3BxZiEnVvp200+b9aL87kE5CMhpO19GgEWExSpRBR/YLavLZ5fiwTkwJtYKQdQE1Y+C7gAMF5dhAL4YVsiMg8Tijmxy8tuJwf815Yl/hZTQ5NAykfrZmkWUC5nu4GpRDV4iOuOkYNlOZ8zbHojqbFftE/v4BaRwPISqn59piiddpxHscr4vFf4On 1EflBLo1 Hoc9RBeiXljBtvHRpsz4FUQfubQZyKYVcthwCi9552FOWFmykB8ypFSKcJLFBLxdXHABHZ27nzMpWBpthG3Ee8lIvID+8mrQZfd50NQVPyZHbw/E+X3Jj9A+P5zv80CfehPtUc7ZOAqL41YdoRe0ELqKLS6KJBAuM9vaYZNiiU7mrZRuXawFYfO5vpYiPAA/LDohVu7aQFTIj2LdI0a2ui/C+Nrr0qky5d8Uz0pGlJcFRZ570Grphp/AJWPnLyvP/0y1M9zF/KDRE4vRbHw9g4dX+tKHcNDLpJV96IlfjJmgkB11SYra9U9XJ1QHIqlkB2ZeYNkvGo7gF6SLPf2JIauTqZRNZ1z9PA8qCoqSecDW0cz6aTulPJaOzrsYohE4Dk1+4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-10-13 at 17:03 +0100, David Howells wrote: > Add an rsize parameter to netfs_io_request to be filled in by the network > filesystem when the request is initialised. This indicates the maximum > size of a read request that the netfs will honour in that region. >=20 > Signed-off-by: David Howells > cc: Jeff Layton > cc: linux-cachefs@redhat.com > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/afs/file.c | 1 + > fs/ceph/addr.c | 2 ++ > include/linux/netfs.h | 1 + > 3 files changed, 4 insertions(+) >=20 > diff --git a/fs/afs/file.c b/fs/afs/file.c > index 3fea5cd8ef13..3d2e1913ea27 100644 > --- a/fs/afs/file.c > +++ b/fs/afs/file.c > @@ -360,6 +360,7 @@ static int afs_symlink_read_folio(struct file *file, = struct folio *folio) > static int afs_init_request(struct netfs_io_request *rreq, struct file *= file) > { > rreq->netfs_priv =3D key_get(afs_file_key(file)); > + rreq->rsize =3D 4 * 1024 * 1024; > return 0; > } > =20 > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index ced19ff08988..92a5ddcd9a76 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -419,6 +419,8 @@ static int ceph_init_request(struct netfs_io_request = *rreq, struct file *file) > struct ceph_netfs_request_data *priv; > int ret =3D 0; > =20 > + rreq->rsize =3D 1024 * 1024; > + Holy magic numbers, batman! I think this deserves a comment that explains how you came up with these values. Also, do 9p and cifs not need this for some reason? > if (rreq->origin !=3D NETFS_READAHEAD) > return 0; > =20 > diff --git a/include/linux/netfs.h b/include/linux/netfs.h > index daa431c4148d..02e888c170da 100644 > --- a/include/linux/netfs.h > +++ b/include/linux/netfs.h > @@ -188,6 +188,7 @@ struct netfs_io_request { > struct list_head subrequests; /* Contributory I/O operations */ > void *netfs_priv; /* Private data for the netfs */ > unsigned int debug_id; > + unsigned int rsize; /* Maximum read size (0 for none) */ > atomic_t nr_outstanding; /* Number of ops in progress */ > atomic_t nr_copy_ops; /* Number of copy-to-cache ops in progress */ > size_t submitted; /* Amount submitted for I/O so far */ >=20 --=20 Jeff Layton