From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD6CC4332F for ; Tue, 12 Dec 2023 12:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAF776B02CA; Tue, 12 Dec 2023 07:43:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5F536B02CB; Tue, 12 Dec 2023 07:43:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD96F6B02CC; Tue, 12 Dec 2023 07:43:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B93F56B02CA for ; Tue, 12 Dec 2023 07:43:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9A3C040989 for ; Tue, 12 Dec 2023 12:43:52 +0000 (UTC) X-FDA: 81558133104.06.7AF95F3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 680E21C001C for ; Tue, 12 Dec 2023 12:43:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CtVdL4G1; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702385030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EXNwRSJMQEUJkumN0PV7cDxdu+e8I4/DFsyenY1CLJA=; b=YuqDanVzCczGQnxL6UabhOor430v94Jjxvg1KrmE7pBIQWW6bWO9cWG+j9dvSnrYu/GVLE PaxNnfU8BEtBhdtzY5HVTkgRQ/wqTSGVnForDkuFlZQMYpq68w1UEYc33NBDjTbBI2Kvj8 TZzs1uBc13TeDoHC5L3OijkkDHT3Cwo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CtVdL4G1; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702385030; a=rsa-sha256; cv=none; b=r0Ciz4xKfjEJiI4KoSOdU3HEdbpMWwyt+BggWxNG3DT2dOer8vPRvVXNKkgZwi/REzM1j0 6fDcgSJwccrHucvtxzcIAxaobg46rtmKdFLQwj1SHAfMZb1eed9JxuKn1MKMtfe4lQVQKo jlGqmzh/mBMJ7qN4UDN/Aje8oe82vFc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702385029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EXNwRSJMQEUJkumN0PV7cDxdu+e8I4/DFsyenY1CLJA=; b=CtVdL4G1Zsk/Qki/UbICRNjstsuda9ItN+kv6Pc5TJGswQg89cR8FCotJVJ/U0En4XGqBL 01Ai4EmyhzcZNSRGva3IZCVkUL1StBzuq+FKx+PV2VsFpWJ3b5w8D3URDuvjTAq72v7jFX ucmf2WahPOspNFcEWlKmC1U+fYPPoPQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-YcCEoBauPf2Uc_KE4IyFOg-1; Tue, 12 Dec 2023 07:43:48 -0500 X-MC-Unique: YcCEoBauPf2Uc_KE4IyFOg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3334549e36cso4317099f8f.0 for ; Tue, 12 Dec 2023 04:43:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702385027; x=1702989827; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXNwRSJMQEUJkumN0PV7cDxdu+e8I4/DFsyenY1CLJA=; b=bxjTpbtfeKNh2k8qijCBx0xNsW4miBioK3BQVkMBZPoDYUSqFgnDcPjhJrvvzy4n9w cUgLbPZzIpCQT3jEXLONJ3uhd+9ws99W90xXfM0FEQCRaiZBA8kiZxElYJp9I2Ua11Bu Bh2pt/RiXtPdaFd+Q69G2Wya/9BXvZT1xePEZJCA6qAK8XaUyag3gh6xDEmevFLwd4By E87BtgavmNCwer0KIhcIQHRj5cbZDkkMiSQ3OVW3wUA0rzDKtyaTPhfZ+AbgVTZcZ9Yi II5OqkwdOZ3f+6Ljm6C0tg3SMyw/sFQRZL5LpFSLuB+rePCvBAy5de401tGgTSsOLxpY ON5g== X-Gm-Message-State: AOJu0Yx5NQl6cCVekq8O+Oi+pGVoGXQraCSgJ9Pq2QxtpUpFVAMZzDjn 1Q2BBojfQkfsU3gYw0SvigggV9aGF6KUQALGW55RAdcU9bt5XbWieJnWABY1dymzaYe4Axdz4EG hKod2OGt32a0= X-Received: by 2002:adf:ec51:0:b0:333:2fd2:68eb with SMTP id w17-20020adfec51000000b003332fd268ebmr2936207wrn.126.1702385027164; Tue, 12 Dec 2023 04:43:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeWl3/7VHqVJ2cphaR77b1fkJFHCrWYJybKOtrIQM90WVgm4pR8ryV7tIxB1DXhUmmU+GaDg== X-Received: by 2002:adf:ec51:0:b0:333:2fd2:68eb with SMTP id w17-20020adfec51000000b003332fd268ebmr2936200wrn.126.1702385026743; Tue, 12 Dec 2023 04:43:46 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id q9-20020a05600000c900b0033330846e76sm10782630wrx.86.2023.12.12.04.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 04:43:46 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 13:43:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] mm: Convert ksm_might_need_to_copy() to work on folios To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 680E21C001C X-Rspam-User: X-Stat-Signature: 64msfsyywd9r5e4aqr3anpwn6k3ka5a7 X-Rspamd-Server: rspam01 X-HE-Tag: 1702385030-404125 X-HE-Meta: U2FsdGVkX195A69/kPBFXGmQ53yoBDCbgtqURrFu+neSaEcUA8r2Gwi3P6/h+K4gsgxfvKZJ3Asxxt+3FQw5dUmXXdRk3mKs1hyTWA36dlVfzQoiyZmbX1CAdkLeWAC2XXjKsDDT5utT81SsPGNERfDXAXbAusK/dUJvw3UW2fKtGTInOERrWKzzYbV5pzrzEiDZI4wZsvwYD7dtu/7QnsSW0zP6e/IoEwlIXLkoZkIcoB5pOfrVkojGP9B120+7SQuak/4y94KCaC/noXghP3ZPF31nfubafjaVn25gGMg7mFfkmoaPipt79oGE9Ss49+Ex71lZ0RWqd0nHYu+UZINqT4aAqTphiW6FeDSh6eFKcuoM0N+8s+Ia5+Kuolo3kuWE6r+birpBWHm1B5sOS8nUR4zk97+GyPCX7b/XMmrkkSIKfkg3XxsSi3tMYIAwnzDxZS0NSslnTooUCJGZ40rtMeDE9fQsDdkvwYnqP67GmUPZ5l60NlO/R973f130ccqq5O2dAh52kUwbh3OHvvRvOVV7pOnlzooJMQdV1kkLFYKaD+ZVKP9UeX2LAgww7hL+XzEvx9I1qbZ2stEo0uyOnR/DChpAC5wdOMy39EYSnN1CTKme4jfS17sO+aby4sasRbONwp6qKw4wwTdiWWbtY/FqHwiJ21SnNl1uMOc9IaWTfbjuihZfb8NRsXs2LgI75XMJcbEihDZDlaOWn1YM/YGVTax8KpoiM4lWoCi7zb+09EbJSOqDdrKpCRxklRvJqgIKd1eVaBo2qLPsOWZks3m3iaMe/V673Tt6D3eoi+XBJaOY9WmLNA2tM/OnOA4Fmpf6xIEz2lZt000LNkUv++NA527b9RDxAA1y6/uDd8AiojqvjfNOyKGL4w/5L/FxAx+62qTOgNF+JdrwFFH7z4NDc+SeQO+KR1wmqHTuclQrMwPt0Jubh2c5tX9EIYB2wxaRw7mS7J6Qud9 MaXYPT5M ufqkVxrycDFiQy6Jvr4nwt+7cYDTBQxZF09tW1E9qW+wXntbHiRB3hNsZXRQHgmEcWtK+9eDHlnrzC8kLet9V2GKs0BvpUF4A+D7ZsRtiDerk2fPthK3E1ZdnfHRm694j3FHIZzQUfueEEAFbZKfnesvvjH31btPGd6l/cP/ekVWrvbzbMCbVrEC8JIE2p5JUOqmfjnYbQ7bY0TtFEfx5syMypdx8uMUc1RBrIB8PITsp3WtF57L905ujx8pxk9XdPGZgJ8NOsli3ItnEQtSHLXp6W5ZU1O9EYNWQ0RzFeyp3bW7C/zIaI6IZozdqIJO5jECmVmDkGR7XIHpSh0LPMnowE6YNh5R8sd6xQQBy1vHvGoa6EW0AhjMnLbolebiyYLyvg1Ajx7tgMnB/FYOuFWSE3n3ajeuLbsMjysVOwBn5nGOQ7Oegos1puF8f6unLnwlafwGZvYuK3jpm9v8zbdoLM9V77MTqot+uq/uoz6cnF2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.23 13:43, Matthew Wilcox wrote: > On Tue, Dec 12, 2023 at 01:32:50PM +0100, David Hildenbrand wrote: >>> +++ b/mm/swapfile.c >>> @@ -1749,11 +1749,13 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, >>> int ret = 1; >>> swapcache = page; >>> - page = ksm_might_need_to_copy(page, vma, addr); >>> - if (unlikely(!page)) >>> + folio = ksm_might_need_to_copy(folio, vma, addr); >>> + if (unlikely(!folio)) >>> return -ENOMEM; >>> - else if (unlikely(PTR_ERR(page) == -EHWPOISON)) >>> + else if (unlikely(folio == ERR_PTR(-EHWPOISON))) >>> hwpoisoned = true; >>> + else >>> + page = folio_file_page(folio, swp_offset(entry)); >> >> Just to double-check: >> >> assuming ksm_might_need_to_copy() in fact allocated a fresh (order-0) folio, >> folio_file_page() will simply translate to "folio_page(folio, 0)" and should >> be fine. > > That's right: > > static inline struct page *folio_file_page(struct folio *folio, pgoff_t index) > { > return folio_page(folio, index & (folio_nr_pages(folio) - 1)); > } > > so an order-0 folio will return the only page in the folio. > LGTM then Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb