From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0227C77B72 for ; Tue, 18 Apr 2023 02:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BED96B0071; Mon, 17 Apr 2023 22:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46F1C6B0072; Mon, 17 Apr 2023 22:14:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3854A8E0001; Mon, 17 Apr 2023 22:14:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 293BE6B0071 for ; Mon, 17 Apr 2023 22:14:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0AF9E1C642F for ; Tue, 18 Apr 2023 02:14:19 +0000 (UTC) X-FDA: 80692892238.26.55DCC49 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by imf25.hostedemail.com (Postfix) with ESMTP id AD5A2A0010 for ; Tue, 18 Apr 2023 02:14:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681784057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WsW+hxjFUWQVCP3sjL4WrINQbYnLfGoV4DQrgygdKzg=; b=FTj3FqdUcpPxktNuTDHI/97ibvuWog9fIqCpuhvz8tWWjE8JDXEUKUbNfu7X+8npGL4nIt QAjLA/qT4BwUNcplE68QeNSlUxLcLM2knVXcAP/S6c6SJTm/dGXPxJp70yoWDsO+S+LtRJ 3nBL36R4NlFdSq1f+RJBEtEAwgmNLks= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681784057; a=rsa-sha256; cv=none; b=Lry9K15cf+cbbjs+XLVcigf3DG4ygVs0SXkFOss/4OnvtFWPk4LG1OTKy8S0gKyHBfN71F UyIhG3mnqjRHEW64kWv2YqLmq6nMj4kIMwVCEdEH9qDsqei8ahV/aLM+dEnT0iEd7eCK0X FscSR7WtUutvghT4uesNvbtxWktxRZw= Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 830D024E2AB; Tue, 18 Apr 2023 10:14:08 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 18 Apr 2023 10:14:08 +0800 Received: from [192.168.125.87] (113.72.144.253) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 18 Apr 2023 10:14:07 +0800 Message-ID: Date: Tue, 18 Apr 2023 10:14:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Content-Language: en-US To: Stephen Boyd , Conor Dooley CC: , , , Michael Turquette , "Paul Gazzillo" , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> <20230417-bolster-vitality-89d279146497@wendy> <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org> From: Hal Feng In-Reply-To: <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.253] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Rspamd-Queue-Id: AD5A2A0010 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8jt3iedm4xhbyhifoij58u7bbd5oyftp X-HE-Tag: 1681784053-351646 X-HE-Meta: U2FsdGVkX19KAZ7pGCpSE7BCJ6tJRZW6wdVUTK10Zpbwn77r3eIEmoDArWuGa3rq6kX7p7nzLvfryy1FNpgLjTOIT1Wze4BxA6T/9aQoi8+nd3k+mDN+djcWpqxrJwcwIrSSkVU4N4jB3YgolR99J9KDuVLd6hUKkLmPzj/maZcWkxH198qWhWp+TjH/YHC1aUARfRy1xUjeLZ2ZeJNH/2LU+z1P0eWFeembOFbu3BvdJZlV6pIvc8+D25QwABhgIyrhEOyXbGyEL3Tj1RbipNCWCKLKCBw7XHPNuC2gUR6UjEBtxKfWYSjmiph59WV+QANsH50bG7RWPEq+lwmvSkKJIKtfIoo1W0WP3AZRl3okoAhKC3tjIFA/4Fw7AGYjAmRInN2gCgu6m4uYl7Hns27+X1KU0QYZUdwrIJ934vSdmG1W5gm4vc+pe+58zakFb03WqdG+IE7+xx2XuDr6EF1AVgQAPcoDkWYDKMZlpvJS3s5G8idIaGPc1bY/P+rzJYp+2i6pcZX+XQQBJjf/AAUJcS0RAbPOw+UqgI+THVDhihZmWz6lDI7NAxbtWqDAOxVh1wltyKeTJOED2/BmPLc3XgfbeR25zPjHXK1z6y6JyCidwh0LcrKD3D0e/WYlMPR6WjJycmpr2Ck4Iwr1UFHI3ImwfBCIgvngqA9xAjJUCtGw3kRarJoJ8RBxZAVGla75920Jon8eItEekNZzJI2F651Tnr2wMKBc3/3w/ok9D5h7G4OHVnaHK9BaGzeuel8ZDfRW7SUV5mHO9w2NWzgjIT98IgUu2bh467JRvJm2s29/SN4Y/sJAMaPOUfzHpbfDtpCtF3aa74sZLSTJODgSM///TpF/5P1NTVzyoaaepmEXqZ4Jw48gcFND2bncIxLHvms++aiXUlxqDWtfxuPTqB4L/kOOpyZuMNHRdldJ6MlV9doFr7kSWp/sO5oRV+Mp6Nu90/GyELfJPu3 HW6A6Mtt ALlgMiI2+UTGfUwdP0BhGErSmJmSz8qYumIwtYaNMeq3LWwpD+leaLO+5jBYRzEiagp+E37cxYX56GY0skp2YDt7CJhcvNl+k+d3/VO6TVgsLtxpmS/7iVK+zXNYfdlqbQcu8KorWCwUeEcksKqPO5vzUFREu/I9aCi/pPDGzJj6D4W+puTLadR2Z9Ijtld896ergRgKac67+q7SbuhsSetEe8H6VGLe1qlMzAdE5u0/OMpA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: > Quoting Conor Dooley (2023-04-17 03:18:35) >> On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: >> > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: >> > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: >> > >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), >> > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS >> > >> and CLK_STARFIVE_JH7110_AON. >> > >> >> > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation >> > >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant >> > >> selected options of CLK_STARFIVE_JH7110_AON because these options are >> > >> already selected by the dependency. >> > >> >> > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") >> > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") >> > >> Signed-off-by: Hal Feng >> > >> --- >> > >> drivers/clk/starfive/Kconfig | 5 +---- >> > >> 1 file changed, 1 insertion(+), 4 deletions(-) >> > >> >> > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig >> > >> index 71c1148ee5f6..3fad4adee841 100644 >> > >> --- a/drivers/clk/starfive/Kconfig >> > >> +++ b/drivers/clk/starfive/Kconfig >> > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS >> > >> depends on ARCH_STARFIVE || COMPILE_TEST >> > >> select AUXILIARY_BUS >> > >> select CLK_STARFIVE_JH71X0 >> > >> - select RESET_STARFIVE_JH7110 >> > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE >> > > >> > > Hmm, I don't really follow the logic above. >> > > Why not just make the if be `if RESET_CONTROLLER` rather than >> > > ARCH_STARFIVE? >> > > I'm probably missing some obvious reason why not. >> > >> > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. >> >> Aye, just the explicit dependency seems like it'd be less fragile and >> more obvious in the future. > > Agreed. Be explicit so we don't have to hunt down select dependencies. With further consideration, on the other hand, if we set `if ARCH_STARFIVE` here, it can point out that we need the reset driver to boot up JH7110 besides the clock drivers, and the reset driver is not a necessary option for compilation test. So the reset driver is independent to the clock drivers when you doing a compilation test. If we set `if RESET_CONTROLLER` here, the reset driver will be compiled automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). Best regards, Hal