From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: Ackerley Tng <ackerleytng@google.com>,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, seanjc@google.com, pbonzini@redhat.com,
michael.roth@amd.com, vannapurve@google.com, ziy@nvidia.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+33a04338019ac7e43a44@syzkaller.appspotmail.com,
Fangrui Song <i@maskray.me>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] mm: thp: Deny THP for guest_memfd and secretmem in file_thp_enabled()
Date: Mon, 23 Feb 2026 09:44:46 +0100 [thread overview]
Message-ID: <be04863e-55f9-4789-8222-1785030c167a@kernel.org> (raw)
In-Reply-To: <CADhLXY5GpPAD-nKZq-eP284cgP9KSh0RJs+0HRfEXZgka7DErg@mail.gmail.com>
On 2/21/26 05:37, Deepanshu Kartikey wrote:
> On Fri, Feb 13, 2026 at 2:36 PM David Hildenbrand (Arm)
> <david@kernel.org> wrote:
>>
>
>>> For 6.12 stable backport:
>>> - IS_ANON_FILE / S_ANON_INODE does not exist in 6.12, so use
>>> mapping_inaccessible() || secretmem_mapping() in file_thp_enabled()
>>> instead
>>
>> I think secretmem_mapping() is sufficient there given that guest_memfd
>> does not apply yet.
>>
>> But we can discuss the details about the backport once the upstream fix
>> is in.
>>
>
> Subject: Re: [PATCH v2] mm: thp: deny THP for files on anonymous inodes
>
> Hi David,
Hi!
>
> The upstream fix is now in mm-unstable and linux-next. Should I send a
> backport for 6.12 stable?
Wait until it is in Linus' tree. As we CC stable, you should get a
notification that applying the patch failed.
In reply to that mail, you can more easily send the backport.
>
> Since IS_ANON_FILE / S_ANON_INODE does not exist in 6.12, I was
> planning to use secretmem_mapping() in file_thp_enabled() as you
> suggested. guest_memfd mmap is not present in 6.12 so only secretmem
> needs fixing there.
Makes sense. 19bbfe7b5fcc ("fs: add S_ANON_INODE") does not apply
cleanly to to 6.12.
--
Cheers,
David
next prev parent reply other threads:[~2026-02-23 8:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 3:35 Deepanshu Kartikey
2026-02-09 10:24 ` David Hildenbrand (Arm)
2026-02-09 10:41 ` David Hildenbrand (Arm)
2026-02-09 13:06 ` Deepanshu Kartikey
2026-02-09 18:22 ` Ackerley Tng
2026-02-09 19:45 ` David Hildenbrand (Arm)
2026-02-09 20:13 ` David Hildenbrand (Arm)
2026-02-09 21:31 ` Ackerley Tng
2026-02-10 9:33 ` David Hildenbrand (Arm)
2026-02-10 23:00 ` Ackerley Tng
2026-02-11 0:58 ` Ackerley Tng
2026-02-11 2:01 ` Deepanshu Kartikey
2026-02-11 9:29 ` David Hildenbrand (Arm)
2026-02-11 16:16 ` Ackerley Tng
2026-02-11 16:35 ` David Hildenbrand (Arm)
2026-02-11 16:44 ` David Hildenbrand (Arm)
2026-02-11 1:59 ` Deepanshu Kartikey
2026-02-11 9:28 ` David Hildenbrand (Arm)
2026-02-11 14:50 ` Deepanshu Kartikey
2026-02-11 15:38 ` Ackerley Tng
2026-02-11 16:45 ` David Hildenbrand (Arm)
2026-02-12 22:19 ` Ackerley Tng
2026-02-13 5:02 ` Deepanshu Kartikey
2026-02-13 9:06 ` David Hildenbrand (Arm)
2026-02-21 4:37 ` Deepanshu Kartikey
2026-02-23 8:44 ` David Hildenbrand (Arm) [this message]
2026-02-10 1:51 ` Deepanshu Kartikey
2026-02-10 9:33 ` David Hildenbrand (Arm)
2026-02-09 23:37 ` kernel test robot
2026-02-10 17:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be04863e-55f9-4789-8222-1785030c167a@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=dev.jain@arm.com \
--cc=i@maskray.me \
--cc=kartikey406@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=michael.roth@amd.com \
--cc=npache@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=seanjc@google.com \
--cc=syzbot+33a04338019ac7e43a44@syzkaller.appspotmail.com \
--cc=vannapurve@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox