From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07622C2D0CD for ; Thu, 15 May 2025 15:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3E3A6B0099; Thu, 15 May 2025 11:22:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEBDF6B009B; Thu, 15 May 2025 11:22:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB56B6B00A9; Thu, 15 May 2025 11:22:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A4336B0099 for ; Thu, 15 May 2025 11:22:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F2AF457D3A for ; Thu, 15 May 2025 15:22:28 +0000 (UTC) X-FDA: 83445508776.20.2210CD2 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf23.hostedemail.com (Postfix) with ESMTP id 1303E14000E for ; Thu, 15 May 2025 15:22:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="QV9VfrW/"; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747322547; a=rsa-sha256; cv=none; b=Vve14yo9ecG/H5PgQNH7vmoATmm5xrrKALPiSDsZi1LzMJffy1PLTAGb/2qAiGb/DTupuK hUC0w0FWgx5myCkFR260V4KjrwZhlzCpZVVLhdHMHrCpqSCM3yNaEggPtIT764YrgRPWMC dmwWHjcWLfBvfsELYqAuUKTupQJWcVo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="QV9VfrW/"; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747322547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BKemoW9RKBpGwi/CtDte4HwNTYROA1s2q7+99WZ3tcQ=; b=yschXkYS5pxILpQxivym+EixxjfQrvzzaV1gQYZoSvZA6lUkg0SuZ+Cqnh6k9YPAYSqh8Y H6PE3m55u5icvgvrdqnNwfityT0VHONNulv7sxxjRtqygV+oOAqEmy138D1isIjuIib98b hhgmzinlbS+ZeDpP0pDvQXJkrhUht8w= Date: Thu, 15 May 2025 08:22:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747322543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BKemoW9RKBpGwi/CtDte4HwNTYROA1s2q7+99WZ3tcQ=; b=QV9VfrW/v0GXkrsEDb2xKJaIwT9NJMMpeAiHn2qBRFhlAFsJ3hSSQ/eK/C1SACdKPcYVNU 0Ph/XJym8FNFThe6+h11oclXv3eWJA+edGYcPcJOMSk8TqElMpMRzLNNacQlaXTO/m/Fea xwVpLZ0LKR+3SukCodQnILPplzNYHbM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Lorenzo Stoakes Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs Message-ID: References: <20250514184158.3471331-1-shakeel.butt@linux.dev> <20250514184158.3471331-2-shakeel.butt@linux.dev> <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1303E14000E X-Stat-Signature: ukn539kue8wg3xijzgs8rx4nt8t8epz6 X-HE-Tag: 1747322546-732394 X-HE-Meta: U2FsdGVkX19G3FEdcWGdaxfaYtzAbjLOZl7R2GrTOETmiipAHDS9NEoM2VGzoFRxaXdIJvNiz/fTfCx4nGO8cEbu78oVoqAyZK8lhkdK3Bczf37+RScFO5aAwwoat0gaW9aOlAL7VgYdtrtgrW0gYLoq1ivoffs79WiXVm2/3UEPyD8/OX8E0JKrVBeJc2N4iFYyFlFw1gyWGQDReROHv7fAnTXVXTrAKbOPazwq1QY1oa3wJAaQaqRXVFqVH4Wn/Foin/kQ0HPdav0a5ncxo0mf3d9s7lyaihScKsIwQ9J7uwk7jCf+7U9ThuVtmKUeXgtXppsaep5tKKD8h5VH4dMo8q1Mcj2gio8IDbl1ocGuX8tipY7vRS18xql4RCidM3PjAmVBUUxyrSGdHvQ9crDQ26aN4vaWTatc6curVBOlrkaC2QTe5wysFxkaL4i3Itmga3gYLOnQVZJKtXxV66luIoCy8vzZ8NEx0U7E1ahGXyDroNMNpgChX7rkQ9WNK9MzqJq6weiIf/RcpiZZ2jIXbEVP4G1PKftcfuFbw3e0hWCEn71wG/GUBL4ijSrIhxp3W74Lhp3vd5aLhJJ4PYS3eIdtsvh4yXXS/P0sOlO26DKPtIJnwNtt+B9PU/dmocS6LCI8rbkT8Bf60PvY/W4oXxGsXX/V7yBRKtkEn01yD0T6wyKL/2JL9PmOtHCILva4ZnKWDfO750hTnIgPZ5MmyLZgaqT649J7nHKrsoUDvWUuQgx05xFYi9xQpET0KFcUB3ZL91ppsVOVsBVXeTa37vmEFzX+bo/eQWdsgnC7LNQLOA39Ax/9zE1J857qvVFhkrZThkoCFQLyRKoxwyxsHKLT79HPyCVTZuFsHPd5yMvKyEPKPaQrcCpahPvsgcjpOw/CeKNiZNIh1u0NcgT2GKyjQ/R0UiPC4hvwhNRkMGQkyEsdLuFmgWnygYxaQs+RXhTdnE6JXdGNsIi AynelrTE PlaR2kcr7C+Qmn0C+F3j0xJ5M1usAP3Ptxq7wILgt7+bv0IJ2r5XHcgLeDd0VP3YVOkqIK/tvijXBZyIxTyUTcGKu2vCv4nxvR7dRwbP+DPXsXxDgY0OVck0JN0W2GGgA4MeXfcpZ271Hig9UhitAYSN/gH5gaweiEWfGcRB0dbjqjnOIuSMzmWvhDi/PBgxXobgFTDZgKRqGOK+XoJvMw1kG/W8yixr7IvsLn94zTXqi0hlDSXYX76Rqq56lNXTXdJ0bUuHy4/ZfXgy4mYODTlOnig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 03:53:17PM +0100, Lorenzo Stoakes wrote: > On Thu, May 15, 2025 at 07:31:09AM -0700, Shakeel Butt wrote: > > On Thu, May 15, 2025 at 5:47 AM Lorenzo Stoakes > > wrote: > > > > > > Shakeel - This breaks the build in mm-new for me: > > > > > > CC mm/pt_reclaim.o > > > In file included from ./arch/x86/include/asm/rmwcc.h:5, > > > from ./arch/x86/include/asm/bitops.h:18, > > > from ./include/linux/bitops.h:68, > > > from ./include/linux/radix-tree.h:11, > > > from ./include/linux/idr.h:15, > > > from ./include/linux/cgroup-defs.h:13, > > > from mm/memcontrol.c:28: > > > mm/memcontrol.c: In function ‘mem_cgroup_alloc’: > > > ./arch/x86/include/asm/percpu.h:39:45: error: expected identifier or ‘(’ before ‘__seg_gs’ > > > 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) > > > | ^~~~~~ > > > ./include/linux/args.h:25:24: note: in definition of macro ‘__CONCAT’ > > > 25 | #define __CONCAT(a, b) a ## b > > > | ^ > > > ./arch/x86/include/asm/percpu.h:39:33: note: in expansion of macro ‘CONCATENATE’ > > > 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) > > > | ^~~~~~~~~~~ > > > ./arch/x86/include/asm/percpu.h:93:33: note: in expansion of macro ‘__percpu_seg_override’ > > > 93 | # define __percpu_qual __percpu_seg_override > > > | ^~~~~~~~~~~~~~~~~~~~~ > > > ././include/linux/compiler_types.h:60:25: note: in expansion of macro ‘__percpu_qual’ > > > 60 | # define __percpu __percpu_qual BTF_TYPE_TAG(percpu) > > > | ^~~~~~~~~~~~~ > > > mm/memcontrol.c:3700:45: note: in expansion of macro ‘__percpu’ > > > 3700 | struct memcg_vmstats_percpu *statc, __percpu *pstatc_pcpu; > > > | ^~~~~~~~ > > > mm/memcontrol.c:3731:25: error: ‘pstatc_pcpu’ undeclared (first use in this function); did you mean ‘kstat_cpu’? > > > 3731 | pstatc_pcpu = parent->vmstats_percpu; > > > | ^~~~~~~~~~~ > > > | kstat_cpu > > > mm/memcontrol.c:3731:25: note: each undeclared identifier is reported only once for each function it appears in > > > > > > The __percpu macro seems to be a bit screwy with comma-delimited decls, as it > > > seems that putting this on its own line fixes this problem: > > > > > > > Which compiler (and version) is this? Thanks for the fix. > > gcc 15, but apparently 13, 14 also fail. It seems independent of config. Thanks, somehow it works with gcc 11.5.0.