From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228D0CD342A for ; Mon, 2 Sep 2024 13:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 941A48D00DA; Mon, 2 Sep 2024 09:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F2048D0098; Mon, 2 Sep 2024 09:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B9528D00DA; Mon, 2 Sep 2024 09:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 568F68D0098 for ; Mon, 2 Sep 2024 09:12:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 013CFA8941 for ; Mon, 2 Sep 2024 13:12:52 +0000 (UTC) X-FDA: 82519838226.30.E65314B Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf10.hostedemail.com (Postfix) with ESMTP id C977AC002C for ; Mon, 2 Sep 2024 13:12:50 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf10.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725282695; a=rsa-sha256; cv=none; b=LDuiUKaNzQ4sqAgHelyEBcSgbC6nvAksGL8g7bAVQOlbk9asU9hxvySE4eKfpnxlyazG51 n0B9bMB0H81x9sDYflZn4GXsLebNfVpKN9NXFJHHrOszj69qW/WxMjxLDvH4h8s6mbFkuh 2NXgycxEXv8uV1/+UbDwxiYYAwQhb00= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf10.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725282695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dH5m8owdpYqyrBi6DYG1Fu4i3YljG8M/3k/nCuaU84=; b=2B+jiRXtvTZOBhAmtol2Lmeyumw3blqhu4LNKlvtDp+HszeY6xX82fvA3Bcsghcwv4m+dT Fl3moTMVLAy3drXpPCfVlhSq1iFKRiwenh8F66KqkyFeVUZftcVVUWL9zMJMEVHgo/eAAY 70xjmzKPQyzYRlAO7VBhGbtv4JumuAs= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Wy8Lm6QHHz9sSN; Mon, 2 Sep 2024 15:12:48 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bOAmrEYbu_oc; Mon, 2 Sep 2024 15:12:48 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Wy8Lm5Z1Xz9sS7; Mon, 2 Sep 2024 15:12:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AD68B8B76C; Mon, 2 Sep 2024 15:12:48 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id bvD0TdiWVJyj; Mon, 2 Sep 2024 15:12:48 +0200 (CEST) Received: from [192.168.234.167] (unknown [192.168.234.167]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B29AB8B763; Mon, 2 Sep 2024 15:12:47 +0200 (CEST) Message-ID: Date: Mon, 2 Sep 2024 15:12:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 To: "Jason A. Donenfeld" Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C977AC002C X-Stat-Signature: 3a9s47hobkyrxcfgxrgpztbbnq33pi1t X-Rspam-User: X-HE-Tag: 1725282770-608537 X-HE-Meta: U2FsdGVkX1/VWGMMbnmSKgdT15pSjM2B9MOqPq9Pn1EyVU7Zv3zD5KGbu96ZKjQQ71Dy0cEjQt2984mQOJeuWAK0L4tu9Qlcso2Tb7rX4lai9NeNx4X3ndp5kLksCgMkvVIgY3tI0TZImIZrWTN52g0G/YSoTjhuvYFaw2IIrySj9liVrl3EZ3WOiaDvt8EmohLnAgzrIzQbRqBujeMAd/GFNt5ZfBMcxPE9KQFZis0DvWMphXVaf5zRHJHc0FkBDPsSJVoOTjQ/kUTnDXhVgG6XeXXXdqeN0qr+TOB7jphDoXAJFQdKoARuaHIvVxGFiDCWNZcniWtp48zK8eIfJ7pqYfFRu7t+MbJUn7HH2eyesIWpovKt3dZTzVJo6KLfes+YSWWVMM5x8qCUXf32FxzZpUNerQohs75587uXkPfLWuTEPMazKms+lB9WFrddaMzRUJ/56Qmd8poG7jB6o1T4quksQ7f0242qPrfVM0txkvqj4FxZZXkt2zze3Exe04BfmCx2BDNOvrTEw+f/VWldeLtflEqgnDBEGI3uCyO94ecbmLkw0iaRy/1fw3LJagBptA2CjE7zmVi/V8kOjM0wtbzmihF7az0Iunf5Rn8xZsBJqp2QLMdt6o2KlB8B+/GuNhr6+qZ4B4lb0PtD1XYdQb83L3Xf3mn7e21x+DZUQ3vYQHgGXt1mk8WePuCn27G1SRewVe+ph69yDj7XdlOAYj6dmudjvu/txz3Q7iH6ZLtUuSmw7StVqp3kpwZfV4U8BMmnt3KgsN368CG5wgKQqM1N+ve2HU/yFmWKeNloAiVF7HjktkFsD5sx/7hQiog5TECY+CnU0NNQWBbTA+O9kkxrYdnuh8waBa0TsgMMXI3srSVvhSCje35wqtlKLNXUnU1T+ilDX82xSeaCrPAxY3afdVePI5VC05LHHsrSN+XnpkV85BDC+UfmbO1xLv7ADS0K+3j7p9OnnUC UTgWpVzO 7EpOACeku9UZpbKSWh6FZ6STn2BgTZHqlGeuKJZR+qHUNjs+syfTe8pVdW/h/2BaB2WTOH5iE0CLxQl7N3dVl+/gQnl8/aYIc+BdEqW5SOrvnmkQrVPl4oquCNH0s4sTi756TC6y8H/Vwo3k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 02/09/2024 à 14:41, Jason A. Donenfeld a écrit : > On Mon, Sep 02, 2024 at 02:04:42PM +0200, Christophe Leroy wrote: >> SYM_FUNC_START(__arch_chacha20_blocks_nostack) >> #ifdef __powerpc64__ >> - blr >> + std r5, -216(r1) >> + >> + std r14, -144(r1) >> + std r15, -136(r1) >> + std r16, -128(r1) >> + std r17, -120(r1) >> + std r18, -112(r1) >> + std r19, -104(r1) >> + std r20, -96(r1) >> + std r21, -88(r1) >> + std r22, -80(r1) >> + std r23, -72(r1) >> + std r24, -64(r1) >> + std r25, -56(r1) >> + std r26, -48(r1) >> + std r27, -40(r1) >> + std r28, -32(r1) >> + std r29, -24(r1) >> + std r30, -16(r1) >> + std r31, -8(r1) >> #else >> stwu r1, -96(r1) >> stw r5, 20(r1) >> +#ifdef __BIG_ENDIAN__ >> stmw r14, 24(r1) >> +#else >> + stw r14, 24(r1) >> + stw r15, 28(r1) >> + stw r16, 32(r1) >> + stw r17, 36(r1) >> + stw r18, 40(r1) >> + stw r19, 44(r1) >> + stw r20, 48(r1) >> + stw r21, 52(r1) >> + stw r22, 56(r1) >> + stw r23, 60(r1) >> + stw r24, 64(r1) >> + stw r25, 68(r1) >> + stw r26, 72(r1) >> + stw r27, 76(r1) >> + stw r28, 80(r1) >> + stw r29, 84(r1) >> + stw r30, 88(r1) >> + stw r31, 92(r1) >> +#endif >> +#endif > > This confuses me. Why are you adding code to the !__powerpc64__ branch > in this commit? (Also, why does stmw not work on LE?) That's for the VDSO32 ie running 32 bits binaries on a 64 bits kernel. "Programming Environments Manual for 32-Bit Implementations of the PowerPC™ Architecture" say: In some implementations operating with little-endian byte order, execution of an lmw or stmw instruction causes the system alignment error handler to be invoked And GCC doesn't like it either: tools/arch/powerpc/vdso/vgetrandom-chacha.S:84: Error: `stmw' invalid when little-endian