From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79069C28B20 for ; Wed, 2 Apr 2025 08:53:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4407280005; Wed, 2 Apr 2025 04:53:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F555280001; Wed, 2 Apr 2025 04:53:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BAC5280005; Wed, 2 Apr 2025 04:53:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6F7CD280001 for ; Wed, 2 Apr 2025 04:53:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3F861C14F1 for ; Wed, 2 Apr 2025 08:53:28 +0000 (UTC) X-FDA: 83288490096.18.27213B7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id A44CA12000B for ; Wed, 2 Apr 2025 08:53:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743584006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bsaL5fZavHC2HY1oeph/EkFiZixOGKZmWojNQbYtxA=; b=TVExSkFMJ4+6znDOUrxG/fhHSPglDyaI1YA9aX3heNGWX9EpEZREfleuPm4OOn9t93KjtJ gH26qSEfe4vkwgcVaIRzLeiAt6bYqlvCtwJt5bwpZQIvB65g5Dil4l0Ra4r1GHGNB/ENNd YT3Z1c1vJt/QcrvGc4TTlDcTjneBslg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743584006; a=rsa-sha256; cv=none; b=EmR5w4JlV2BaM2PY9FzZKA6ruWTSpQnTe4iLUkLjI63TZWkK2T5/tf2ZL+C135dolIDJ5l di0YvrNDqBfR0+4AewiBBJ96l8hFVxn/1K5ksSeds7xr88W6eVmbTBo672MuB/8Zd9AVGu fF3uAf5nRkxtJubO4otZGu7e/4Hf/bY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0B1812FC; Wed, 2 Apr 2025 01:53:26 -0700 (PDT) Received: from [10.162.16.153] (unknown [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 75D963F694; Wed, 2 Apr 2025 01:53:21 -0700 (PDT) Message-ID: Date: Wed, 2 Apr 2025 14:23:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: page_alloc: Remove redundant READ_ONCE To: Songtang Liu , akpm@linux-foundation.org, ying.huang@linux.alibaba.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhengqi.arch@bytedance.com, songmuchun@bytedance.com References: Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: gi8je1bkce9rw5mzc7riof4x44ux44d7 X-Rspam-User: X-Rspamd-Queue-Id: A44CA12000B X-HE-Tag: 1743584004-992664 X-HE-Meta: U2FsdGVkX1+a5SpK2uptbSE5GP0EGB3bi+BFEPmsLhf44f8OE04JNb3sBG8L9pRI+tN9/5XtnZ/6kIM6YAUgE8CdmF+ielDnclmehbyTsVtyI6g0H8lT9IJBzwZ1y8yY9L9OdNp4menCtXQjNb1WSYwrNbKFOSgTHW23bTYq01fMbZm57lryUtKUz4iu74MI09ziSGETCVoB6J7Pva7cyqUbcWErGS/oPzZVQCUwyN0OLRihx3qOUeUEHcppzksmuY3iU0e5NnQelpZXahQZNeqGS8pQFs2SF89iasCdAo+5J15MR0DlOl2SjhKxuYbBVVfHRI2TJdIznC6uq5JTKtGOz18jTUtMZ1uhw0qo4UM64ggTDGiWH0DoQuVAT48VZr5ltWe79JT4x3URHFb31T8Zt0GN+b47hN2WpWTokXhFMbgWcgI1OVpziqsnUyXOnXwGAHJE1y7P5jE5NusS2PpKfB5gwCE64yViS47zZBESiM9ncMpUG8zSq9I0Ef0tBxbN9z4wOfThRRRB6vzYdWXIZf+DNqaGWmkHmpw80bGZYYRoNcX/0soNnPLJK87p2XPEtK3fTtzXYc6Cc/c6lq13cSnV5DOp0Dh7JutWpogVcWdBS10MFMpEqUsj4otnQ03C6Yi5BVhEhWs6yY/4sBKleZATu1KpTLWn6j0fA6BzXI0V+CtiGX8r1R1L6E0I97KgvjS1f+bsCJKstQfEbkQmoylWjLvc/PpWZDbNb5C2Us8zkoqmbvuhjjBpWfqPxdKeU/X8S0mm+eCtv0SeuBvJomGQoE1GgvJpY9s5ArVJmqom8YJw5vLWyK3Q2kBVazCmsP06lUr7+iqmdFbKFrgVOZZj4UBWBAIP3wzMuiO+UkQXxrdiZVSxThxvWs0cqKV8jnaS5IWCX4C0uGTvQg2XytUxnlwJNXdBNHI9Azw8UCDsEvhmqfy0AYmsuHr2N7738pQb1KBoKP+zL7+ 5Dn1roxX QgdYMveQCFZQM0sALunkRBV7pjzc8XkPqnYK4xKT8ZPH2czJJbYpJl7+uqG77P9R5dHwxr2NA58AaIFuyreabH5YtxD5nnyWi2qihO3vaJvXhUrzWHbnO+t+gtrtkmUOTj3UobVaphYaRvTcZJ0GAhnaVlN6sqI3hFRVpDTuEyjrtH1OLj+cP9NWK3n6agwCSUNUEJ4sO7GWvuv5SLNSOBWFq/+SWx3kJZDVAWd1iGY+eKlGqqhD6mZbFJjrt0obw4RufzVwNPBMC+TI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/2/25 13:11, Songtang Liu wrote: > In the current code, batch is a local variable, and it cannot be > concurrently modified. It's unnecessary to use READ_ONCE here, > so remove it. > > Fixes: 51a755c56dc0 ("mm: tune PCP high automatically") Although READ_ONCE() should not have been used here with the above commit - does this cause any problem though ? So in other words is the Fixes: tag necessary here ? > Signed-off-by: Songtang Liu > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e3ea5bf5c459..6edc6e57d4f8 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2661,7 +2661,7 @@ static void free_frozen_page_commit(struct zone *zone, > free_high = (pcp->free_count >= batch && > (pcp->flags & PCPF_PREV_FREE_HIGH_ORDER) && > (!(pcp->flags & PCPF_FREE_HIGH_BATCH) || > - pcp->count >= READ_ONCE(batch))); > + pcp->count >= batch)); > pcp->flags |= PCPF_PREV_FREE_HIGH_ORDER; > } else if (pcp->flags & PCPF_PREV_FREE_HIGH_ORDER) { > pcp->flags &= ~PCPF_PREV_FREE_HIGH_ORDER; Otherwise LGTM Reviewed-by: Anshuman Khandual