From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E67C021AA for ; Wed, 19 Feb 2025 06:31:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E4C92801F8; Wed, 19 Feb 2025 01:31:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 294522801F6; Wed, 19 Feb 2025 01:31:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 135352801F8; Wed, 19 Feb 2025 01:31:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E54D22801F6 for ; Wed, 19 Feb 2025 01:31:24 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 93B4D140F0A for ; Wed, 19 Feb 2025 06:31:24 +0000 (UTC) X-FDA: 83135722488.06.C53E68F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf10.hostedemail.com (Postfix) with ESMTP id 3998CC0010 for ; Wed, 19 Feb 2025 06:31:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739946682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RQHN4poLpJo1Zlrv61oYI2wXpnszTtC/Zv2dESHzF/c=; b=B1Z/Nl1EmVJrshA4+U3zUy+PlTpySqVak6FbhhfP+kjqkh6lSHhCpfSd9DMQ8SuiyPBRjj ft89JdZNhgyi+/K/LnWxEU7FfKihPq723raRB5Qo+U4PI/WmgCPECRTE5a5YroYB6G/ySr 53c4B+5Q8p6J0EKaU30ko8TBMHKjrZ4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739946682; a=rsa-sha256; cv=none; b=acMZ70EHhFcMc0I10NC2OYKMBhOZghVWUhAL//ijTsuOK670Lv4p9shDFSSHxoayoqfEIk OXBYofBh345aM4IOrCrfxv3/z8djEOblepSbhwHPaaspsql6oM1aS/K9VancxKKw5hjJqe Q3jpLUJBMGHGCLKgdmKzeEPAgIuCt1U= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4YyRK52DXSzhZx1; Wed, 19 Feb 2025 14:27:53 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id CC93B1402CF; Wed, 19 Feb 2025 14:31:16 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 19 Feb 2025 14:31:15 +0800 Subject: Re: [PATCH v2 5/5] mm: memory-failure: move return value documentation to function declaration To: Shuai Xue CC: , , , , , , , , , , , , , , , References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-6-xueshuai@linux.alibaba.com> From: Miaohe Lin Message-ID: Date: Wed, 19 Feb 2025 14:31:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20250217063335.22257-6-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspam-User: X-Stat-Signature: 9bb4odciwbu44tcqoz754xwu86j4kg5z X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3998CC0010 X-HE-Tag: 1739946680-507286 X-HE-Meta: U2FsdGVkX19EAD/ZNuaIbBZj4i1H7/VL+up+7BAZ3M3/Z8F9mg4LaLKX3Qi/67QevsLBJPN9iTqyLh7EjlqGrflpeNZ9zOsAKf2y+OAMxlmTcsQ6zYlJGaiHjmnZSlnLe/myrGFj3Y1mMa65XnbzOVLhh+C5Z8GJ3a+PIRHEqv3KadyhcCuf7xBNhE6tetGN0+aQoznoKEFSPaZ/7RjFYzA9znlSMgaGK5T1eAAPcV2NF9A+qviagkH2G+TJMcBpqzvhvIyJ7pZjfg2F05IObqY5DJxKFmc7nx7FtSNEbN4XfECno0PbFTTXquvXoOz2yO/PhcCf5fu0K6E1B2P5GKY3fp3q2o0lnPo2kIVNpFQ9gpHdDrv4lx87hlfZ9rivtYkjaqVkngLvKvdcCNW7ltIFAE/G3HvTVtDd27z5zNQUiEtpafygxw2bRmDyx0LgOn5s5oYaJJIaEDOq+zsZgpaOLUiBAEmFMpT6DuwckRq3bxme94WCps70+IEbMgVYiHv2K+LiMu0P2qaIYKzIWAQncWYWFYV/PtTu5jYskmz6F/A5vsCVV3i6sF5Cf9ZcQ2vKDW9BewA3Xni5Lb9mHQlXcJPCAMMXTQXBs6UcmDgRHcD7+ENUQEyTlB7XztFH5KxGwTCBxuK1wIvjP7wk8L1cpALaJ6ze+XB+LbX9qBK2F0ifgLi5/OONW8IQp8CdahV2aUNMyd8oFj260ifl8BwptFe7hkZyXcPIylqseMxPZUXFdqaqLO3IdiXWtIIhZlcGysJa5A2Wyw7HKMpGT9P8uMOk3/nTdll0gwio2v61gNTHNPUTNfDjxIT6B7cH3jcvsQoo7TSqbB9VA1OZ2zK4U5dmPhAgsWeQyMSMNgBeB8AzowxEaflp64GIMe3DOjgXhgyIIFqiaK0bYs8ajDKOva7jZx1MY0elsOnChruOUKc52OslFTJLUweCMsfigFIugJmy0bEOWEPGh/Z V0kjvCYi dz05gSCddrRo1q8GwlbDmDY3deesn73AX7Py73+vgywtjhjSbzFha/+Kat9886/D5gw3obADV3s2z4YwyJDKly6aGdu9YFLZN+ZTxmRTbFZTbK+iq40RgH1LMy5/74R8yH9wWpeHEJn4xov75jEtw3Pv04hkHrxXsteSQ4VvQ2h4d+O582d9E1mjTd0ilEgWG4PfrVy3NtnaeHQ6G5D7YzDUh7K/eTF8HFMPHlX303++JsiJ7v1gLJbI/O4dUbaSXYH3gALcbecLw7t+gElUS6gVUGlFxZk1AD0bRYQikid5J1a3SIzN9Olm4dsZn7CpBXqqvuSbigdWooBuukojj41ljB2tPlGcVMkrv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/17 14:33, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jonathan Cameron > Reviewed-by: Yazen Ghannam > Reviewed-by: Jane Chu LGTM. Acked-by: Miaohe Lin Thanks. .