From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E7AC07E9D for ; Thu, 29 Sep 2022 05:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BB0A8D0002; Thu, 29 Sep 2022 01:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A658D0001; Thu, 29 Sep 2022 01:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3594D8D0002; Thu, 29 Sep 2022 01:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 265BE8D0001 for ; Thu, 29 Sep 2022 01:02:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ECAC3C0945 for ; Thu, 29 Sep 2022 05:02:06 +0000 (UTC) X-FDA: 79963926252.02.0AAE47F Received: from forward500p.mail.yandex.net (forward500p.mail.yandex.net [77.88.28.110]) by imf09.hostedemail.com (Postfix) with ESMTP id 86436140004 for ; Thu, 29 Sep 2022 05:02:03 +0000 (UTC) Received: from iva3-dd2bb2ff2b5f.qloud-c.yandex.net (iva3-dd2bb2ff2b5f.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:7611:0:640:dd2b:b2ff]) by forward500p.mail.yandex.net (Yandex) with ESMTP id A115CF01D49; Thu, 29 Sep 2022 08:02:00 +0300 (MSK) Received: by iva3-dd2bb2ff2b5f.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id ETklQmnJyn-1xhmag8R; Thu, 29 Sep 2022 08:02:00 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clicknet.pro; s=mail; t=1664427720; bh=+ekkMXsOCBpjoEbsni/lyIJUteJvMaGsDGOn2UKGQ7U=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=Lc1y7Mwtzd4o8xKTAPL0eExZtntoSwZbkydPxkuzq6Zck+rUyAE425GrTXU0W3EMr 7LlYSth82xYsC59Lnk/WNNiJlGzOq62cEymrpY4UCKvnUMBpl7v/w0hJtRIxqKidQL IfM31qa+b/Co+VO77g8HPRHvwxlPMMjKDnL7iGXk= Message-ID: Date: Thu, 29 Sep 2022 08:01:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5] mm: add zblock - new allocator for use via zpool API Content-Language: en-US To: Matthew Wilcox Cc: linux-mm@kvack.org, vitaly.wool@konsulko.com References: <20220928080100.19134-1-a.badmaev@clicknet.pro> From: Ananda Badmaev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=clicknet.pro header.s=mail header.b=Lc1y7Mwt; spf=pass (imf09.hostedemail.com: domain of a.badmaev@clicknet.pro designates 77.88.28.110 as permitted sender) smtp.mailfrom=a.badmaev@clicknet.pro; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664427724; a=rsa-sha256; cv=none; b=TupwbNRhiSF1lqaVoFkffsiJoMcsrnEUeQktnhW5YkCLYGiXdojPBWBpBB5E2ig0ioMynQ L4LqJWQqgA/fLys/Pi63jbm+xrzjhuis+Nnf4ZhHOlztRLJuliAuE8lJ4ASnoqW9ijG5FD 5v6MDR4eQ+zOswBFtb2aXa3MOAAoDdM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664427724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ekkMXsOCBpjoEbsni/lyIJUteJvMaGsDGOn2UKGQ7U=; b=S8p138eR9KwIEpDsUe9B49SjJEZEDCAvJ3nC2LaikoeH+1eMN+ce2ZGkcbBIRpAPL54nxG A/wBZbgljBcxmMc/MmXgLXein0raObTz7Bsze60iqSw4aZzKvOosxhEPv8D65ixelYPFMu Bo15GC6qhO/ElJCQBCLc4rAaPKdO/LE= X-Stat-Signature: k4m19xbm84s91y7nrztqxjbrnpenbtya X-Rspamd-Queue-Id: 86436140004 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=clicknet.pro header.s=mail header.b=Lc1y7Mwt; spf=pass (imf09.hostedemail.com: domain of a.badmaev@clicknet.pro designates 77.88.28.110 as permitted sender) smtp.mailfrom=a.badmaev@clicknet.pro; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664427723-827904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 28.09.2022 20:29, Matthew Wilcox пишет: > On Wed, Sep 28, 2022 at 11:01:00AM +0300, ananda wrote: >> +static struct zblock_block *alloc_block(struct zblock_pool *pool, >> + int block_type, gfp_t gfp) > > Your indentation is completely screwed up. What are you trying to do > here?Default tab size was 4 in my code editor. I just have set it to 8 so there should be no such problems in the future.