From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C2AC7EE26 for ; Mon, 22 May 2023 08:53:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31862280001; Mon, 22 May 2023 04:53:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C862900002; Mon, 22 May 2023 04:53:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19092280001; Mon, 22 May 2023 04:53:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0793B900002 for ; Mon, 22 May 2023 04:53:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C2C30160D1B for ; Mon, 22 May 2023 08:53:28 +0000 (UTC) X-FDA: 80817277296.04.C3E3D03 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5FC2FA0008 for ; Mon, 22 May 2023 08:53:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=foQ8EBfP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684745606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sjz73XelY9z0l4QYLhIw3O47wzYWVLPX1qVdIi43Aus=; b=PaW8j5lfj3QvxvacU0iHFvrrnxvAIPq7YOuBVE2xZzhQ/9qgNJxWSvMBwxXYwpsP/lqbs9 v5/yd9p5al6ZYyPNxLeZgozj/IH/QqqM+0K5Ddc1APMAkJd72DKAim7ZgpvKVNR7zoklDo e6MGiutNPzCcFChNv6S6U0th7Wt4CsQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=foQ8EBfP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684745606; a=rsa-sha256; cv=none; b=nJIZBcF21lmBsVN6fPsTva047AUo36ZXZewSmtHZmEyGjiue+Irv/5zbExaG4POvexo5YJ dh1i2L1j9CaFRpWWuQTgd6v6BxpseOJl50ASfYyNoxD7l3kYRbGTOR9h1NOidTm3+HqVpY AYUxWv48w2lJrjLfN7q0OmfQpCPKRoU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684745605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sjz73XelY9z0l4QYLhIw3O47wzYWVLPX1qVdIi43Aus=; b=foQ8EBfP5HM5t+7AI2gSoUsgcnStLs9+V0i0N3Szqz8oVbJM2LHl2T4XRJrb2FA5xYZXNp XPM4Kv60/t0eAhFcMfs9SL5SaM+hnxDzsLyI6c0rGeGT9SxHl72rKU0XW0S2YY6WzWdo9W jxcmAQ4AyGP7H626KfL/11DWz/ax2DU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-LrFJach4P1SlaywYKo6dWA-1; Mon, 22 May 2023 04:53:24 -0400 X-MC-Unique: LrFJach4P1SlaywYKo6dWA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30a8f6d7bbdso261244f8f.0 for ; Mon, 22 May 2023 01:53:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684745603; x=1687337603; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sjz73XelY9z0l4QYLhIw3O47wzYWVLPX1qVdIi43Aus=; b=Jz2TVjrPIiUnW9JyBbjBvJ0WoAI90yVj3rUHCJW5VKszPcxuKcz1Lz1+dsQWNKYMTg wWgrfmA2jM4EPr8tbJv79NaANNFcqFXdg6+Jkfa+bLSFzVINzgOZrVcxiB8bbpH+328G KWQyMvJqZtky9XyJXfP3Fa3gK2zmId22bKKJ7RMJ6BIIEUoK5JSyNH8gzCdYiTOFaTzz 2ivZfgVd3KE9svADxJzHlRBSbLx93spVFHqYcAVQDDqykNElBxETtrYZR2ctAMe25PG2 VHzWWxUHGKsYpp8ntz3Pq6TtutRAmJq4i6W0ozWns6ZUSDxH5gDjfY0bYWG0DoosXhMK K20w== X-Gm-Message-State: AC+VfDyC5k89oa7tmlVGAPooEEZDRlhHhojD8+AWy50JKQxHBJI7ytWY lZ4SNBaziGp2wm2n0K4um3PTIidNTVaxbSAkhs+s82h+/x9VD3TUwMA4998nIt9zpHN9TdblKUP eSdp4DcJqx30= X-Received: by 2002:a5d:40c4:0:b0:309:43a2:8e9f with SMTP id b4-20020a5d40c4000000b0030943a28e9fmr6809497wrq.27.1684745602915; Mon, 22 May 2023 01:53:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7KKCcdrWmgRwNWw4qSMirvKEhU5alle4r59vpIahQSImqVLM3az/jLZvgFtpdvVt36nC7Inw== X-Received: by 2002:a5d:40c4:0:b0:309:43a2:8e9f with SMTP id b4-20020a5d40c4000000b0030943a28e9fmr6809469wrq.27.1684745602626; Mon, 22 May 2023 01:53:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:c800:d74f:aec6:f8ac:558? (p200300cbc742c800d74faec6f8ac0558.dip0.t-ipconnect.de. [2003:cb:c742:c800:d74f:aec6:f8ac:558]) by smtp.gmail.com with ESMTPSA id b15-20020a5d4b8f000000b00306344eaebfsm7043661wrt.28.2023.05.22.01.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 01:53:22 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 10:53:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 2/5] kselftest: vm: Fix mdwe's mmap_FIXED test case To: Florent Revest , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com References: <20230517150321.2890206-1-revest@chromium.org> <20230517150321.2890206-3-revest@chromium.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230517150321.2890206-3-revest@chromium.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5FC2FA0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 81954quzdhrq67wka74r66sj3e3tisma X-HE-Tag: 1684745606-641367 X-HE-Meta: U2FsdGVkX18SNrmm8SWyajuWsH0q0vocZA0emwYEUpAQ4pdr04MqVLdAP1aHpUQbZXfmKOTUOpinx4C/VAUEiV0kUlnOHQ1lmf3dhPAcfNEILXpq035fVaCizXcagh8hoZAuRuLPOtqVCeGGdGBk9EgKLOBZi12TrNXreXge7gyEDfwknmJ5jV3zDFEHMxOtvuPxAi/hsHfVLCVOW+615prCl4KAy9dU6LXh9SORFFg+xd3dYR5adiOt4sYYnxMNsd8e7P/FB8EdJdTZSL4LZEt8Ek1l0JMeMRC80DSeZnVv9PfaiWW8JF7p3DGD3odQxhL/wXmQra++Jbbfkg9eX6LbkQL3vrwYDS7iE5RUjWlP5GfiEBmmACJm6xlTKfS+Xr/dv7S2dxzNR0DQxz4K62GkYY6a8ypIH15luLR4M5kgRWG/UYHeFNOiDM17+E8tOU80Sux3/OgAQWtJeoMlbW1f8CgB1Q5QKcZJxNjgTU0Wt40U8k6TFlzzup85kIURmHXqDEDpAoC69vWP4Aroi1RmUAbUBLqY3xVbkeD2ts2RSrKqe5/eHlOl8QcL7E36KAe64Cic9/k8Eg+c8UxtoLyMg2fnRviEJ/CuXGnCBCRdNgfhLvK+Y2G/HGKa+7ng9PmGDP9nTY8eZMXNm2lKCeSWbN2K9CwLcVkocoUZeslzwl8NmqM9nQy0uhcMajdYKcTqTnVtqnnl3z159WXOhFjcOb6w43lBsVjcf6wwqQU8HQ584D+A3QPszkZ0EJa78BtuChMSKNaiYsVh4foAXsyHhK15Si446U3fFUdZtY2hKg0xPainIaSeNtvWDlyfp/2L4hrJ7ibNF/iXzj3sZ3t1HvvlvT4Bg3P3/rKVaDfUqlMqfyDFcm5JyKAxPY6XF8mJNHtAMwLUB0zifTuBn5cXDxc1GYeR+ekuLQSFmrOSL1dxmMV0QOnua24+YkwLMvwvAbEKQHl5wkalTmg +zPh+o5q A2zWlcov7Ho6dJhU1cvJluhbd266zuYb/tHecbZFO9FYQh9o/djtcta2ny3Uhe/9k7dZX2M85RBD6wAb8fWbQReH6eU4Pm0tO994B5pAeZMhRgxwln++8WRj9wWk3WywMt1XXVsZ4CWBy+zkSai1mIgDnIYyjlD2/XnKlxRGsfBu3EqH6SiZMgnlLtMfSV3F/kih3dpQkp1RQzeldsgomMKnN/ERKTT1XKKcZH/hcpBn/IH7ZP4ueIbhgRviyt01xjlv0RP9lSAYhmweqN2mLbxjz6jdWuCKyAorFumxJ79cOzjoSh5sVkbT5mrGqCHSwdCo6bMZF+AOrowZoFzXBgntSJLfPwXMemW0eW+9FfzM5+USUJKKrdakxfH3wvdExAEUq6J1DcNQq5mtgeh7c90KQtoquaBLtb+x3P6YKPTVrLb1NJZKeKj/UEE79vGbwRomyIKwLLaWd5mQs/69dmkZeab6BzZHYbNM5xJ2TVyqfPoN3MkevAwEH2xElP4Z+kdW+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.05.23 17:03, Florent Revest wrote: > I checked with the original author, the mmap_FIXED test case wasn't > properly tested and fails. Currently, it maps two consecutive (non > overlapping) pages and expects the second mapping to be denied by MDWE > but these two pages have nothing to do with each other so MDWE is > actually out of the picture here. > > What the test actually intended to do was to remap a virtual address > using MAP_FIXED. However, this operation unmaps the existing mapping and > creates a new one so the va is backed by a new page and MDWE is again > out of the picture, all remappings should succeed. > > This patch keeps the test case to make it clear that this situation is > expected to work. > > Signed-off-by: Florent Revest > Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execute") > --- > tools/testing/selftests/mm/mdwe_test.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mm/mdwe_test.c b/tools/testing/selftests/mm/mdwe_test.c > index d0954c657feb..91aa9c3099e7 100644 > --- a/tools/testing/selftests/mm/mdwe_test.c > +++ b/tools/testing/selftests/mm/mdwe_test.c > @@ -168,13 +168,10 @@ TEST_F(mdwe, mmap_FIXED) > self->p = mmap(NULL, self->size, PROT_READ, self->flags, 0, 0); > ASSERT_NE(self->p, MAP_FAILED); > > - p = mmap(self->p + self->size, self->size, PROT_READ | PROT_EXEC, > + /* MAP_FIXED unmaps the existing page before mapping which is allowed */ > + p = mmap(self->p, self->size, PROT_READ | PROT_EXEC, > self->flags | MAP_FIXED, 0, 0); > - if (variant->enabled) { > - EXPECT_EQ(p, MAP_FAILED); > - } else { > - EXPECT_EQ(p, self->p); > - } > + EXPECT_EQ(p, self->p); > } > > TEST_F(mdwe, arm64_BTI) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb