From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A434EC433EF for ; Mon, 24 Jan 2022 18:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C7C96B0092; Mon, 24 Jan 2022 13:20:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3779E6B00A3; Mon, 24 Jan 2022 13:20:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28DC86B00A4; Mon, 24 Jan 2022 13:20:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 1B3C36B0092 for ; Mon, 24 Jan 2022 13:20:24 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE363944FA for ; Mon, 24 Jan 2022 18:20:23 +0000 (UTC) X-FDA: 79065995526.30.7F70AFC Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 85AB920006 for ; Mon, 24 Jan 2022 18:20:23 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id v74so13535788pfc.1 for ; Mon, 24 Jan 2022 10:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=dD7dOLXb+YQYq589HrH7forsalWY8+LJ4rBHpm/SHRw=; b=gRTdqJHKCLMkSZ3bmFhgUlfkqnsGok83Bdw5ohbB+I4EGKL6koKg7mnrTsh5YuMBLa GKVPoF7oCPhLtG/voaI0hrXtEDgvwdvX9ISnG4Co2a5itSLEAKDL4E6DmN8zOpsfwmNq c+RR9Pzr/NoDUNdSUiTg3T+GaucTB45uBXKpK7LHeRF2sDhEkjwk6UcdD4kB4221HScc V1Sfw3DzXLotVi01fh06jyDfTnUzIJ9DmoO/4r7Gh0MvqQx3wsDe7Mw9xj1KK9JEqhsB GH9cThxBfs6YAdrp63S8R3uwKE4MIutDdJa0hJSb5kYB7fuNcyX7gcbggWsNZgCM8AH2 n/Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=dD7dOLXb+YQYq589HrH7forsalWY8+LJ4rBHpm/SHRw=; b=U4gUeVvumbuuv8pK2HjjqCgZHxYLqzDfoNGbpSQLmCthUD3po4O8tWHbjnuaBjm6Ze KtWBILEB64tVFHtZOPG9VjNEosQTv13+dnlkvaKzzy8SC7nCMX6C5wwwJkk1N7Vb2g0M A/t4zDsfgdv5+8EFkW1KGnAhj/4qldIsCTmnMaPYqLU5W64L+YLWmcDpZK3P6fHuLYvz Kw9PY6SEmedtG8aHT3b8y+y6zmTSHZ87HOwmCh0gZAhGT/czZX97DDNWy2nkghmnYRKX gPX9EhBJilMNbrFcJ8aBynl65+tIdPCpfuJIBxXbxqD+k7BK+roJ5cgtdu74ZVp8V1lt ZraA== X-Gm-Message-State: AOAM5309b5v7XJw1eWkViNPyjQIuTI8QFWmo+GpjAX9YeWcZD6MEC+Ur wSiQAsM3Wbl+Mvjr9tU/PkqwLQ== X-Google-Smtp-Source: ABdhPJwLIGzTlfukShqfyFMX/Z6h5Q8RTwu9HHBQUuZApv0356SMbN+8i8h6wUvDuRXC5+uOphr6QQ== X-Received: by 2002:a63:ea51:: with SMTP id l17mr6080241pgk.450.1643048421931; Mon, 24 Jan 2022 10:20:21 -0800 (PST) Received: from [2620:15c:29:204:1f99:bd65:fcbb:146c] ([2620:15c:29:204:1f99:bd65:fcbb:146c]) by smtp.gmail.com with ESMTPSA id x12sm12678911pge.58.2022.01.24.10.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 10:20:21 -0800 (PST) Date: Mon, 24 Jan 2022 10:20:20 -0800 (PST) From: David Rientjes To: Baolin Wang cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation In-Reply-To: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com> Message-ID: References: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 85AB920006 X-Stat-Signature: wkc8q1oatwphk8eyddgbd983q157cz8o Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gRTdqJHK; spf=pass (imf03.hostedemail.com: domain of rientjes@google.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-HE-Tag: 1643048423-779185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Jan 2022, Baolin Wang wrote: > It will never get a NULL page by pte_page() as discussed in thread [1], > thus remove the redundant page validation to fix below Smatch static > checker warning. > > mm/damon/vaddr.c:405 damon_hugetlb_mkold() > warn: 'page' can't be NULL. > > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/ > > Reported-by: Dan Carpenter > Signed-off-by: Baolin Wang > Reviewed-by: SeongJae Park Acked-by: David Rientjes