From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575BAC433EF for ; Mon, 25 Apr 2022 13:39:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5AE66B0075; Mon, 25 Apr 2022 09:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E09106B0078; Mon, 25 Apr 2022 09:39:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD1A16B007B; Mon, 25 Apr 2022 09:39:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id BFAAD6B0075 for ; Mon, 25 Apr 2022 09:39:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 96CF41216E5 for ; Mon, 25 Apr 2022 13:39:18 +0000 (UTC) X-FDA: 79395507996.24.5264E3C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 71AB840043 for ; Mon, 25 Apr 2022 13:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650893957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pm+NNZ/YV7VS9Z5vMhYXE2vlZstaKvSFd8SQzWKhXa4=; b=Xz6xcl74RfZsQe2JF6DB2j7ar3GPrS7nJ8kpcsC1g84RG6AGBRvB1ugkgpLcnOv2gVySny OI6MZOejfl3ppwvGIsr0F470sFVF0SHAN5n0cPnlFBcXI0mYyfu7aP+3eimREgJPYHhrGT bwBzsmDJd5zFWqEuQkt0w4mmdLvy7II= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-195-ndbWvFQwMHKtrFscTo1l3A-1; Mon, 25 Apr 2022 09:39:16 -0400 X-MC-Unique: ndbWvFQwMHKtrFscTo1l3A-1 Received: by mail-wr1-f71.google.com with SMTP id b10-20020adfc74a000000b0020ab029d5edso3370640wrh.18 for ; Mon, 25 Apr 2022 06:39:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=pm+NNZ/YV7VS9Z5vMhYXE2vlZstaKvSFd8SQzWKhXa4=; b=RURZSue3aEF7+QYMorq/PaibdjyCo7r6dksl07uLEVIm9cL2OcB64czDaqDk0AWicI 8b/ZYYha+0HOzMONa9El2l8AP/ldiKjXXjIrYTttiZCh6/hiTjOdImKQC3Nzc0A1ggJ3 lj5/2GDzYQxkBrL4eBC6U9YicTfc0VRU0b+YsRPBPgRRjPUttaPwPooV0baeeT+2I/tE g3GVDbK2+Rr3ix8HoxWw3cSlog7FGk82XlFr30j7JlyaSZ8+2rWBkI+lKyirPIsnlf4h UkwQA6Uqx+K00HQc71zj7T/0wEpo0hSl+NWmMzKP/+Z0vM9Id7R723NK1jc/yFLDNfXK 1rNA== X-Gm-Message-State: AOAM530EFrfFHjcAo9gHtHDvBRE+G687aFSbA/4nC68by0q2er9uefNP vHr8QSXvFjY69syCEYxUKX4icWwRrw7YIEnLMgnJTCm2rlKj6ijSEmuV/rrE1d8kc9r5g4jeInq EkjEE6U+6vR8= X-Received: by 2002:a05:600c:b54:b0:390:82ee:e15b with SMTP id k20-20020a05600c0b5400b0039082eee15bmr16338576wmr.17.1650893955014; Mon, 25 Apr 2022 06:39:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyVm6uYzjDLqJQlFa/Cd3V5cm8Gl9fxAcUxr6d7iLSE7Dfvnf9RSY0cKHsP9GHjWUFipXAsg== X-Received: by 2002:a05:600c:b54:b0:390:82ee:e15b with SMTP id k20-20020a05600c0b5400b0039082eee15bmr16338550wmr.17.1650893954706; Mon, 25 Apr 2022 06:39:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:490d:ed6a:8b22:223a? (p200300cbc700fc00490ded6a8b22223a.dip0.t-ipconnect.de. [2003:cb:c700:fc00:490d:ed6a:8b22:223a]) by smtp.gmail.com with ESMTPSA id q16-20020adff950000000b00205aa05fa03sm8733178wrr.58.2022.04.25.06.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 06:39:14 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 15:39:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 2/5] memblock tests: update style of comments for memblock_reserve_*() functions To: Rebecca Mckeever , outreachy@lists.linux.dev Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <7e21d96491ed573f1f7823cfe56c4d8ced4f78fe.1650633253.git.remckee0@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <7e21d96491ed573f1f7823cfe56c4d8ced4f78fe.1650633253.git.remckee0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 71AB840043 X-Stat-Signature: cjahaj6k3mf6bupcbbnttzhtw9y3uuzn X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xz6xcl74; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1650893956-945649 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.04.22 15:32, Rebecca Mckeever wrote: > Update comments in memblock_reserve_*() functions to match the style used > in tests/alloc_*.c by rewording to make the expected outcome more apparent > and, if more than one memblock is involved, adding a visual of the > memory blocks. > > If the comment has an extra column of spaces, remove the extra space at > the beginning of each line for consistency and to conform to Linux kernel > coding style. > > Signed-off-by: Rebecca Mckeever > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb