From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF0AC32772 for ; Tue, 23 Aug 2022 09:50:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B21D8D0002; Tue, 23 Aug 2022 05:50:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5393F8D0001; Tue, 23 Aug 2022 05:50:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B39C8D0002; Tue, 23 Aug 2022 05:50:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 275B98D0001 for ; Tue, 23 Aug 2022 05:50:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E956C12020D for ; Tue, 23 Aug 2022 09:50:50 +0000 (UTC) X-FDA: 79830388260.28.9F5666E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 9EA264003F for ; Tue, 23 Aug 2022 09:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661248250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KHenf9Y4DFpeTcrsigI5eYZv5fPQCg/1pJFHFFXrAkY=; b=g85bE8Oqkv8Elzkw8khKH6A+AOwmTaAKKSoTSnNw8FvDP04e6QEDtGZvsthRL4L6Q+oZ6f +EHEYs2iAZip0y4Pezq/+fr1FHhw4UkqsUBMZdvMu2fd39hTFRFv450WKsMEBxE2OLLLLr wR/FP4FimKjcc+74qEcZY2skucUpAio= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-518-lCC_8C7kORag_lbKNKPTFA-1; Tue, 23 Aug 2022 05:50:41 -0400 X-MC-Unique: lCC_8C7kORag_lbKNKPTFA-1 Received: by mail-wm1-f72.google.com with SMTP id az42-20020a05600c602a00b003a552086ba9so9999150wmb.6 for ; Tue, 23 Aug 2022 02:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=KHenf9Y4DFpeTcrsigI5eYZv5fPQCg/1pJFHFFXrAkY=; b=lU4OitGZP+65YNfdklEIwf3KRjwe0QInE8n8Y/k9507rrcikpfZx+7+gp0xK/1THCJ 345Tzp3IIb9VAiBCkXs5FjGeeBrGzZWVaZDM62hk3CHTs3TfIcpXNY7SBu8/+UREn921 GVmhx233CcZ2FZS7cQ41jtR8jVLnjdT0WQfK0JzNi7tdt1KoFouoAC0/ZyCugy8vH80t 11GIfvTXBhqp2UYDDOAnuF5I2Hk3QDdxwKo0MF3VkJOz6+sROgJadx+J25lEgOQ8zYR6 EAawyEH1I640Zqb9tOXS7jUyrP862Gs6U9sIHYfOqImLaIcRulwXYn9M0PaIDMG36+wf hQ2A== X-Gm-Message-State: ACgBeo1vtMTD34SQ8wVBTe4h/BKccapvM+drVeAT7y0A1VGYwxSD9kFd eHNaE9+f9a8Ji2DS+A+oSBJMPGauOBE+gmDrv7GJ34SCZwJqIX8yCngdahibBIHP12ZXU783Vf0 afDUy7jiBEdg= X-Received: by 2002:a7b:c016:0:b0:3a5:fff2:62f4 with SMTP id c22-20020a7bc016000000b003a5fff262f4mr1677684wmb.104.1661248240091; Tue, 23 Aug 2022 02:50:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR50PAvQXqub9ePpZCra5XYmWO1KHAJO9QPff/hyZeepdtYN+uUftogOYxzz/L7mAEPT4to1aQ== X-Received: by 2002:a7b:c016:0:b0:3a5:fff2:62f4 with SMTP id c22-20020a7bc016000000b003a5fff262f4mr1677677wmb.104.1661248239837; Tue, 23 Aug 2022 02:50:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id c9-20020a05600c100900b003a2f6367049sm16580098wmc.48.2022.08.23.02.50.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 02:50:39 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 11:50:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 6/8] memblock tests: update alloc_nid_api to test memblock_alloc_try_nid_raw To: Rebecca Mckeever , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g85bE8Oq; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661248250; a=rsa-sha256; cv=none; b=AScndkOPbjTCTuOs6DlmHW5uA03Q6VHlOJAuGPAgZIBzgQSWyQGaw1uglo23IfOEhmgnas i2PL5JlY7Ce2ohGvHXlA550lbEitslFAw3xst6ldpf2arpLfZi5/+lvPpxqoQygiYjn9RN pIx0MmXb3f4X2iLt+FbMWdpkjsyQ5pc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661248250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHenf9Y4DFpeTcrsigI5eYZv5fPQCg/1pJFHFFXrAkY=; b=lmtLAb79HxzgwOGqIKeReMzLGmQZEpxEpXgMz98KpuQp/avxKsMEVPV2R/KfWnnf2JPwLD RidwfCBYgn78FCe6wCBgNTREXn+rTujzWoVtuETEtSbr+6HljDgDt79kncx5u3fOawjhNf AP0KEo1RwZHs7ycSwpR+piyqP9Rzky0= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g85bE8Oq; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: xen9cy6hszfhriw46t48dxk7y9dt39mc X-Rspamd-Queue-Id: 9EA264003F X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1661248250-503497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.08.22 10:34, Rebecca Mckeever wrote: > Update memblock_alloc_try_nid() tests so that they test either > memblock_alloc_try_nid() or memblock_alloc_try_nid_raw() depending on the > value of alloc_nid_test_flags. Run through all the existing tests in > alloc_nid_api twice: once for memblock_alloc_try_nid() and once for > memblock_alloc_try_nid_raw(). > > When the tests run memblock_alloc_try_nid(), they test that the entire > memory region is zero. When the tests run memblock_alloc_try_nid_raw(), > they test that the entire memory region is nonzero. > > Signed-off-by: Rebecca Mckeever > --- > tools/testing/memblock/tests/alloc_nid_api.c | 188 ++++++++++++------- > 1 file changed, 119 insertions(+), 69 deletions(-) > > diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c > index 82fa8ea36320..2c1d5035e057 100644 > --- a/tools/testing/memblock/tests/alloc_nid_api.c > +++ b/tools/testing/memblock/tests/alloc_nid_api.c > @@ -1,6 +1,34 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > #include "alloc_nid_api.h" > > +static const char * const func_testing[] = { > + "memblock_alloc_try_nid", > + "memblock_alloc_try_nid_raw" > +}; > + > +static int alloc_nid_test_flags = TEST_ZEROED; > + > +static inline const char * const get_func_testing(int flags) > +{ > + if (flags & TEST_RAW) > + return func_testing[1]; > + else > + return func_testing[0]; > +} Same comments as for patch #5. Otherwise looks good. -- Thanks, David / dhildenb