From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5064FC3ABC9 for ; Fri, 9 May 2025 21:46:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400CA6B0100; Fri, 9 May 2025 17:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AE4F6B0101; Fri, 9 May 2025 17:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 277CB6B0102; Fri, 9 May 2025 17:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0AA786B0100 for ; Fri, 9 May 2025 17:46:43 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A6D2112089E for ; Fri, 9 May 2025 21:46:42 +0000 (UTC) X-FDA: 83424704244.05.1E2BF6E Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 96DBA1C000D for ; Fri, 9 May 2025 21:46:40 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XPMWJjVa; spf=pass (imf18.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746827200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/F7PRAcYypRqCE5vWOKYPdmOF+xTqopC6yWc1PsmpSw=; b=SMPfN1JBFjLUpecP5iTLsGyMJOW/Ue0zf8hPnUqYLt+YWTyhGgxfio6lgwUvSkhmlz1ktL v7ntYEsnt92LQnaF/2zEke+Os8v24b21UyDrX0DweksYerGeQL+S5XC/PRi162Gskdn33d 4YCO+UUgwCCEPaVSyacTaZ1FyA6qk8o= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XPMWJjVa; spf=pass (imf18.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746827200; a=rsa-sha256; cv=none; b=3xq1wbt5O2Y/vQAwW3hPaZjfT4tKd7RZ1gQmKALzK32rc+9nBS5Rk3uy/eTVDbcfBB9vev lwjGXqjEJboHJN/zbnXJ6R31bjNOADjyXkym86PGaaJ8VYilMLGsYETcAnBTv1cGHhhujs zU0QaPzCEGKxydqxZkhc8x5KKzOxxIg= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-22e7eff58a0so25534345ad.3 for ; Fri, 09 May 2025 14:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746827196; x=1747431996; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/F7PRAcYypRqCE5vWOKYPdmOF+xTqopC6yWc1PsmpSw=; b=XPMWJjVacO9TgNye568pvaDJgNe2JnBzFEv25n8qtYnXMaVuVKy3B1iCUmR6GH3nNN vQKHjzg7+CsVncL7IpCqcdzWVZiJ2xuhm+vwN2eDIU2scCmVZ35NNV9txoWzkuHMrcOU eugW6xjwCkEWBjMZ9gIiFW9T7q3QodiyiEmVaDwDOpa8T4ou1w3VfzLFdFEFd5SkS9ml spZdSFhYNUr5enY65Q0B7KE6MOxXqMhY9pJJDHJh4aHmGpp8El3+SoRyNmLl4+QSyT/K dax4nalIn8Iuh4FT+i7tj1//KkTU7zlmOFtxSndFYGEo0WiKrT3pFs99ePAStMQ2S02U fHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746827196; x=1747431996; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/F7PRAcYypRqCE5vWOKYPdmOF+xTqopC6yWc1PsmpSw=; b=HSdj72igCY0HscS5tO2P84kF7ouVkZDLn+qepKgeJA5uuXGskfUgrCYx0RnpTyiIMW ++8IXlrpBMOErx1U1c+Kfd0CS6WkPJtwi1h4i/y5MpnsMjrOJwTr9QXUeu21bbi/XN80 XepiDQBgvaFnr0gJ5s2tH8IXm/IEi9Mmzmtsjj8hu+Gd2TZ7IFH3KpqyqYK08VCj8oXr 5r6iAgUZAqteGRtEXuvXoiAwfml4NmeylWSBrzqeRI6DckN4ww7PAqKUGvWRh020vfRg uBE3FgXJn+P0LXAoKdl5EKkd4DzQTq0kUavmgWzN6ySQY1qBJgM5G+SOqiiFzdSV/66o vPbA== X-Forwarded-Encrypted: i=1; AJvYcCXHZY2rb34bk0TWiVDEiTCSVoiPXWgTPpvx3y2XooCP415wucRidH6JmfjZXG+qAocj6J3JFdc4yQ==@kvack.org X-Gm-Message-State: AOJu0Yw270yKonXE4XMsna3cKrzYOtmJKtAGhXjXePseQIr928MdM/1v fnFYUqLBOmm8Y+dDhjJnbkx2fzL7X/FRMbOIslhzNJD8d3I0dL1W X-Gm-Gg: ASbGnct3TQ6QB89XRDS3rvQ0Fc2QXLaKhjCQowsX1cUOi3MUPE8FfSGNvYn/OEoPt+r 0IM46HRdvHxQRLxUqp2zHhnQcdvB/wZNSJhavmqpId8O795Pf2bzwnLxXieTsBGM2/AIUKaqE86 lZpLiwKd7e5utLZkTkgtC+IiQwmT4f2fzXtpKkfMoG7JUnyuXI3uBX+PRBL9JmsnqT35O6qsI7l U3JNvgDoinAwwSPeOKJ8NlqfHZe6MfXuCiOutxFynz0w45KkVbxrVBJ1ZKwuuorNaGsevd8buLL gG/XPG35j5aZvAX43Tfk8qa3gT0yWmMKCoKReSp7kJ1Pm+49x7lQ07yZ037V65cw0t5/tSsdUX5 F/QQwG1+dMmeJZBQr6w7Brg== X-Google-Smtp-Source: AGHT+IG9zQnokJXuA9u2+tJVGClPHs1sd6/yMcCMRzhZicwzP8I807ASKe19trZfZR0/nmAOsP8riw== X-Received: by 2002:a17:903:2351:b0:223:2cae:4a96 with SMTP id d9443c01a7336-22fc918c11emr67459935ad.42.1746827196094; Fri, 09 May 2025 14:46:36 -0700 (PDT) Received: from [192.168.2.117] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30c441aa492sm944385a91.1.2025.05.09.14.46.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 14:46:35 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 14:46:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/5] cgroup: use helper for distingushing css in callbacks To: Yosry Ahmed Cc: tj@kernel.org, shakeel.butt@linux.dev, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250503001222.146355-1-inwardvessel@gmail.com> <20250503001222.146355-2-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 96DBA1C000D X-Rspamd-Server: rspam09 X-Stat-Signature: 1o3es33byjpo6ej45adxcugu9jhezcdn X-HE-Tag: 1746827200-747711 X-HE-Meta: U2FsdGVkX1/fQ5yMAeWgu7ArCUe3TyUMRXNLATW3hRrm/TMt+a6vq5thD1nZr3opmTdiJKzVigFP8ICQ8a603nnARW8cP+Xt1dcNXPXSvGUsijz/PEi6/s8nE9W8snKVFXKu/na/m8cGV9C7WVRyNeBKY6rZbdGfeIr1D0XbrHmmiop8xGWf4H4z7i//MX2i0EbIO4uiKnmDYlrL/ToBkpkKSySOlr6cJAh8ZcSQ0x3Tv0lfGHm8KrkUamZTlVz4yxq8d837uLZpOLiNMWMLu8A2WcoV0v+OKe9+t9ja2ptKmjNZaDvscSsYDmAHRzSmjCYsK+CfVY6D2oQA5YcRDh6t2oxn0R0ysm1a0VwvYU/hbWuqskOqbfTsebauOK56HKgrWHygUabi7EeUKtuObDIKNKwEX230/f9EoeqXh1mcJH14gY9Iu3wjh3midafIdjbFIz68vakTiDv/hC6HjXoIhnzPYYRo/WgqwdQcZZFTFe9IWS0eOurD3LYzpS0Yk58aZVDutfPQX2UGXD2LkxI/ZZQ1c4hRbkS6DnoIWIr9MpON0LD1P+vOQ/GOtQU1hXkQSUiLIJsvoNtBMjypKOHXz+M8cbQR27sJ0fGouc8l2e2zGHf4iulRZqUZCu43Buuu9IQPw5OPXEfWf4bsuuUQTsvJNUKndbGFmo6JfIkXK3+VHzhcZrdCktg2gZV+B5ldhM6jVORtdzQBVbMCXsX7fiAdb+exWdKfkOwTYJTH0NObR7QVa/0df3WN/teIm0L664DUlXkqoIaEOvRnTLxRM0HudLuplrFBJwWrScAmtcVIljCdOQ1qqCl4rzC+qBGDarTlc4jmtvzI0QRtlPfzLbecfh12AmS4CYkrqv6pzSlhjO2o9gsn1PE4xCdi8fG2A6QlGs5c4DDPlzWFg5C6L8IGJOFEZ0gqkvrghbU7tyLhWr54Pd7rgr0wI/ak+BdaHMFRk3fGpI2HkJ0 LZeH5CT3 +d9Yx7DOy8hstjc5Le0Qllm/bIMMH9HnaGl2OprMrVkiQFuLpOR2kzNYTfTo0/vyFb/K7heOOgvK60BAkpmVc/L0zwcSCpDWX0tvXZ3ezrxn1ofBihZ8Gtj78l9w5AAL1iM4EvCffaLHgMuNxo18iKG54VZUfDPqtBoZlbpDRHCdRpfgND8BKsf08rlDl0USOEO2onuqekBMSYdmL4DusB7KKKkQEQ6/rBSCDTc35kBXCwr6rlTC1jVu7IL9dRO4ltS00ekDONqP8dbuoIR7omMXHWPoVUnLYUza1W5UDq4mbiVtCiuFe5qLe8cMScAeQ6sUeDzT0r5KrqM/nRdKq5X4vZu9GlGbTgkNP7MTOgJEQafvNE0kQ2hecPVp5HaO6e+M6TLk3xsdGNmF0yOGiZ7tOuDmdZ51dXCQ2lwiWxNvqJwB/6TlBbJQV5Os7h7j5MrFP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/7/25 2:02 AM, Yosry Ahmed wrote: > On Fri, May 02, 2025 at 05:12:18PM -0700, JP Kobryn wrote: >> The callbacks used for cleaning up css's check whether the css is >> associated with a subsystem or not. Instead of just checking the ss >> pointer, use the helper functions to better show the intention. >> >> Signed-off-by: JP Kobryn > > I still think this should be renamed and potentially reimplemented to > (also?) check css->cgroup->self, but anyway: I'll make that impl change and rename within this patch next rev.