From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F9EBC433E0 for ; Fri, 26 Feb 2021 10:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E6E564EEE for ; Fri, 26 Feb 2021 10:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E6E564EEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DAD9A6B0005; Fri, 26 Feb 2021 05:52:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D36B26B0006; Fri, 26 Feb 2021 05:52:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26756B006C; Fri, 26 Feb 2021 05:52:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id A852F6B0005 for ; Fri, 26 Feb 2021 05:52:06 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 72AFF812C for ; Fri, 26 Feb 2021 10:52:06 +0000 (UTC) X-FDA: 77860104252.15.14CE763 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP id 9BCEE90009D6 for ; Fri, 26 Feb 2021 10:52:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8D802AE72; Fri, 26 Feb 2021 10:52:04 +0000 (UTC) Subject: Re: [PATCH v2 0/3] trim the uses of compound_head() To: Yu Zhao , akpm@linux-foundation.org, alex.shi@linux.alibaba.com, willy@infradead.org Cc: guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com, "Kirill A. Shutemov" References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> From: Vlastimil Babka Message-ID: Date: Fri, 26 Feb 2021 11:52:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226091718.2927291-1-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9BCEE90009D6 X-Stat-Signature: mzq5xiugef48fmzqwp7457ckerrpeqwh Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614336721-631810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/26/21 10:17 AM, Yu Zhao wrote: > Patch series "mm: lru related cleanups" starting at commit 42895ea73bcd > ("mm/vmscan.c: use add_page_to_lru_list()") bloated vmlinux by 1777 > bytes, according to: > https://lore.kernel.org/linux-mm/85b3e8f2-5982-3329-c20d-cf062b8da71e@suse.cz/ Huh, I thought Andrew didn't want to send it for 5.12: https://lore.kernel.org/linux-mm/20210223145011.0181eed96ab0091a493b51f6@linux-foundation.org/ > It turned out many places inline Page{Active,Unevictable} which in > turn include compound_head(). > > From the v1: > Removing compound_head() entirely from Page{Active,Unevictable} may > not be the best option (for the moment) because there may be other > cases that need compound_head(). > > In addition to picking a couple pieces of low-hanging fruit, this v2 > removes compound_head() completely from Page{Active,Unevictable}. > > bloat-o-meter result before and after the series: > add/remove: 0/0 grow/shrink: 6/92 up/down: 697/-7656 (-6959) Good that you found a way to more than undo the bloat then. But we need to be careful so bugs are not introduced due to pressure to not have bloated 5.12. IIRC Kirill introduced these macros so I'm CCing him. > Yu Zhao (3): > mm: bypass compound_head() for PF_NO_TAIL when enforce=1 > mm: use PF_NO_TAIL for PG_lru > mm: use PF_ONLY_HEAD for PG_active and PG_unevictable > > fs/proc/task_mmu.c | 3 ++- > include/linux/page-flags.h | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 9 deletions(-) >