From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B708C369C2 for ; Tue, 22 Apr 2025 09:01:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BA856B0008; Tue, 22 Apr 2025 05:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 242016B000A; Tue, 22 Apr 2025 05:00:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 096E86B0010; Tue, 22 Apr 2025 05:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E0CE16B0008 for ; Tue, 22 Apr 2025 05:00:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EA8441A1B43 for ; Tue, 22 Apr 2025 09:00:59 +0000 (UTC) X-FDA: 83361085038.03.0AC979D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 8091FC000B for ; Tue, 22 Apr 2025 09:00:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PuhXpwFg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745312457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PeC8CoS72COYtWeIJb6KnHGY+h/RmMzZnwToU8D/UBI=; b=08PIEmtrxViwLJvvLP01V9RjO9a5bXBZa6s/pFWoJ3yDsttYBxqkIUhQP9Tal3U2bS2Mp0 MZHgMwuesiIdvcGKOFGUExy/L7sPB3JSOH31MVzkFgvBRU3u1PyVHzffuj7uPk+SZ5ZeT4 l+20U6IOHIZ09uJ0LFEW2gqIW2kybtY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745312457; a=rsa-sha256; cv=none; b=FkqZOCVnG3Mmfpf81+aC6qH6NuZrP9qhejzr6fAvFvin/wvwjgwpuDZ8XGAQhplHEI0hQg aWgQbdHOJBjITQazM7cHKoUA3Opz14UnNk6o7tGLC8VdsIqeU9/3M70g5QnaZCly0AXYc/ rjhqM+TF0ZqjLHFmJFoq8qOtl97gnr4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PuhXpwFg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745312456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PeC8CoS72COYtWeIJb6KnHGY+h/RmMzZnwToU8D/UBI=; b=PuhXpwFgQwO0mBjjazVn8y/9ktbFfQgiAv6KP1QZHFB1SLxifqBo3lM+yAZZLvWPEDCurp z1x4NF+lg0I+eqc9uvfg0CRdeLaJAij+4Ipm+8JzNBQscCqaDnqk4Jem+aWBH8AopvTtfM d+Tbw8IHPJs80jD1nmfw0r7EP1pgJik= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-le7rmaqKPRGmBqKvIe5nzA-1; Tue, 22 Apr 2025 05:00:53 -0400 X-MC-Unique: le7rmaqKPRGmBqKvIe5nzA-1 X-Mimecast-MFC-AGG-ID: le7rmaqKPRGmBqKvIe5nzA_1745312452 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3913aaf1e32so2186270f8f.0 for ; Tue, 22 Apr 2025 02:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745312452; x=1745917252; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PeC8CoS72COYtWeIJb6KnHGY+h/RmMzZnwToU8D/UBI=; b=Dh268peve8RygvMjuN5ANDm/z7EnDRZPC7jLfjsMF5buiDh0lLXbL6prEyX+bP0A2D 0ywGscWRCzNfsMloNLdrL/AhZyMCb3/mWyudn9TKXv7jCA/GB8GqnNhEKk7tTVGJWjXv F2tyIgUPFM2Wg/LZcp2R/LIVLdCLXfazVbw8ypejJtGVzwq4F/xupCBpJUuxraI9it6C zO+KIlV7jLdbawgcKl2Ry1n9Yy7rPuBGmN8MDh1Y5XN3aO8gmaXRGUQ+T2dN0RA5JbEl 5Brs6nkELWDQrXLNdL4HjaPhGJwj6vNnMbdN/S0bRquGQVxNRSzhM5KEwbeXQtoHPDzs wfRA== X-Forwarded-Encrypted: i=1; AJvYcCWabObN4DkWUPpWS5wiMMxAzieeYv0lvtnTbPq0CArD2BoA6vYpNlGlERvOTLzRmA1JK+BaAwRSdA==@kvack.org X-Gm-Message-State: AOJu0YygHUAhsIicWdiL3j5mVvar2YcvBM5MOATAtOCpqoNbopxUBjex 1ThkWR27GoyitoyZbIcu/4QQ8M1xgtAmK4JKdrCB3dWta+cFsP6om8omy3kM+6+o++MTkvpUsZi iT4N25YwhiV3PtZyx6f2WONeho5GzKu+HFvuCPu3hs+RuoCDg X-Gm-Gg: ASbGncvcg5TqdJm131OeyeBapnxZ0abPMXFrmwF0qCTdnzqntx6LGPxMtGRCbeRoBqK UCne/adf03BUtIfg++VvV3tOXBG0w0X/owzNbFMdPAtctVerB9C+JfUkzbvIqThjrfqsS+tTafR TNXO8FjU5xIiDCBg1NuFGbGp17TJJtfv5zNx6eaEsNd4K2cG6C05MtV9CcDnEkd7nIDd6nEGkMY Je+VGiktgeFtN0dMf8JDY+45jZPidNWjZoGeilq3LdYK0vsrszpgB5I6NRO4sWwelikkSbXNGZI fBnSmAk8b/n/YvScRuXUOYraLlzw9rrlzsxxOdDuwCL+l6JLD7UzrzvKWnABExNh6CMm1mUlBqS ANTifmBsAld97npXUJJj0h2xAwOgruzlv3XI4 X-Received: by 2002:a5d:584b:0:b0:394:ef93:9afc with SMTP id ffacd0b85a97d-39efba4610emr10341253f8f.18.1745312451897; Tue, 22 Apr 2025 02:00:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB9+04DDmg62/UadGEweF39yPC0h3QHPDKpufaBrVoV0pf3PXmlVUQRRp2IV+QGXxeigl/cQ== X-Received: by 2002:a5d:584b:0:b0:394:ef93:9afc with SMTP id ffacd0b85a97d-39efba4610emr10341214f8f.18.1745312451510; Tue, 22 Apr 2025 02:00:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43bf20sm14251519f8f.48.2025.04.22.02.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 02:00:51 -0700 (PDT) Message-ID: Date: Tue, 22 Apr 2025 11:00:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-5-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250418170834.248318-5-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: shCKwtS2rdf_fHorP_8mJhvUk263PSxqb-TJB5LUpqI_1745312452 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8091FC000B X-Rspam-User: X-Stat-Signature: wmmn6hfrqhcntx75c1uejuc9i9b3w89g X-HE-Tag: 1745312457-267671 X-HE-Meta: U2FsdGVkX1/IulCKAOkPIKFiXtB9pM5ESnwkQlPvgLksGGXfQc7tg4NJqWwVjuIt7R+pUeFDPxx3vgSvKExU4/3mqOrKl+IV6ukUKLeR4Sv0KhjH9R/3jB5NNQK/weAJ5MJut5tiQwGQcjDlxPIa9rI6jWm7QxlCKtFBOSwNTbJBMhrr8+xUWp3EP3n29d1/l4LhNENkT09iki1N50OT6FHaa4blB20w4EPUjDiM7rnq8QbMASretsnNpzwCPPqcwcowHEaQyqXs5rk4YJUDmGCA55B5AWqRwom8NyamUA7ZgPHr+kEurYUhivS1hAR8ho573gI7PUvCU+iJAMeYVSr6nPBPG3A3jq8K1ptHaZNF2z2AdNc4KqZ7EcDarhlAwDiDp/HBUjaedkD+1EnSv40rN2ufQhJlfO2HWI6hrzCadjtkqyJ0fAXLXt42XtFv6CACrcCuAWZJzI44ZkpP9T3898s0WB/Fb/12cH052d9l/30m6u5KezgR26xoPsvhtHtp6JEHgx+c7WAPl9EzEuDK9y2gjXGOQBZli9Da/HcB2NkiXcQEO2irnFwDzH+VNrzt71j2hPp33MpjuoaDtH197ult26sfe/8q9bLWl8lBfrj5/Eq7gi/WawErhZS+6eHZuXWfPJZiVPL8MOgS+tftYfigv11JoFlJta0pQQPtPo2YXgdbgdLv5s4qcRJBozYn3wtCw+/odkG+7yXgon/T2XLrYLv10Fdhavjt0GfTBu0MDAMh+gPxmPrNrJuwvOMC86173TK/JVdqZOz3oHP7indLeFTc4AU8UEhS5J2bfrrCYLe69ASxJDiL1Ltj6p13EIhTGz6zJ2EAYfy/7sIVc52gX75YAtL4zNQw1i5Nl/FGdQko/8WqSLXV9sKeRLu1SoCVTjuWiymFNb28xZpYy19WPwtqEapkNx1Ujhcra5iKjaB2HD4eFpfrWn9tN/ZZq4xJ2w3n56A2ewX HoAdOmJR m8ztSb+DV5FZiGn4wccd5FVks/WO0h4VtYjlxIoSuMVVr99zII+pZvzPlS7Q40ncTZwY4tvt+DPta1Xh3KikMcmCRYJ0swEN20v+X2IFaEUFg7oaJOvDounR8C3PJyAmjpitc7v9Teg0IJ21DyZ1a0h2KTq/xDzdgVQ+iK8+bHRb6c0LzMAsjik+O3halmIqBPGkuwldcJY0sPdn+v2XX1rxCGaE27JeVFe4IgkToiO4jCoTvyHB5XxnlttFNDANgqEJiDh02lrnH83+pTILdrMmI/aJLiSDv7J/G0by8WUkBP4rYjRThaAT67r3tW2N2PI0C2pTfzJ5J/hXW+wSo0phva8LuaxbABr/M1OD+KD0ItTG93QlNJ7zBvDsNKGsFkMqi4JrgtUONTEAhJqSbqtkn94xUSJtl6qjo232HLMIKRzl1TFfLMjag0RGq7UBTFgILvTmu66Ue3oOTHKhXmGNOA+8szUJYB9DNXhF4IAEp+EPeE4yE1YfW85zFsk4kOAC9i9IByXi+nRx3mM01maaRDCx/d4vM5sLG1Ow9noUdUlwv3jaePZEQp1LvVIp6TUAAyu8VylSjFxFP7AksWFcN0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 18:57, nifan.cxl@gmail.com wrote: > From: Fan Ni > > In __unmap_hugepage_range(), the "page" pointer always points to the > first page of a huge page, which guarantees there is a folio associating > with it. Convert the "page" pointer to use folio. > > Signed-off-by: Fan Ni > --- > This is a new patch added to the series based on the discussion here: > https://lore.kernel.org/linux-mm/aAHUluy7T32ZlYg7@debian/T/#m2b9cc1743e1907e52658815b297b9d249474f387 > --- > mm/hugetlb.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 7d280ab23784..8177a3fe47d7 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5840,7 +5840,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > pte_t *ptep; > pte_t pte; > spinlock_t *ptl; > - struct page *page; > + struct folio *folio; > struct hstate *h = hstate_vma(vma); > unsigned long sz = huge_page_size(h); > bool adjust_reservation = false; > @@ -5904,14 +5904,14 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > continue; > } > > - page = pte_page(pte); > + folio = page_folio(pte_page(pte)); > /* > * If a reference page is supplied, it is because a specific > * page is being unmapped, not a range. Ensure the page we > * are about to unmap is the actual page of interest. > */ > if (ref_folio) { > - if (page != folio_page(ref_folio, 0)) { > + if (folio != ref_folio) { > spin_unlock(ptl); > continue; > } What about something like (keeping in mind that I suggest renaming "ref_folio" -> "folio" in previous patches) const bool folio_provided = !!folio; ... if (folio_provided) { if (folio != page_folio(pte_page(pte))) { spin_unlock(ptl); continue; } ... } else { folio = page_folio(pte_page(pte); } ... if (folio_supplied) break; ... -- Cheers, David / dhildenb