From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50839E77198 for ; Tue, 7 Jan 2025 16:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDDE36B008A; Tue, 7 Jan 2025 11:48:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8D496B0092; Tue, 7 Jan 2025 11:48:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9C3E6B009D; Tue, 7 Jan 2025 11:48:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8695E6B008A for ; Tue, 7 Jan 2025 11:48:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38797A0164 for ; Tue, 7 Jan 2025 16:48:30 +0000 (UTC) X-FDA: 82981239180.01.F1ADD81 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id ADE3D40006 for ; Tue, 7 Jan 2025 16:48:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hNMUeux9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0Ci9xgr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hNMUeux9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0Ci9xgr; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736268508; a=rsa-sha256; cv=none; b=6kLCzl/kqtI3a+QL0k+N5hEIeJBy0DCjRy7mj0uyylHacQYrNs5jpjyWSdujXUyrXHI0Pa T5Hskx7QWlljIvbxpp+TbspTPBCMtYFSQup1wPHOwEcOHtLmXmo/FTqPy7A9cqJu6SlprE TKShI8c2Ayo0NIQZSKt1iJJFNqxpwX8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hNMUeux9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0Ci9xgr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hNMUeux9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0Ci9xgr; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736268508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r1ee9Brv86Habj3Hz3ipxefYUSa38rtgSs4O+8idEk0=; b=pdhg8F1iearDZH0doeaUJtRYAOwnfn3rrQtRcUzkyxnqI7+DYR7I/aXf0LQxrK/O+3vXei 6coaV2GDzYJMg2q6FTbD/FN8OFIX/wG3/Wd+YFsoG4fUY8EKwWZ5ou6ydDe49kJgsnrwG2 QIaLyaeR/CEIfkbSxvW/nu8emFIVA0U= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1B601F390; Tue, 7 Jan 2025 16:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736268505; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r1ee9Brv86Habj3Hz3ipxefYUSa38rtgSs4O+8idEk0=; b=hNMUeux9oL7BYfShkjDnzZkYdfQLSWa/6OpAHgBdh1dUZM+G0+CXz2igzCG0CM+oj9Bhch uYIdw9Sf2zRXMRjw6+uVacGFhQ2jJJojTGP98/xyNZ/AUxrEJRiwn6A4hRModt8ZUzxLyW gqllXHKZkPGAgNgYoLIVM4HwF6Zy8BQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736268505; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r1ee9Brv86Habj3Hz3ipxefYUSa38rtgSs4O+8idEk0=; b=l0Ci9xgrc8IIl/FUAAa5J/rfwCkGvYssgzCAkzsS0xntMTu0d1yNZ/m+b7N9RYNYZlgk2g 5knx8vfcBWs26iAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736268505; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r1ee9Brv86Habj3Hz3ipxefYUSa38rtgSs4O+8idEk0=; b=hNMUeux9oL7BYfShkjDnzZkYdfQLSWa/6OpAHgBdh1dUZM+G0+CXz2igzCG0CM+oj9Bhch uYIdw9Sf2zRXMRjw6+uVacGFhQ2jJJojTGP98/xyNZ/AUxrEJRiwn6A4hRModt8ZUzxLyW gqllXHKZkPGAgNgYoLIVM4HwF6Zy8BQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736268505; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r1ee9Brv86Habj3Hz3ipxefYUSa38rtgSs4O+8idEk0=; b=l0Ci9xgrc8IIl/FUAAa5J/rfwCkGvYssgzCAkzsS0xntMTu0d1yNZ/m+b7N9RYNYZlgk2g 5knx8vfcBWs26iAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7F6AD13763; Tue, 7 Jan 2025 16:48:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 805VHtlafWf9YwAAD6G6ig (envelope-from ); Tue, 07 Jan 2025 16:48:25 +0000 Message-ID: Date: Tue, 7 Jan 2025 17:48:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/17] mm: modify vma_iter_store{_gfp} to indicate if it's storing a new vma Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-5-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241226170710.1159679-5-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: gu59u3ogcmfcaxncj1dohzggiwmzo9iq X-Rspam-User: X-Rspamd-Queue-Id: ADE3D40006 X-Rspamd-Server: rspam08 X-HE-Tag: 1736268507-940141 X-HE-Meta: U2FsdGVkX1/TneUJK2ReQdQK2C6+EOVLRRPa2QNdRlDUyDoBBXwspHwb9htSWg90FrbB7nFsTwI53oPeh5dEuDdNJH08ejo0arcxRSHjp5YN5tW2m1S8clFWNqO6E/t7KoaDDCv05Wp+KZGsvrGX8VKMKX4iXlABkLhHykb0vz7aOzCzh+M1OwLfaa/tudSqlgzbhm2MeEUJwQedpEwODl+WOWxvGBOyJsD8REFebHx2rMZL4X+ZdBNpFl9f0LWxm8VMTXQ34y5tdC6GIDyJY6nXVhAxuyueHTKpDozBrvuYjOo5PwYDxdAkPX9Y8HdRNC5UK7H8/5u7lmwJluKLDfVVytvnhvouOQToWWMrmjMCK28JskzLeW7NLcr4ImrS321huEm2pMeOnH8peIQ9Y1GVSD1mfoJXTGfTx3W7259A194hc2oaoCksY9vHRvX/M4FUB7ogtZJxBsS6J4yMguleUlAn6ixLIYbkZnauKrqU4Z4fyBXA/x612G3SNBY2UJSjiCJkBbE92GtUOtIXBA29m/xTlrfNXpdxbmkOV6dnnBGiCo1o6ZIjblI2Yb1sURG+wIV+occJ4SzSuCf/f7O3Tn7s2dnpt/wMFz6w4fgkzu52wTYP4oxRWOeBT0wGI7wMBaWpo8pGep3fGrAMZMkpHQp/buQuS+iqQMxeF0YfWGa/JURBM94WWC41dkIsyQTZGPs1W+7kBIgqwEhFiiqI2dUvzaCH0yYwz6hlKQjfp+an/oHK5BnFw20iMbMuhCC0IRGat09mdh9iLpxF0nSZiySPtPudZ0MwNd0OYOM4YHP+Ecg6C03w61IFwar/9z9gGI7WUWIoakJLK9uE7zQ+C/vF3Fh1LMzj5ObK+GGRRCHsbBPCCmzfA6XcM622xlWDB5DcmX3veNOQ+/WFSUMa4b7j10jT98ByMKcVC6JSLmVuEjLUP4UrGWyqWR0n2hF9BeQ/nT/t59Om4fq Rl1HFA8t VBwdqrIzlc5b5bh+wAPioMnpeOVzz+xZX5BFMKAkyZ5PsjAhzvEbAs+26xHdMz51Jw2yyjVwGhvyWkH35OXkSb+Xft6GTEdYvyJ7KtcUeb47B68WLHR4LATUrGb8mz3tO7vxZI6Q0uCB4xvXvqx5YxHC61Hh4dSuMV+LcUIh5At0asX11znTWFNO/ffbbENGlIQzyEs5gEU/tdX1g2Wshq+2rSWRljsWr93oNXaF5bTnqJr9aP2X8MHwlatOgGCjZiDtF7w5+ZhGctYTVAC/tGrXaydOBk0g8EX4vN3JuXJe1Lziku+aqt6UcSUkuqd73jf/AU0SHhwuqNyoULe5bo4cgbNauD6b2c/cs3d6b5Og6bUE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/26/24 18:06, Suren Baghdasaryan wrote: > vma_iter_store() functions can be used both when adding a new vma and > when updating an existing one. However for existing ones we do not need > to mark them attached as they are already marked that way. Add a parameter > to distinguish the usage and skip vma_mark_attached() when not needed. > > Signed-off-by: Suren Baghdasaryan Seems like an overkill? Looks the common case is the "true" case so add a variant for the false case? Also seems no _store_gfp caller uses false so that doesn't need to exist anyway?