From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F924C2BD09 for ; Fri, 12 Jul 2024 04:01:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA4DC6B00A5; Fri, 12 Jul 2024 00:01:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D53406B00A6; Fri, 12 Jul 2024 00:01:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C44066B00A7; Fri, 12 Jul 2024 00:01:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9DD756B00A5 for ; Fri, 12 Jul 2024 00:01:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1C46AA2FC7 for ; Fri, 12 Jul 2024 04:01:29 +0000 (UTC) X-FDA: 82329751098.01.42A4D89 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf10.hostedemail.com (Postfix) with ESMTP id BE2A7C0005 for ; Fri, 12 Jul 2024 04:01:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l1TZeUmU; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720756870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/VZJgwIDEY1bFqqyo1Sj8OxXpbkhbY9mmx+7bOp9cv4=; b=EHiB1429Q6R0xE2h6XQQroyl2uXRhRVvSe7Q9FNfBUnYmRLw1qxnXNoU3lGpOB1+QnGkkD X3dOjTBrycpMDU1/8QyoHy50Mwkjocj++kt1xb5pdQzU8wKcKELmAqb2OwhwoKP8L+wD2F V7R2+eV1O5TysHWFoT50wT9um+rWeEA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l1TZeUmU; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720756870; a=rsa-sha256; cv=none; b=1UXcyF/QT2uU5X8K88yqktUnMYNM027GNs9WW1BXKM4yEY0Tx4iGqG6eiFAw+Axc0+6jxQ epTtgFPjpO2j/dRrn3YNkjsxDJCNcFY+T2bDBIQHq0eAED54tXfbNEjSaFVfLNj1mkoOw9 Hb1so1VmGxW81/BuAWn7bzN9nRrQ9eA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1720756882; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/VZJgwIDEY1bFqqyo1Sj8OxXpbkhbY9mmx+7bOp9cv4=; b=l1TZeUmUHsuecBVNT5LjkjykKgI/0xHdaUTKiVmgNTutzoPCd8bnAeozuwFtml+jZQUS+SZq1Yf0HHnas70yyiDdV93ATi4HPjkqlOYgo41OZF3Mvdoik9t1pnIqKeQuI/H1dQPjhPJ3c9ZX4//y01L9ksWrOQj7unea7I0Yuvo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033023225041;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0WAMhfpp_1720756880; Received: from 30.97.56.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WAMhfpp_1720756880) by smtp.aliyun-inc.com; Fri, 12 Jul 2024 12:01:21 +0800 Message-ID: Date: Fri, 12 Jul 2024 12:01:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() To: Zi Yan , David Hildenbrand , "Huang, Ying" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20240712024455.163543-1-zi.yan@sent.com> <20240712024455.163543-2-zi.yan@sent.com> From: Baolin Wang In-Reply-To: <20240712024455.163543-2-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BE2A7C0005 X-Stat-Signature: nqrdeynfboiuo5m4y68fgz54k1y8ohtu X-Rspam-User: X-HE-Tag: 1720756885-272479 X-HE-Meta: U2FsdGVkX1+gxYnr/C1Y2G437qxyswgpHSN4Zf3JfGwYiAKaBvMMaJjvlIgZemseZYh3S1+K2QfnqpuUMRrxdxXWUzYgGLmi9yqvvrQLJEo9/8+I/G/2c1oT0tY1dhNwnNlulvvJyH08T6eRkX+2WO2DpCp+BS4lrXFDgw5L1ZB9eN3IPUvegs6uLVrzkygXDbbLvNJ7257YgxIX1zPNc47LT3RObHi3u81qi2lvtUgQ8lowg5IcZoPy1qzE23KE4X0sAMEGYXtAJpbndOm519LU7oIQWBXmLiJK3hsNzqRhxxMEGuAP/11E4UVwOr2yVtr9RCnnib3LRQnqpl++NG3FvhZS2eAI7S43o/y5B4iXclJDbJIRQWVqb6rEls9boRfWSHHJkb9mvnqzqjueQRQq+JyuoTrMVlpYYg9spN1X+cXSidKfeEj9k70UUCgeyiGac+hxywlYxNedev19CZif6PqRTkD++2tgtjLe8kkwCmzCqj3qO9S/i7d9cIFfm7pLIi6M92hYshuLA8z1AwKueVGOGpD/JG8X74tMBo9Z9upaheKS0HpLFBoHXDkBTUqXx784UHLDrwkMwYRupu8w0JYJDFWmZP9Ehq+Gx20BqNQMzaohAN9GukVyYn7xV0Rz+xtVMy81VxMHE2TopVQhiyERnyrwvL46sAlPPWzuQWS9sF2O6oNe+KdlOnHdA7efiJ6eNUQIPCx7uDlwVcqWVd0QyDEkc8qBhs+Ic5jA9SnrrWOy0mM5Xk96/6zFgmkPKF97ZgxCEFX8XPJL06UQ162cKyauoax6w3uYC20ZmE8x9p986J1Kzw7tToT/gYlR4t/bJjQ3HLdnu/jfhaxWesWh5jsQZHd7+FDbFDoGJDeU8ZPZNpI9VvHzvdQSgjMP+uT2NpwCCyhie1ip7lS3FU8ITtTgvHWXLdMnk60ABtHoifUanb2lKjLA3oTpBaH/w/Qr9tykswYTqiW YcyBa5Zm yimFDZdCVJhVtw5DA1a4b2vxPDmimB3olwB8kjtKWNvk9VuNkWc0wKzsnQVYRTqftBw5VkR98KtNuCgfW9nvvKqwVkRXhefRn5eS9PSBy62g4EqgrRZkalKozZ8nf9/0jDX+glWE0TEhsoZtaYHD2ASXtv1JOdz+IsxDyH/2EXt0YXL/uguQb9YiVzZxprB+xJFDiWGnUINtFIg2AaqXuK2R5T1+LlT6HkxCRi2q8aoZCEyR8Jk8ToaMjAReZQHV4r103QpW9ZHy1CNOt23kvRNkC9kEgFC/rpoDit13w84SLj2+24boOu9j+2yn8jXH20QKBhBkzfeyrBnm9ivbXXOHEhkWNhVfHsQqrE6KWObNGT7M4aMJ79M+qrMeQ+Jruqjtt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/12 10:44, Zi Yan wrote: > From: Zi Yan > > last_cpupid is only available when memory tiering is off or the folio > is in toptier node. Complete the check to read last_cpupid when it is > available. > > Before the fix, the default last_cpupid will be used even if memory > tiering mode is turned off at runtime instead of the actual value. This > can prevent task_numa_fault() from getting right numa fault stats, but > should not cause any crash. User might see performance changes after the > fix. > > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan LGTM. Reviewed-by: Baolin Wang > --- > mm/huge_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d7c84480f1a4..07d9dde4ca33 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1705,7 +1705,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) > * For memory tiering mode, cpupid of slow memory page is used > * to record page access time. So use default value. > */ > - if (node_is_toptier(nid)) > + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || > + node_is_toptier(nid)) > last_cpupid = folio_last_cpupid(folio); > target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); > if (target_nid == NUMA_NO_NODE)