From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4DE9E674AA for ; Fri, 1 Nov 2024 07:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 035996B0083; Fri, 1 Nov 2024 03:04:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F27A16B0085; Fri, 1 Nov 2024 03:04:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15A06B0088; Fri, 1 Nov 2024 03:04:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C3D2D6B0083 for ; Fri, 1 Nov 2024 03:04:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA15D141A01 for ; Fri, 1 Nov 2024 07:04:39 +0000 (UTC) X-FDA: 82736636388.17.28F5727 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf26.hostedemail.com (Postfix) with ESMTP id E63F414000C for ; Fri, 1 Nov 2024 07:04:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=P1JYcqXo; spf=pass (imf26.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730444517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gNg1oWFL04qMlPYNEjeyCMQDXxCaSeoTziUXUPiPj6I=; b=KuKAinmIvjzAfqJWRD2zMHiW6trs0XPyELFqpD2p13NMHVFmFouOJV2auxUkbSl0pXmFe0 x9g6qh2OFC7tkjf0QOJSdJRh5NmxpbTvvHzKWP7qaVschZUFI9DkcdaEmwhCk24aRDV51S QUsIeQSbQoVpY2hB66IaCwnNw5XLoPI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=P1JYcqXo; spf=pass (imf26.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730444517; a=rsa-sha256; cv=none; b=Qu6hTl8aNV+SS2HzTaluXcCIYO9EjZrv49U9223Q49+EXKxpAzmAGHd5PPfyomemupaE26 CBWR13TLQj41+kySOWaZQ5R+W9nKL2qODkTdnBp+s6P+NNL83+tAegMWkiA9mAKaR7U1kN 3W3MSu9Ho5fRkY0ACUoEs9mlHdYw+sE= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539e8607c2aso1839286e87.3 for ; Fri, 01 Nov 2024 00:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730444676; x=1731049476; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gNg1oWFL04qMlPYNEjeyCMQDXxCaSeoTziUXUPiPj6I=; b=P1JYcqXowVaEgbMmJuqDywf9NLD/lxSqA5Tb3VyZlxWOyP6PBYPy7XUR82jfP5LzE+ ARyDooyv0moP/bNTa98yDLmBTK9PuyrWasGAb4W1gdjSaxJd3ffj0wy5OXRAfPEwPKqV J/Moo02arS6nATj2Wx23KxvNgedZUVmpg3DrRfQN0uiFI4ruuMqjo/yTjyrORhtXeu8f NBbNnh5OyOuAn2H2gR9OvXDMPXb3+mGntOtHl39J7FJT1NpAcgFwDmnE6A4/b93kXzsO SN/DX6GnMvHyvgK5lGSLIQA6T8xs0gBHuCmOmbtz7YWfrS+6KUh8I1dKWs7V/chIUuVv rR1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730444676; x=1731049476; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gNg1oWFL04qMlPYNEjeyCMQDXxCaSeoTziUXUPiPj6I=; b=bAbOzlP9YBuIOoJ6b84yeUZmLn/vTt6MvxczoQXkePVYDJZlot+TNLKGlieviQ4vCN iYxg7FiTzbUFWwEHvvdLmDA+dOu/D0/2/8ElJg2Y1Njxp1nRwCKxtlrObODWrQtrE6MI n8Hz9QUValjp9xBkZwxMfpsUHP0tHtOVT1ikJpucPzP69wFzDaj3fuppoghMhnxhhE25 0BwAO9XCpJW5AUM9IYzsFqn/oV3QKqkIjvgiPZ8nKFZIzHTe5T9j2gJLpkF1lK2Q+pJq qoigTq27/vpmYFJDHaJNzrEKqNw9aAha+teoMn9+HfC611ukRUlTqnG8DOviSsepabYq 2EDw== X-Forwarded-Encrypted: i=1; AJvYcCX9tLahK4gR4ra77FWPe64kmDUdjtn6tcDIl7AmeIoXmgm0XchOODeGpCMEXh5tcx8tAdUIuTWOAw==@kvack.org X-Gm-Message-State: AOJu0Yx+9q2tWP6XOwlBfVOM50D/pAFie/AVm3lCkezRVUtpRfZfa+2X YcdiZCjoL0ViMklvUG4JX7Gm/Sd4HdUfBhDAoIT9izZJFz1eBVwVwknTmPVw0uk= X-Google-Smtp-Source: AGHT+IHYsu3xMEXVylaSXmd5wYDcYwx7AMgGbkJL9CvXxEoNieVW74Qm38Vw/C6UrcN42x8oH5649g== X-Received: by 2002:a05:6512:3091:b0:539:ea7a:7688 with SMTP id 2adb3069b0e04-53b348b9130mr10496508e87.1.1730444675965; Fri, 01 Nov 2024 00:04:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7a9esm4141047f8f.21.2024.11.01.00.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 00:04:35 -0700 (PDT) Date: Fri, 1 Nov 2024 10:04:32 +0300 From: Dan Carpenter To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, rppt@kernel.org, mcgrof@kernel.org, petr.pavlu@suse.com, samitolvanen@google.com, da.gomez@samsung.com, yuzhao@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling Message-ID: References: <20241101000017.3856204-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241101000017.3856204-1-surenb@google.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E63F414000C X-Stat-Signature: a5aynwexg6bc9qpmbmkttkwaoorkejh9 X-Rspam-User: X-HE-Tag: 1730444656-365680 X-HE-Meta: U2FsdGVkX18RAK1HNZ1nq2yazlAN/eggZGK0dzcx8TJbHnh3xaxt/F7WJcWdX09rFcJRoa9LPIv9wBRYvP8aq+GT0aay5314AUzYlbU8/NKOubwHMUYZ+PcAB2eHp/LcUgXQ2WeMAlOuplsJd/7KHe2bN2cDZIPO080vrQ6lin8+Zw9xR5jE+jzJCOW6VsH5J4TtYJ2ISQSaLur75lLKoZAbUxuknTnqLxHtrLErEOtYP5Bnmxewgl+rznWWBx7+7vJwlfTDacInQLQSaIKE5PL5Zsthaalar9QzViCgGg16bQu41iDGv9drBwvdnCUmr6qDm5AyM5ejhrc9EeTz69E59e/+zBx3JBiqKZJSuXRgkFSTnTizicL+kPIiGMXbb1KzMCALDi39OKu5RTpJ0rsRpl9qihoNVusVubjNqOOQRDHef6js1mq53PD0Xo7oG3WMgjaASK8qQbH/WsmV86o+kZ7qds4GX/BdVMlSMNl7JfFZqSmAqgVUWFkpWWDCjo+iZnV8Gro+wPk93v899if8CJYcktLDeN8gZ5GlUSwSJz45GMxOKnPTRzlplE9+66pFfw0gX3INO6/qSbaAlffGZreqEt14Al6CuTXXM0lap643bWly8vageJqJAlUbqSZ25nsP3/DjuJKZtfJTlt79XZr2/iQ2ryBdPFtx7xmzLoGWknqfSNSBfyHr08T5QEsPwprJymVaQrrWdu318gBOSswh6jkqdxt3cL8ejIN3A1BHDEMPpWd10l7YoMcOIvSmAY5do4z7Bw/8AUg+7iiradBQVNnS3X1my3kBDJYI42FfL6QSIhWDBwNyxZZNp45rl6jVdcSSGRIKWRKjViu8mWNUI5tNQjavqu4URNWEX0VSpdW/2DLgMJnNFzc64ScdUmeCMRGZBnnWbzcr69TrwKc0EWUj7P8egu/fwIXUCdb/vLGnffd1O1WAq93hTMBJm2GLvVeCcr2mN2k p9EIjZOL cKNxQ2NQ4xq/b+tSuiMvlKwTchuKdZS/icsBeL1TK30NNdXdj4aaGzAoKu0aJNOPrmlJwCAW6m4oKABQNf+ocp5mlZnnzXTLSZOgMyXSwc/DfSCqd6uVhIz+nHMj6nTqOhAOkYxlMEv1ikc2U5KKpJ2vlgIa+a7F7R6rAHSy2TC35+D3Ra54zMZrg+zXbSMEwnpT0pJSgxUGYWsbQ9YdqFTv6yFtobmoeIVT1kxpxLyjhae+tBy7ZHZCBWXKFeA/+xGNkQANl4mvaEcs1s2l0vqkjr6O+ZdmN8JA7fJr5K/eU7kYt21XIOdekhIYXRJ+w8vzs X-Bogosity: Ham, tests=bogofilter, spamicity=0.017465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 05:00:17PM -0700, Suren Baghdasaryan wrote: > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 1c74942e6dfd..00ab18ea452a 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -437,7 +437,7 @@ static void *reserve_module_tags(struct module *mod, unsigned long size, > > /* If no tags return NULL */ ^^^^^^^^^^^ > if (size < sizeof(struct alloc_tag)) > - return NULL; > + return ERR_PTR(-EINVAL); > Thanks for this. We'd want to update the comment as well. regards, dan carpenter