From: Dan Carpenter <dan.carpenter@linaro.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
rppt@kernel.org, mcgrof@kernel.org, petr.pavlu@suse.com,
samitolvanen@google.com, da.gomez@samsung.com, yuzhao@google.com,
souravpanda@google.com, pasha.tatashin@soleen.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling
Date: Fri, 1 Nov 2024 10:04:32 +0300 [thread overview]
Message-ID: <bd5e58fa-4458-4680-be2c-e14d43d32572@stanley.mountain> (raw)
In-Reply-To: <20241101000017.3856204-1-surenb@google.com>
On Thu, Oct 31, 2024 at 05:00:17PM -0700, Suren Baghdasaryan wrote:
> diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> index 1c74942e6dfd..00ab18ea452a 100644
> --- a/lib/alloc_tag.c
> +++ b/lib/alloc_tag.c
> @@ -437,7 +437,7 @@ static void *reserve_module_tags(struct module *mod, unsigned long size,
>
> /* If no tags return NULL */
^^^^^^^^^^^
> if (size < sizeof(struct alloc_tag))
> - return NULL;
> + return ERR_PTR(-EINVAL);
>
Thanks for this. We'd want to update the comment as well.
regards,
dan carpenter
prev parent reply other threads:[~2024-11-01 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 0:00 Suren Baghdasaryan
2024-11-01 0:13 ` Suren Baghdasaryan
2024-11-01 0:45 ` Andrew Morton
2024-11-01 7:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd5e58fa-4458-4680-be2c-e14d43d32572@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=da.gomez@samsung.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=petr.pavlu@suse.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox