From: "Gutierrez Cantu, Bernardo" <bercantu@amazon.de>
To: "yajun.deng@linux.dev" <yajun.deng@linux.dev>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"lkp@intel.com" <lkp@intel.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH v4] mm: pass nid to reserve_bootmem_region()
Date: Fri, 25 Apr 2025 10:02:12 +0000 [thread overview]
Message-ID: <bd5842a92bd340799a74063f8da83d96@amazon.de> (raw)
> + if (memblock_is_nomap(region))
> + reserve_bootmem_region(start, end, nid);
> +
> + memblock_set_node(start, end, &memblock.reserved, nid);
memblock_set_node() receives a `base` and a `size` argument. Passing `end` would
cause us to set the node id on an incorrect range. Will send a fixup patch
shortly...
Best regards
Bernardo
Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
next reply other threads:[~2025-04-25 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 10:02 Gutierrez Cantu, Bernardo [this message]
2025-04-25 10:20 ` [PATCH] mm: memblock: Fix arguments passed to memblock_set_node() Bernardo C. Gutierrez Cantu
2025-04-25 14:18 ` David Woodhouse
2025-04-25 14:37 ` Jiaxun Yang
2025-04-26 1:05 ` Andrew Morton
2025-04-28 9:13 ` Bernardo C. Gutierrez Cantu
2025-04-26 8:22 ` Mike Rapoport
2025-04-28 9:53 ` Bernardo C. Gutierrez Cantu
-- strict thread matches above, loose matches on Subject: below --
2023-06-19 2:34 [PATCH v4] mm: pass nid to reserve_bootmem_region() Yajun Deng
2023-06-20 8:45 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd5842a92bd340799a74063f8da83d96@amazon.de \
--to=bercantu@amazon.de \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rppt@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox