From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CE1E77173 for ; Fri, 6 Dec 2024 12:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0734B6B0259; Fri, 6 Dec 2024 07:21:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0220C6B025A; Fri, 6 Dec 2024 07:21:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2BB76B025B; Fri, 6 Dec 2024 07:21:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE6376B0259 for ; Fri, 6 Dec 2024 07:21:47 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 33C05AE765 for ; Fri, 6 Dec 2024 12:21:47 +0000 (UTC) X-FDA: 82864444446.09.FC57F97 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id AF9B0160013 for ; Fri, 6 Dec 2024 12:21:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733487689; a=rsa-sha256; cv=none; b=G2Gszx+GNBZBvueINtpxOpkEUO8PxZPBHl8W6O5+ehiH8dZQt7pjsNdoQ7yW5RFlTsSaY9 jGUVq+DEIEUrTfV02SYPGJBO5twS2NKhkC2SYmeMd9UW9R/lQsxQ2MXsDceqYEH3H4XO/h YGGh1PD2w6ruyhcH+rOWBQZFxkNQT7k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733487689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+9RosJYTEpseZCD+ZRKGDfdLodPKjo1b+MiM+Vfii0=; b=7KiqyvVz/oFHHfkMDi/J9x2IqkbPI9Z75UPVon8ak9/MGThNpC7UcO02C68n8sncDVX9Rq Q4TCKIb5Moql1RSncIz1qGpBGPaH+LMgu29mrTcmLzuzNSmZ6lkihDpI/Fn8/1fF/DriXM Hgs4XFX9S1p1V6wQUhJJdShIUmWLLqM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9600112FC; Fri, 6 Dec 2024 02:26:49 -0800 (PST) Received: from [10.57.90.201] (unknown [10.57.90.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB0063F71E; Fri, 6 Dec 2024 02:26:18 -0800 (PST) Message-ID: Date: Fri, 6 Dec 2024 10:26:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 00/57] Boot-time page size selection for arm64 Content-Language: en-GB To: Petr Tesarik , Michael Kelley Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241017142752.17f2c816@mordecai.tesarici.cz> <20241205182008.2b36476a@mordecai.tesarici.cz> <20241206085026.32c89a03@mordecai.tesarici.cz> From: Ryan Roberts In-Reply-To: <20241206085026.32c89a03@mordecai.tesarici.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AF9B0160013 X-Stat-Signature: rbh6z4msmgra4xxdiipbxj6sznncahik X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733487693-516037 X-HE-Meta: U2FsdGVkX1//+TE9wjWpkRL8Rqgx6TeYnmBakwPl0blVExW345/khBdGtMuEiE/+pwkfT6KKN4EinqTqIco4fR3+L+l2ZLrJHbv6ITw0rYB9X4rbKyQF0WExwg/FohA+8TTqQDQ/ELDbTFuZ3w4Juit9hR7WL5SF2hAR0Uo11Hzrf17kEBeJhvy+gIjhnCdS6KtbtkzWL/UFSR+NcwEQrFsJvkUndzNN/e1xu3vBhQIJWodPrrn5NCLoVmFEPw6YKhH4pTNaWsKKwIIbECu5TZqRE0SyrVAzlN5gOVypY0KqHu2KIUMVIcDrnajmxPWPgcgo+F4vqdK3NjMmcbRSKHjN3W9ubtWrupBqN2lDd2ZBq89e+V9fIuvLnSPnvDB8YiQHP2Ie4h9ZnEucfxCvdKKk812rcF7EgU19etNhplioWy/TgXJDpy+3z19/VQ+X9hRoQ4JhLZFhv2unXP6YEo/0vE2iKR7zHDc+2lQh8otVoO1V9ygfi4a84yNT+28VS9gcZrE8IFaatVCThsQiY/N01EK8FeQw2fSBUwIvpzl8JwgqQp1R92ERbNLaR7MR0p246XhfsXC6HgQk0zWTQ7FU2ox+j2DLvE6BH0u7OJvfEkvs7oPKMgUbnAa+lLjGDdIkUWe8zE3nkCsN6X+61fPCDHi4o7XK7oVXjIADiqDgWbJ+HmRCY53AHpASOEU8vNEJ+Q0nNl6U/PCsemcxwkIR8U4p9LGuThIyS30AoqCbuKGj7H3eC/mldGAElmbKOkxMA0GFRj6PrIvcFohBQ6Q708UA7QQjGgE608P1S1epkckfbyLdGOplP0U2mfHj84rOcUR5DEmC9Co3gRI0HSch1aCtvUWLQobTcJnBUEP7i+d9MPGY74cex4WZhQ3O11i3hXXTc1A+/8rfflJ6h8grZFGUHIM8HhDUbxanOYj1naJpxHx+PDkb0WIbw5983k3VMjTyx4QWpOBXWU3 kUD0ftYN mgEEJLRZq12lEFO7a19JU8Xxz6aSph6hkTYjEtfMd3yXbtAYolFF95u8mQwNmEzZBvYq+Fl2cu/2Bqxui4+lRLba+3SQVfhnAbywsL1C7laQt3Edyy6Z/3sEX+5wNo1v3rauy/d3R79XATV2KTmapSbP+1b6pvd3zZtendiKyYDGKipx3NLu0tpekrzJvO679XwKG/JBXkMI8WwVqSK5/Wijpo5CoPWCFBovtgpJpb9wwTgDjji3UV0ZvJZ5gHtzHv0gB6TcM8sdMDQgPx/MFKvtd2OvbNsTy6nfJRMQGE9aJYeFY8tXuzx80OSNvUa6iNOpXBN1BJXqFH6jtxHyMJhTkeGWEtxywFxFH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/12/2024 07:50, Petr Tesarik wrote: > On Thu, 5 Dec 2024 18:52:35 +0000 > Michael Kelley wrote: > >> From: Petr Tesarik Sent: Thursday, December 5, 2024 9:20 AM >>> >>> Hi Ryan, >>> >>> On Thu, 17 Oct 2024 13:32:43 +0100 >>> Ryan Roberts wrote: >>> >>>> On 17/10/2024 13:27, Petr Tesarik wrote: >>>>> On Mon, 14 Oct 2024 11:55:11 +0100 >>>>> Ryan Roberts wrote: >>>>> >>>>>> [...] >>>>>> The series is arranged as follows: >>>>>> >>>>>> - patch 1: Add macros required for converting non-arch code to support >>>>>> boot-time page size selection >>>>>> - patches 2-36: Remove PAGE_SIZE compile-time constant assumption from all >>>>>> non-arch code >>>>> >>>>> I have just tried to recompile the openSUSE kernel with these patches >>>>> applied, and I'm running into this: >>>>> >>>>> CC arch/arm64/hyperv/hv_core.o >>>>> In file included from ../arch/arm64/hyperv/hv_core.c:14:0: >>>>> ../include/linux/hyperv.h:158:5: error: variably modified ‘reserved2’ at file scope >>>>> u8 reserved2[PAGE_SIZE - 68]; >>>>> ^~~~~~~~~ >>>>> >>>>> It looks like one more place which needs a patch, right? >>>> >>>> As mentioned in the cover letter, so far I've only converted enough to get the >>>> defconfig *image* building (i.e. no modules). If you are compiling a different >>>> config or compiling the modules for defconfig, you will likely run into these >>>> types of issues. >>>> >>>> That said, I do have some patches to fix Hyper-V, which Michael Kelley was kind >>>> enough to send me. >>>> >>>> I understand that Suse might be able to help with wider performance testing - if >>>> that's the reason you are trying to compile, you could send me your config and >>>> I'll start working on fixing up other drivers? >>> >>> This project was de-prioritised for some time, but I have just returned >>> to it, and one of our test systems uses a Mellanox 5 NIC, which did not build. No problem - I appreciate all the time you have spent on it so far! >>> >>> If you still have time to work on your patch series, please, can you >>> look into enabling MLX5_CORE_EN? I've also had other things that have been taking up my time. I'm planning to get back to this series properly after Christmas and convert all the remaining module code. I'm hoping that Michael's patch will solve your problem for now? >>> >>> Oh, and have you rebased the series to 6.12 yet? Afraid the latest I have at the moment is based on v6.12-rc3. It also includes all the changes from the review feedback: https://gitlab.arm.com/linux-arm/linux-rr/-/tree/features/boot-time-page-size-v2-wip >>> >> >> FWIW, here's what I hacked together to compile and run the mlx5 driver in >> a Hyper-V VM. This was against a 6.11 kernel code base. > > Wow! Thank you, Michael. I'll give it a try. Yes, thanks, Michael - I'll take a look at this and integrate into my tree after Christmas. Thanks, Ryan > > Petr T