From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5D7C4332F for ; Mon, 30 Oct 2023 16:31:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA5996B0246; Mon, 30 Oct 2023 12:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C51E06B0248; Mon, 30 Oct 2023 12:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4EF6B0249; Mon, 30 Oct 2023 12:31:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 99EF16B0246 for ; Mon, 30 Oct 2023 12:31:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 59918B5A70 for ; Mon, 30 Oct 2023 16:31:15 +0000 (UTC) X-FDA: 81402667710.28.F1FB580 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 21E85120025 for ; Mon, 30 Oct 2023 16:31:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QKgeY2zW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698683472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AFGN4ziW+95DqCrq4ZKBGZMP1faea1+XydZr6yChQh0=; b=PAxFOE6YJfHxIxNpALN3UNe+fL3ZiOfwAVmkBQy7w0QWIrM8Qxiyb9FYWK4CLpHQW2xNt6 YKhyyqodrLd7pE77fF6pe/FBQlHX6iqiX8a2ORjKjUCUjUEmJYBHy21acIcJfk5fpsxQtm DPStDAzaoHlhgjQ1TTvxYdpDXB9Wzuo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QKgeY2zW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698683472; a=rsa-sha256; cv=none; b=5f9X8PKI8Yiq2ND7k/Hm73+Av47Yxme4G4naTIGe+ycKYhXtk85xIQ3nTMzITmuh81mH5M StqUZKZvuNg7wC3bR5yTZV2J2SBgcis5qrNqwjugfE+6bVyMHrFJW2gbVTd4TrG/mkg0sF s+SRrYtpu7eoRrAJTXGYjf/MLoxbIzk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698683471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AFGN4ziW+95DqCrq4ZKBGZMP1faea1+XydZr6yChQh0=; b=QKgeY2zWAv/eD9RoIAWjBBfrgjM2gd55KCBP250TEs5K374GAslVlfY9D72cNF0RncLHsi NGUoB6gfj8AF++B1VdF5V23RvSMfUeyjZ5k1mwnNxk3jvonZfYdO/LHEGy5kgOaBj0HRcB FuQjnOn4SV8yLIVPpzoqnhYYm8W3s0c= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-X__DkLQsPHK_1xFxhWnrfA-1; Mon, 30 Oct 2023 12:31:09 -0400 X-MC-Unique: X__DkLQsPHK_1xFxhWnrfA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-507c4c57567so4921234e87.0 for ; Mon, 30 Oct 2023 09:31:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698683468; x=1699288268; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AFGN4ziW+95DqCrq4ZKBGZMP1faea1+XydZr6yChQh0=; b=oIrxkVtwVSuxg+Uya50IOIVZ6fmdvMKHeW+5+vffEZrKbTRJf9cUjJJ2iyPWIqOguf Y1cUD2vmnxcFRnR/P60liVWgxDLgKiDMzhhlXK+LsDbHl09fi6y5emVOtMO1pEIhsNfs LEy4x/4M+HTLYpE0BLX+zLYnGvLpF4fGy+lwrVkt90fvOiZZb26iRCLa9gQyKJj35sTq GXWi3hqdizFTsbEUJ4jVGOsRSokAetoMpiYL5UHmAiwQ92ARTYlI6xawGn2dxsMjri2p VB4fbOB4SrNA7IX/ukvnrf7gOKoIS90inH3C8HZ57uYOCFOyFrNYK1hw9siH3vCI+utv oZaw== X-Gm-Message-State: AOJu0YyiRLXaFzqL4F1uKYwtNHjU9WqTvotIEZEtEs8yBWgOQpEdwFQr MhFjVYACqjKDAMwvDhFbQAE3plqJyMSXSeTLvgzODLWTQITm33dHEaT50BhnhbONmlwSDnIkusD 82ShEVGdm1Fs= X-Received: by 2002:a05:6512:3287:b0:500:aed0:cb1b with SMTP id p7-20020a056512328700b00500aed0cb1bmr7326630lfe.24.1698683467869; Mon, 30 Oct 2023 09:31:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRdAajClQLfI8UNi2+tGCjjTj9MUSIZarD5jdmlcc1gAAUSTu27VbeMUcm58GL6U7UOb+lpQ== X-Received: by 2002:a05:6512:3287:b0:500:aed0:cb1b with SMTP id p7-20020a056512328700b00500aed0cb1bmr7326601lfe.24.1698683467485; Mon, 30 Oct 2023 09:31:07 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id k16-20020a05600c0b5000b0040586360a36sm12945400wmr.17.2023.10.30.09.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 09:31:06 -0700 (PDT) Message-ID: Date: Mon, 30 Oct 2023 17:30:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 03/35] KVM: Use gfn instead of hva for mmu_notifier_retry To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-4-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-4-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 21E85120025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8tkijk6z4tr4ywqt7xt67duge6mq7zgs X-HE-Tag: 1698683471-475666 X-HE-Meta: U2FsdGVkX180iwnta45xKB8OH/8BSjJ3amNpdwhK/6FLdw/2fm8HZXbSw3VmWbWuF9Zn1ODdwwysMb4okvdloTdGQ3FMon5RhKrUaQxgDXNMO4AdjzE56A3c3sAEDAq2lU9lMJ73a8ku8b7RZv2+FymGV3gUon9BkeA/tnAqfUDXgu2c4kIOVVGYWVdk6V4tqEYFlSeBrXEBc2tFppj4BzQjXVf/v0L57pTxiafC31j+nAPajkQKEPRpK3eEmebd725MbRnftvloola4MrtSYe/bNUutZEox1T01l2Vuk/bk0qrJVeGmZNJJHTQW5AU+E0/8WCiCsD5g+J8mbYINejrmwijbkf7zzVePtfDxZXAo556fV7FKx4xx9qaRaFUWVzSoiPwa2kSQXbIevwgjLHJxTgk9LqxLY1IC9ElWEV6jaBRbR9GZD2BzIzxtset8j20EAyItlXkL6jgJbaedLw7m8iBwRs0J4ippCEEC/wSfjL6/8UI9h1Hqc0155CG62irhGKe4fa0pQFkHbO9sYmMsXFIDK2G89eVBwfCs3gJoqnCwsHXLaMqEHAPVU70qAnJdEZYTitMxXofBy1DsSeCqaODU/Wr2Wl8K0LpMHqdGGcSn7O88pJYeNA6Y/CEFj807Fdhtd6d29GpBwjSO2xTsmGyaACBWSImx92oIPGr/f6BrDsUzLjjUXcnUDvKSMh7hKtonCshbMTGedR1N9jOBduUuujAkTQikdQuSHrSjBDstHNf/CX1HXNNZrqc8eneERAwnCfi3sksK7iGj3WMC48Rar7s6dykatDrj8wCibktahNQQLR/+jHQigEKeGBLafZbUSLe3O6rnKz9xvCIwOnee3WacTSmhhz0/SXBeZ6VSlgIRt+2BdhrU5PRpN5R0Syj9g4qX9Stpu05AvowxDuzUN1LMeLIhbI5S8+MY6/P9Cfr1zk1vI3Rpj5CmkmfN4Hy+8TDJpNowKBR 2B/ZF8lj NNjaY+vwnQP9dixzqiUDQ7ZPcYXrHnjsSagJNacUDLJWnLbqvM/315CTVRZxCo4MtNDobu5O9M9Da4v7JknTBWm13GSv3hTq8A8d4LQRKHlXZYbut1lFhqCXzKdhiqSb0CSl79j/BOL6aqjVgjEQsu0AZcN82wwo9+pvxqrmLzy4+RL+eclvXzWEl8kdo4d8hXOkYpeYf8wyd6UtDuKuGSnTXr1HvW6Z8LartyMC5lTSeC/E4PpUgrQWxpQ6vKo+u5AKgEh3RPLZ+m+THnkkCNbaZJoSdqFxDHXchccyupRWIn6WcWizN2FgF/HcLz52MsL7B8XIKRpPlUE+G9fb6yF/n6dv/KzIKxlOO8XcIg0fUgHsxLV1w62ur186EsGPAoowoVBoWizpNmkFjcO+h3CezmaqjNbXQy9NZ1ffN0GuB54J8E2xAqfq3H3b/wwEKYPrpbalyTIjtgW0fq7jLFXcrrDdYtGPLxdmG7Ib3MqEyd7cYpelN4PKbpLZH648RQIazQIKy+1B6D84R3FSsSH5KMQkD56vAC8mC+iJs9IS66zVQK3BJzodCI8qxGH+4NSCC7HgB3SFOWuYzGzcbE2FmDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > From: Chao Peng Currently in mmu_notifier > invalidate path, hva range is recorded and then checked against by > mmu_notifier_retry_hva() in the page fault handling path. However, for > the to be introduced private memory, a page fault may not have a hva > associated, checking gfn(gpa) makes more sense. For existing hva based > shared memory, gfn is expected to also work. The only downside is when > aliasing multiple gfns to a single hva, the current algorithm of > checking multiple ranges could result in a much larger range being > rejected. Such aliasing should be uncommon, so the impact is expected > small. Reviewed-by: Paolo Bonzini Paolo