From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712CEC27C5E for ; Tue, 11 Jun 2024 14:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3AA26B0093; Tue, 11 Jun 2024 10:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9EB6B0095; Tue, 11 Jun 2024 10:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D648B6B0096; Tue, 11 Jun 2024 10:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B8FBE6B0093 for ; Tue, 11 Jun 2024 10:27:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 68407C1010 for ; Tue, 11 Jun 2024 14:27:04 +0000 (UTC) X-FDA: 82218834768.27.273384E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 1E82920019 for ; Tue, 11 Jun 2024 14:27:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XoZisKO4; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718116022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2HiNGn5xfYCIbrsVN5hrCU13IWJUvVuXvExSlhDiVBM=; b=DbEaeSTKcvq7S+1yHWtUOb2Go19vXo3WBymggNxxFFB2NtDhJ92ZNgBk3gCdYro1zCz8xE OYOAabLx3XNwnIZP8QDnJ9xBnAo7tO0wp3kF+G6IjvgHD6oREfImKmEtBHWEa/2STOw7PQ xLfMPX6kk2xg5XabzjUuXciLZQdv1cc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XoZisKO4; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718116022; a=rsa-sha256; cv=none; b=OUQ3N9Nf7xbpMhvk6oYC4YHsLVnuR4YLbH35J40GHd/Xj9LjX5oE+A0yayGATPOHIBIW5+ M7stz2oUjedUGIa07ISyXrFkPOVpxa0lW4y+LYac9F44jHMxK4CU45d0Z+9Jam450Y8uZ6 xW1VreG+j5cLPmoc4sxjDAIwi9s48dc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718116021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2HiNGn5xfYCIbrsVN5hrCU13IWJUvVuXvExSlhDiVBM=; b=XoZisKO4UU9+IZMHwCFEGCi/hJQGgEeOZrvMGYtk4CW4odNU1otxBiEbPR8lPgdED5HkFR mnnHL0S9fXiMXkCvBwPqhJsR58q52sni88wwTqZ4FvBCjw7Y7rw0taCYPn07GijQpMLHuw OHSr6uyRw7P6TJ7oOB/b68S9cqIVZeI= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-SQtWXjNROwav_tL1ihhweQ-1; Tue, 11 Jun 2024 10:26:59 -0400 X-MC-Unique: SQtWXjNROwav_tL1ihhweQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52c944cf9b5so602147e87.0 for ; Tue, 11 Jun 2024 07:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718116018; x=1718720818; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2HiNGn5xfYCIbrsVN5hrCU13IWJUvVuXvExSlhDiVBM=; b=T3/tMcelhctLdKEal8Vqqox46oqcPim4FhEOHQNb7W40zCnaVM44f++E8Xd5e49igM +FrKowGL526nYAHiD64fTeKyNG3UCrKohFTHjQmBNzA9mYvj/PtehWExV9AzGjnT5ZLV VWnPvXE9JcodIwmIM+D57Z7o3vuO7MBVbOQ3pucDeu1gxI4bixAhOTSLZV5iaXYa4oXb cIH6PdrigamsQ4htfd/enr8X6ZHCZi1FW9QRL8GlzctG9N1SOiRTTj3U4hg4Gg03Yt+p m9doWY97/tTjoW8YBsIOhce6F969VFDclzPJ3y2vhIHnsnw+sRWMWRPfWMJa1IhCCdaW 791Q== X-Gm-Message-State: AOJu0YyAORX2NV1096VPYO/4e59M5W0kjBe0LZW4LGVEXGk22a9FoNhm NNibmD1HwBW8wmrzH+ka77APMgUcAqL+ugJf7bqSTowDVIxBB8JfjedlJdfjJXQPrGCkd++90qv HcgAaiMJuYK4q6ypZW+IC0s7sT/ExCS2gz6kqgSSuedeqgKAo X-Received: by 2002:ac2:4acf:0:b0:52c:7f31:93fc with SMTP id 2adb3069b0e04-52c7f319687mr4954343e87.48.1718116018114; Tue, 11 Jun 2024 07:26:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFU+mXt+zc2sITSaoy0NZJ0nNGZs41A9LiDmFArfW1j2T7+kcXNcWUH4WEPgwSChLSEE37u6w== X-Received: by 2002:ac2:4acf:0:b0:52c:7f31:93fc with SMTP id 2adb3069b0e04-52c7f319687mr4954332e87.48.1718116017663; Tue, 11 Jun 2024 07:26:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c748:ba00:1c00:48ea:7b5a:c12b? (p200300cbc748ba001c0048ea7b5ac12b.dip0.t-ipconnect.de. [2003:cb:c748:ba00:1c00:48ea:7b5a:c12b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f26355d54sm4854059f8f.64.2024.06.11.07.26.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 07:26:57 -0700 (PDT) Message-ID: Date: Tue, 11 Jun 2024 16:26:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: print mem_init info after defer_init is done To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20240611030812.9582-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240611030812.9582-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1E82920019 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: j1iwxgop7jd93nxgoc3y5w9mck7ke8km X-HE-Tag: 1718116021-504964 X-HE-Meta: U2FsdGVkX192NM3+x6/YFE2tQ3lYp5kjMAT6J3MJl4iC7BPkSHso/iJOSB2JfJnPfTBOFffm6ahHZxMYP+Yys4dR1Y8tL0PHuP4pMx628IxMDyX07fKw9OdrcOaMR10BUxj/dUOYTUBy44pwrvq9wZQYsLHLRDAZ4sGYJ9aMiLOM2FXnoHM3unX5MTZ25FJ3t5Ww+cPD78ITXCYWlq8HbdtKe0LeuHWCZS8LeCc6B1PzgyVzCsk8dGdmsO9llOABWhH/p2OCcRzB11wOjuJjLTBWoVT+XwTZ6sTcwHs3S0en52yvmLm/2IotdW4h9As/P6oTJCL/RpP1NxvjaWg5r9cBHUFrkmizYIJIxNX7fRiSPwXGxVVN2lvejjcxzXkWGGlS0BUu2XoLjR6zI/6x8+MUfNawhtJwyM5sd7CyHyC3p/jcMrjLyvkiZ2M2YhVsxraI6IdJxk8DIlsEGTrhMTHAwHNq/PSUsiwo/Regcs5VQaFAgZsHjTToCVPvLut9luE00NcFkhXJ5hiOf9MIn8ZHcsjCPR0Nmzdgu9jU2X+56mDn4w7Ui8QrVp1U6TC37yIP5qER0EBi4bDl150XCaWYFmjqjkBL5P2CNiONHve4VjkYqJpNG1tnGC8LmvRzJWuEPScfUrDGFeZCKkG4101a7BTpKPcBd3o3tZ7KQG2joRDLMIhLZqvI7rIfktsYXx2pYOgkUHuKkVtd8eu6DWctCI1z5HQby4vzzluPkpdWopWFUXN7upZZnaJxQjoLp22RIZK5/ySBuFYebPPHmsXBlOOxkrhVbLihspyQ6a1nHNHu4adxWQgrcpD9+k/ORqnIT5QPdQsCIDgUdWEvFbrIDcaYP4OriyLr/GnA+FIVUIT4Jd7mthxrNoU67y65vgGFVPnRdCnkUC8I9o/lSgJK9xaNjWcokPxW9jSMGiSlixYPIRTwrp8yEtLGRexVsH1G6jdGtfR7Q1S7D82 SDlauEZK fGapvj2MVxQGyDArl2pVzmITZcz9+sc681mZFYAo5gEo27qDSEUGaNrHccUGohO0IP79V8sgLkyNDhqs4J2DvsfOV+/2AqUk02Y5YwIcGPBjJqqmVMhafueyMJ4+J3CJ8sST4D19c6wTU4cYRQGADDGFw3EIvbB9acbklJOlc9LTBRcefH996TOmlMNLaqYfdN/5PMj3u+/+k6LcKkmnAER0m1TuPMzA4h208YP1xMsDTqgnnIUyfzvwbYWApB3DB40xRhf6E2s2fv8j5sfr/c/q0ACJvQ327o/SaEj1SGXdqKrSk4CLG1X2T0AsQ0WSUeknqxMjhbmHhwA8yKFsYMAIizo/I81IjyiM6fN8S70+1XxeJzp17BtcF0cWUsj/I+K6CGnWmhtyyQk7HnIRtQHOZlcAQnD8we+4Ib73IBJuClsX7edaxERS1wNEtdheeuwEEo7EmsopjXvO/guEfm7AwvVi5Ti4F/iP+2xJuKwy+YAL62eAjRtYZjXojLEgXp7noCoRjXmiBr44Wzh5N9BtlOX17rAd01TmQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 05:08, Wei Yang wrote: > Current call flow looks like this: > > start_kernel > mm_core_init > mem_init > mem_init_print_info > rest_init > kernel_init > kernel_init_freeable > page_alloc_init_late > deferred_init_memmap > > If CONFIG_DEFERRED_STRUCT_PAGE_INIT, the time mem_init_print_info() > calls, pages are not totally initialized and freed to buddy. > > This has one issue > > * nr_free_pages() just contains partial free pages in the system, > which is not we expect. > Maybe mention that this will also help changing totalpage accounting. > Let's print the mem info after defer_init is done. > > Signed-off-by: Wei Yang > CC: David Hildenbrand > --- > mm/mm_init.c | 104 +++++++++++++++++++++++++-------------------------- > 1 file changed, 52 insertions(+), 52 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f72b852bd5b8..34a6de20ef77 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2322,6 +2322,57 @@ void set_zone_contiguous(struct zone *zone) > zone->contiguous = true; > } > > +static void __init mem_init_print_info(void) Can you avoid all that churn simply by doing a static void __init mem_init_print_info(void); somewhere at the beginning of this file? > +{ > + unsigned long physpages, codesize, datasize, rosize, bss_size; > + unsigned long init_code_size, init_data_size; > + > + physpages = get_num_physpages(); > + codesize = _etext - _stext; > + datasize = _edata - _sdata; > + rosize = __end_rodata - __start_rodata; > + bss_size = __bss_stop - __bss_start; > + init_data_size = __init_end - __init_begin; > + init_code_size = _einittext - _sinittext; > + > + /* > + * Detect special cases and adjust section sizes accordingly: > + * 1) .init.* may be embedded into .data sections > + * 2) .init.text.* may be out of [__init_begin, __init_end], > + * please refer to arch/tile/kernel/vmlinux.lds.S. > + * 3) .rodata.* may be embedded into .text or .data sections. > + */ > +#define adj_init_size(start, end, size, pos, adj) \ > + do { \ > + if (&start[0] <= &pos[0] && &pos[0] < &end[0] && size > adj) \ > + size -= adj; \ > + } while (0) > + > + adj_init_size(__init_begin, __init_end, init_data_size, > + _sinittext, init_code_size); > + adj_init_size(_stext, _etext, codesize, _sinittext, init_code_size); > + adj_init_size(_sdata, _edata, datasize, __init_begin, init_data_size); > + adj_init_size(_stext, _etext, codesize, __start_rodata, rosize); > + adj_init_size(_sdata, _edata, datasize, __start_rodata, rosize); > + > +#undef adj_init_size > + > + pr_info("Memory: %luK/%luK available (%luK kernel code, %luK rwdata, %luK rodata, %luK init, %luK bss, %luK reserved, %luK cma-reserved" > +#ifdef CONFIG_HIGHMEM > + ", %luK highmem" > +#endif > + ")\n", > + K(nr_free_pages()), K(physpages), > + codesize / SZ_1K, datasize / SZ_1K, rosize / SZ_1K, > + (init_data_size + init_code_size) / SZ_1K, bss_size / SZ_1K, > + K(physpages - totalram_pages() - totalcma_pages), > + K(totalcma_pages) > +#ifdef CONFIG_HIGHMEM > + , K(totalhigh_pages()) > +#endif > + ); > +} > + > void __init page_alloc_init_late(void) > { > struct zone *zone; > @@ -2348,6 +2399,7 @@ void __init page_alloc_init_late(void) > files_maxfiles_init(); > #endif > Maybe add a comment like /* Accounting of total+free memory is stable at this point. */ > + mem_init_print_info(); -- Cheers, David / dhildenb