From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA0EEB64DB for ; Thu, 15 Jun 2023 12:57:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE586B0072; Thu, 15 Jun 2023 08:57:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9D8B8E0002; Thu, 15 Jun 2023 08:57:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3E908E0001; Thu, 15 Jun 2023 08:57:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 952446B0072 for ; Thu, 15 Jun 2023 08:57:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6785C1208B1 for ; Thu, 15 Jun 2023 12:57:04 +0000 (UTC) X-FDA: 80904982368.26.CB2C345 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 480C44001B for ; Thu, 15 Jun 2023 12:57:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fJlMg1aq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686833821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U9JHKraOZ8C9H8TNlUxicYfNReQUH9J26rOccgFXmnY=; b=tNje1iO9a1/PX0UjIShApfuSORlNVAwmX74HFj82jeepjbCWexhmOTcsWMOLmactpCS6H9 7WQHCniJ4dUOJYqsI7qgEr5y1/tBb023Z+CvYVRyPOvSUVNZor5m6Q8fY3I1zuwS0QbeUX TtGsBYI7xac8rrK86/Q7mEwi9fumPDU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fJlMg1aq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686833821; a=rsa-sha256; cv=none; b=RuJQFVZOTBzxiXQBWhw+YgZo2kvWS7CYpf4qoGYMQgcq4cwR+xiU6GIPtmpkFDxq5Xme0H zkZBsgEo2kyD9EBF9wcwUwuB7Ibhhej/23t71ct8ekX8jPV00rcId2ftuiozEX+cGoYPlw j1FzXJJ1tpiiBaAKtfwcrpJQ9pbINjY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686833820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9JHKraOZ8C9H8TNlUxicYfNReQUH9J26rOccgFXmnY=; b=fJlMg1aqvaW7O2pgnXQivSLTYHkz1rZT4RPrEp78NKSko5FH0cjPDf1opclcir1z094hzb /dn816JDDP8fzZJBgy7VxR9roJFeJ5yB2epgXHahwtVMvlCcZryvCP3rpYDWR3p22YDs10 FGEmpwOaXV3Mx83nGAkndKKyb14r3DE= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-ng5lYiolPbuIE47Z9YhG9Q-1; Thu, 15 Jun 2023 08:56:59 -0400 X-MC-Unique: ng5lYiolPbuIE47Z9YhG9Q-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4edc7406cb5so6512030e87.3 for ; Thu, 15 Jun 2023 05:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686833817; x=1689425817; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U9JHKraOZ8C9H8TNlUxicYfNReQUH9J26rOccgFXmnY=; b=J+tEcyu3yOj1sAObgt/Gvk7BBrtfYmpYgAhYYnhNXpkzg2h0bE089eIzXfyklmmfMI cY7AOQQQ1wZJpkUglatC3hdGy9chQ3LLUEPgNmetikc9XjytxYDCK6oCub/VB5aFXJ/1 bzO82YRAJWIGXr75OLv6LYA8GIK6MBIjmNqp0oWsDGGP+N2XGZYpLroSfNLKlgPJWXID PjKLOLBW9hIXFAsUDWkfPP3VJfPK1Zc4mXeMnQKik4BzE2dx2VArPxHC/iKrkP1pcOks 78WsV+zIl0UXB5R3HAvOeU5G7U8hVyFPMthbmvh+4nYWvkTbQlRA4OnfeD847a6aQrks ns3g== X-Gm-Message-State: AC+VfDyG3ycM5amWiv5Enw3cewYotLuVovwde2oqPiOWUTNqS/4tZmD7 w6GQQZT8BpOXwTUxWB7JUxbaapweUuj/WSJnuM/sFPiHkvwnCWoj2TGNRQkPdN5i1WzJCMmDf2n SaBXp0jz0Uxk= X-Received: by 2002:a19:7113:0:b0:4f3:b258:fee4 with SMTP id m19-20020a197113000000b004f3b258fee4mr9938778lfc.59.1686833817551; Thu, 15 Jun 2023 05:56:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7bSB+Z4QicTb+uLFFwe367ysrOFiLTzBu/nB3bSm2df/9oyOxwkS4isQmvmMoD0F93eQAiFA== X-Received: by 2002:a19:7113:0:b0:4f3:b258:fee4 with SMTP id m19-20020a197113000000b004f3b258fee4mr9938758lfc.59.1686833817121; Thu, 15 Jun 2023 05:56:57 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0acc00b003f195d540d9sm20419103wmr.14.2023.06.15.05.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 05:56:56 -0700 (PDT) Message-ID: Date: Thu, 15 Jun 2023 14:56:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: =?UTF-8?B?6LS65Lit5Z2k?= Cc: minchan@kernel.org, senozhatsky@chromium.org, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> <3f54542e-235b-8456-f13f-786d21c6c14f@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 480C44001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: he9j13ahumq8pdd67z5zndti5c8n3uar X-HE-Tag: 1686833821-747093 X-HE-Meta: U2FsdGVkX19kolRxBiJ/FRikybD98RGUZEa6MxZDJx96rbYHbyc99sjQNv5G/tKcl+59yOLFeeifFtZ4T7AeSUqn0Sl/wbRhARiCUIU16GPhfRpmOGATN5KhpG5UC8MA1Q/TXXiVdK2p/mUCh7Vc4s6sq4secIU95dQVwD4R+3bCTjdJYESeeV7RoCit/v8XMnyBrkzeDytahkrHpEqDUobHFgMHaARmkrDvHz/o9rtH8z3Zl+PxRq5Hle3XBgAOySDlVZvSp2HgvRDc0R4XO5dBYPnsvmf4uAlD/NTcYDEz83R7ieez9ICddyPcLwIxhmcpF8SEtjPJoI0VShSzWvrgWraXzXXMsj5IoTYsJrzvNYqE/ZHBBs3jP3AJgh4ic4nC2TI8WBk1H46aoev5VZTxUTud4Qac8/2zEqSrZgc/9Ghp9AE9wQf0EFIaZ47nKCxoTin4IagaC370eE2J3a1hNu9tN+eghMWk0DegVaYq/ZqQEWi3AlNVNGUfszEPKpa/24BdPc94RtRcIPSYkpTkhKJcj/hIIxkVBPuKfmjZxmVnlD3DlHaXsK9z8doyZriTI1Tg3/FQ3jpm36zWmIT0xm0Jaop/+nIaBskVf/93TSQFGj6n2KcnGT4LRKWQVwFR86ozoPpXscG6ST9v0tCgjNJPk1A29GUBb4a079NJlbm3at4OMMCxLMn+H7S+SgWGnwRsnuBm71OZbUWJZ3f3cRyKN/7r3yKpNWD9MkfWoPzyPS2P3nd3vrNbNL/iXVQl6nO2LTlAagzk1OyRGAkP3u10blw0qdBxJwagwZiqTn/Mqseh69+kDb//ZFAB0bm926obIkrlt2wuFqEsq73wErWuIKMkG2eueTKKD6s+fDrFe9Zfzt4Y8GkqS3FhwWIfcRQDs1gYshZ0RH2LpQhQtNyjibe34ZtJ7+XjK2e3Jd4eHdFexSr6CodooOd9F5/xo3u4HKxlLV4U8k2 k/K+qOqV MCRL35CyfFvwl6hq0jDGSDGW5ox76aGBWHHr3VeuLqqqSWj6hRyLZ+/KYnMqDn9QaenSeK1ZoPzyAR2PmDeLN64KiVBYY7w1sqmj0pV1JH8jLVTtGR7NnNyBcPOAYFCIhdPuiK2LCTe1a6QrMC/MMHFRBVl+gG1/53lPPY3MR8J7y7qpgTFYr+jM5FEgovdmtXdd9D64yb29fR59mQzp8YH/rAdlK2Xlw4Hj8ErOmHT2oYVRD1nR/4pfYuw3084Uw0EzQ87Lq1B/O+rqwKdUNkWBhcQWoFYFQr16EQafkfl+xD2Cfs09AsIULbbd0SvhPHBdEVT0JfmcszHK42dTiXWsNjW2MXPHY3VCOHk9T5tHkJxy44dLfHNhh0v0uo3mPtbzVuEJnse/LmkMwX78Rh3Un06XJ84n8J9ld4j97onYyCjpA2Ro/eDqH2rR0MiB9SrGZ3NECgC0g7MY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001424, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.06.23 14:19, 贺中坤 wrote: > On Thu, Jun 15, 2023 at 7:19 PM David Hildenbrand wrote: >> >> Yes, but my point is that there are cases where the pages you get are >> not charged. zram_bvec_write_partial() is just one such example that >> highlights the issue. > > Sorry ,I got it. I suspect for the swap->zram we should always get charged pages, because we're effectively writing out charged anon/shmem pages only -- without any buffer in between. For the fs->zram or direct zram access device case I'm not so sure. It highly depends on what gets mapped into the bio (e.g., a kernel buffer, zeropage, ...). If it's a pagecache page, that should be charged and we're good. No so sure about fs metadata or some other fs cases (e.g., write() to a file that bypass the pagecache). -- Cheers, David / dhildenb