From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Colin Ian King <colin.king@canonical.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
stable@vger.kernel.org, linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: bug report: hugetlbfs: use i_mmap_rwsem for more pmd sharing, synchronization
Date: Thu, 27 Dec 2018 21:26:09 -0800 [thread overview]
Message-ID: <bcf7e166-9d01-1085-fb28-b01f020c7a1d@oracle.com> (raw)
In-Reply-To: <20181227184518.4c689fcdca88325b841dfc71@linux-foundation.org>
On 12/27/18 6:45 PM, Andrew Morton wrote:
> On Thu, 27 Dec 2018 11:24:31 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>> It would be better to make an explicit check for mapping != null before
>> calling i_mmap_lock_write/try_to_unmap. In this way, unrelated changes to
>> code above will not potentially lead to the possibility of mapping == null.
>>
>> I'm not sure what is the best way to handle this. Below is an updated version
>> of the patch sent to Andrew. I can also provide a simple patch to the patch
>> if that is easier.
>>
>
> Below is the delta. Please check it. It seems to do more than the
> above implies.
>
> Also, I have notes here that
>
> hugetlbfs-use-i_mmap_rwsem-for-more-pmd-sharing-synchronization.patch
> and
> hugetlbfs-use-i_mmap_rwsem-to-fix-page-fault-truncate-race.patch
>
> have additional updates pending. Due to emails such as
>
> http://lkml.kernel.org/r/849f5202-2200-265f-7769-8363053e8373@oracle.com
> http://lkml.kernel.org/r/732c0b7d-5a4e-97a8-9677-30f3520893cb@oracle.com
> http://lkml.kernel.org/r/6b91dd42-b903-1f6c-729a-bd9f51273986@oracle.com
>
> What's the status, please?
>
There was a V3 of the patches which was Acked-by Kirill. See,
http://lkml.kernel.org/r/20181224101349.jjjmk2hzwah6g64h@kshutemo-mobl1
The two V3 patches are:
http://lkml.kernel.org/r/20181222223013.22193-2-mike.kravetz@oracle.com
http://lkml.kernel.org/r/20181222223013.22193-3-mike.kravetz@oracle.com
The patch I sent in this thread was an update to the V3. The delta you
created was based on V2. So, the delta contains V2 -> V3 changes as well
as the changes mentioned in this thread. My apologies for not noticing
and clarifying.
Let me know what you would like me to do to help. I hate to send any
more patches right now as they might cause more confusion.
--
Mike Kravetz
prev parent reply other threads:[~2018-12-28 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 11:44 Colin Ian King
2018-12-27 11:44 ` Colin Ian King
2018-12-27 19:24 ` Mike Kravetz
2018-12-28 2:45 ` Andrew Morton
2018-12-28 5:26 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf7e166-9d01-1085-fb28-b01f020c7a1d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox