From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D22EB8FB7 for ; Wed, 6 Sep 2023 08:01:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1878440149; Wed, 6 Sep 2023 04:01:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C7E98E0014; Wed, 6 Sep 2023 04:01:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 868A7440149; Wed, 6 Sep 2023 04:01:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 784608E0014 for ; Wed, 6 Sep 2023 04:01:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3ED37B4036 for ; Wed, 6 Sep 2023 08:01:03 +0000 (UTC) X-FDA: 81205426806.10.3DB9C2E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 076F420025 for ; Wed, 6 Sep 2023 08:01:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pb4lNhvG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8aX8Ngai; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693987261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Th6i3Ci6XMV5czHwHHRQpy4WXZpYK1vSc4mKPzvASOU=; b=WrhwepbHRIvlMSPK2ph5vGGiF5aFen7+NbTPW1ysMamMx3D+PWRxSzJGOKq7tQmmRFZqFM 5mLwYfuH0GOI+jLVk30FYPHufGG3I6Gy8NYu8KKURDKJlgvcy7HxpTpO5dLQBBan6+th2P WlzGxs6nrnks7Iq4JyVklsWYm/4q3vQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pb4lNhvG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8aX8Ngai; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693987261; a=rsa-sha256; cv=none; b=IkPUgYgqRrgLWoTmZq0ZE3HrTQ0V6NFrK3TZzvcq8gVoK8lZAoQI3xjbdEUlpVh9TKRLCP ft4kMj/t3wRthU9J7DByeGV/uaDJFS1TBZsJt3xT7o1AJ7oZlmUmrrggR5aqybPhWoif7Y QbOWcjGEiZTBZkk8yRQVWnf+MmTyMkc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9201222407; Wed, 6 Sep 2023 08:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1693987258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Th6i3Ci6XMV5czHwHHRQpy4WXZpYK1vSc4mKPzvASOU=; b=Pb4lNhvGotAuMduqcxpX1veGfBW2fSsxbs9Pu7MCDvZuKYqbhIBY10E+hTUliKOLBUS8xT IScFwkZq92rxWtvku6iqGuFuVgR5lDAVbkoOihu7XH0KTBnfaYqyy4A7lldnkADZSSK6sy waSNnkdND+zVot6yoT1DyeMpgGyp2zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1693987258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Th6i3Ci6XMV5czHwHHRQpy4WXZpYK1vSc4mKPzvASOU=; b=8aX8Ngai6ZtyQlD2914oRoaCD9456/pp3O+p6YtiEHc05I1uh8Iu/T2mBUnSMDxI5k/fIo p/VLTw2WkzUAHvBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8ACD11346C; Wed, 6 Sep 2023 08:00:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2QG0ILkx+GRiVwAAMHmgww (envelope-from ); Wed, 06 Sep 2023 08:00:57 +0000 Message-ID: Date: Wed, 6 Sep 2023 10:00:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH gmem FIXUP] mm, compaction: make testing mapping_unmovable() safe To: Sean Christopherson Cc: ackerleytng@google.com, akpm@linux-foundation.org, anup@brainfault.org, aou@eecs.berkeley.edu, chao.p.peng@linux.intel.com, chenhuacai@kernel.org, david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org, jmorris@namei.org, kirill.shutemov@linux.intel.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, liam.merwick@oracle.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name, maz@kernel.org, michael.roth@amd.com, mpe@ellerman.id.au, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, paul@paul-moore.com, pbonzini@redhat.com, qperret@google.com, serge@hallyn.com, tabba@google.com, vannapurve@google.com, wei.w.wang@intel.com, willy@infradead.org, yu.c.zhang@linux.intel.com References: <20230901082025.20548-2-vbabka@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 076F420025 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5ss6ik1sgi99f41g3c8aspphhjczbgwo X-HE-Tag: 1693987260-812629 X-HE-Meta: U2FsdGVkX1+yaWwpNwuEju5uUDF1x0IViOMJ2Om9kto00eie5VTbRs9qp/daKCnJZCND3xaGc1mU1Kayr8KzujIGYX+eTaCnPzbn/zolBXxbp7XMehPm+u4B5DWpBp6kvmIzg0VXk8fZcrMPD0AZsBOa3z1DJQIU2XTau31Eh5MCQvO49yIIXbZqWQq8sERoTjUJYWmEL8Sbuk/jYzgzjedKsiJA/cEtr169CtOMfZABJzU9FotTqfIFYy6xq0Xp5p1vQVHgFqUgLLOjAG+kxffovAdzJKnN4ZSkc9RWz8CxJpWOrz+/wiXF13ilMGHyCR3PoSmdm4BtSCTkaaJ03IwyIs9d467jwNhFq6cbSr5+v9ic5tcrkHpxkvlyGiA4cPNXp+T4o3JzssLTJ89a6umnBKEAei9vZfN3y/V3E14v6KjWD1qzmTKdnydKaTOTtSBF4ORgLYVnoUvu/VfSOgtGYhIDvAb5WjVpXUrw29VGqbN+165msKHoSrYoRBHxdPVEcPZaDK89sadtkXs7sGgn3VGK35QBrkWkaUElq2B7rurFMBDVG03L3Q6CcLC7K9eENhXwCl1GDeuMEAR794s57vD4ruRAdHuSiviEX6+furTCgJBi2TSMYtt3NgY+TyEFI2eD2F3Q6Qq0CyNbXSSUiodwT0LlM+R1Qt5MS/cqNeolIMkzNjRbLpvQH4df4o2MzCsy4F9Pb5aNLE7HSf145JW3XjSw840U3wl+YhdFX5dQoLLdX2zsWE0IN862lDH9hgZ6M22f+5yiHLm1hs0qcYz+jT2BmQ5ob+VOqifo+/eDhWhKES6vJ2O9fuePojitwUf65ZDZcQ85VkaEgbPL51os2z76Pvy9yYSYEeaEVrpwPvciHwbgxONexuXkTUpPmuc1uX9Xq2oW8FRGmdymn/5ynuQXAEemHsLoygrQyAM0jtdv94CE1DTU6YmxlkgeJQgMGEDh3iwejMl yMr74fV4 v/HcrXYxd6ynHf/8fkYl6cAVhFjpD24V0A9a04OobQFz9mB392swzqQUYy3hD4BTzzhFpBmQCAQaIpHGRXlFy09pquhHe7TSNuqEKn5idHDAzq8dhB1UOLG0zBrmg99voE4RzVLd5mNTV25Io1XDLejnfo2nPJ/CvRfsbK/hIFoorCLFyUX7jnnh480NBWH541y5vrUr195Fuex6DkunTOykAjdL+/1DntGZuuk9hh3hoDOpBT3ynbJP3DUMQe6HHT2vpEz1QvrGhp4nb51kfk+Jl3vYEQ2YQW99PwpldLb8GTKTtQgq4gjf10fvT2AqyizwP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/23 01:56, Sean Christopherson wrote: > On Fri, Sep 01, 2023, Vlastimil Babka wrote: >> As Kirill pointed out, mapping can be removed under us due to >> truncation. Test it under folio lock as already done for the async >> compaction / dirty folio case. To prevent locking every folio with >> mapping to do the test, do it only for unevictable folios, as we can >> expect the unmovable mapping folios are also unevictable - it is the >> case for guest memfd folios. > > Rather than expect/assume that unmovable mappings are always unevictable, how about > requiring that? E.g. either through a VM_WARN_ON in mapping_set_unmovable(), or by > simply having that helper forcefully set AS_UNEVICTABLE as well. Yeah I guess we could make the helper do that, with a comment, as gmem is the only user right now. And if in the future somebody has case where it makes sense to have unmovable without unevictable, we can discuss what to do about it then.