From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F94CD1292 for ; Thu, 4 Apr 2024 19:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32576B008C; Thu, 4 Apr 2024 15:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3246B0092; Thu, 4 Apr 2024 15:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5C586B0093; Thu, 4 Apr 2024 15:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 827316B008C for ; Thu, 4 Apr 2024 15:20:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 312E61C0256 for ; Thu, 4 Apr 2024 19:20:15 +0000 (UTC) X-FDA: 81972815190.19.66A400A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id CD89A14001C for ; Thu, 4 Apr 2024 19:20:12 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g8ywuZrz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712258412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gHJ8l1w5MGIDC/C/OQ5oUJg2N7gsWWlVSll0BER1pJ8=; b=w9N67ghalKkCtDAeT5SdsAylAg1Uaa/wS9I3suf6CYxB6T/Ly/+Js+Gd4Gp3mHq3gRYBzb ZjPYvtp8jlqHbV4tmdIU1+ONIualKxW0LHT5dXB5eY36lTU1pzr/GTAsTltTC0IwhCI/Qe qII2O+7bZmrx0Rwj7VTXTDA7luVUm6I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g8ywuZrz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712258412; a=rsa-sha256; cv=none; b=H+M3IRrPoC1zaw5Kzcq8caD8EEUp/HREKI/s4wzPWwHBM5RXE72XQ/9OL/rXn5S+4JAd0L hs7rQ3WNEziw5wn0wMHa5pHoaWYtylgQIP9wRxh7YR8YryIj2FjVg1f5tHDkaiR7WOsUVI EKAQZgl3ZtXaaF8KYp3W/HD6YlnH9AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712258412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gHJ8l1w5MGIDC/C/OQ5oUJg2N7gsWWlVSll0BER1pJ8=; b=g8ywuZrzseK+b3p1NcaM+2U0ICGgg5L/sg0J3/y8iPfpRNM+qml4mbyeMV38S7/QszHzMY r5aZN9fhA5Lo7jjdj4BQxckjOspuVpLAk3FahncRu+7bQ6/EVsjzeto/NO4BDz2qGamqyQ NQUK4ADrAuRPxbt+r4n5leqTQXp7j84= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-JW99QzWkP9mP9rEtDDKsOA-1; Thu, 04 Apr 2024 15:20:10 -0400 X-MC-Unique: JW99QzWkP9mP9rEtDDKsOA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d81d7b2f00so11734281fa.2 for ; Thu, 04 Apr 2024 12:20:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712258409; x=1712863209; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gHJ8l1w5MGIDC/C/OQ5oUJg2N7gsWWlVSll0BER1pJ8=; b=Sx64/RGbcRoXca6xO4XcTh1FJRUr3WNeRK6rtwnU7UlaRRBzPdejnSKD6LkflFd2Wq TsyiytIDzhgp8U1eIfcTXG3E53+JdLVG/pvLQ2Fa82HH5pWPB5DZbcHvIwdb7VL/cKbG z8OiN457n41OEfohIVYT9Ig4nsM2qyQZu33QTMYavGZ/zerhKNqG3eUfFr2xEkhOAGGh B0TEkP5IFe+YofvKAxzhUUPcTE5EKtUeGhjVK84lg4CkqbiHXsrf6jhqtVu0ddcxlPVm LTt/6PLJli85W7g3ye6LkSuHraWxmf7phyhXOsVAo/CMr4wxJ4G4oBtNP/rfNQ8XtCVb 5KkA== X-Forwarded-Encrypted: i=1; AJvYcCVAEhrVtdr5bWdzuE9AXSOv29PcH9wgDiG54Bw4PMclNTyakXoD3bAEOc2Yg01VxKRVrj9mUMq51a4KyaE4UEoAA9M= X-Gm-Message-State: AOJu0YxxQ1f4gY7WCBmfHPZWf3uwFsghseqH+mFCHMebj9n7ri0+lUHw nj8e2c83xc0iywi1SfDVBrbBOsd8OGBvVwW0p1pUFEFCaqdJ2WJTY5bGdTzAJkmBXX/+0u1XxH7 o5rCvWHgGzcxsskNic7vgEwXw4Vixzuky8qvO9daoKMDfAcnn X-Received: by 2002:a05:651c:151:b0:2d7:b78:4109 with SMTP id c17-20020a05651c015100b002d70b784109mr2644644ljd.53.1712258409366; Thu, 04 Apr 2024 12:20:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHX4QgSv00a5qrzc42JQnNOpczYt+OzketcyTgobwoWx0oH5Lr64hxXX6j9c7hVjuDjn8/icg== X-Received: by 2002:a05:651c:151:b0:2d7:b78:4109 with SMTP id c17-20020a05651c015100b002d70b784109mr2644628ljd.53.1712258408866; Thu, 04 Apr 2024 12:20:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:de00:7030:120f:d1c9:4c3c? (p200300cbc743de007030120fd1c94c3c.dip0.t-ipconnect.de. [2003:cb:c743:de00:7030:120f:d1c9:4c3c]) by smtp.gmail.com with ESMTPSA id l17-20020a5d4811000000b003433a379a51sm99468wrq.101.2024.04.04.12.20.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 12:20:08 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 21:20:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] x86/mm/pat: fix VM_PAT handling in COW mappings To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Christoph Hellwig , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Dave Hansen , Fei Li , Nathan Chancellor , Wupeng Ma , Ingo Molnar References: <20240403212131.929421-1-david@redhat.com> <20240403212131.929421-3-david@redhat.com> <20240403151249.0f4fc5b4f8c07630fbbb6338@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240403151249.0f4fc5b4f8c07630fbbb6338@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CD89A14001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bpc6syukxys7ixcpr4839wmjuz499whd X-HE-Tag: 1712258412-426243 X-HE-Meta: U2FsdGVkX19ymYxYwtCeqhkQjZ89sYFYEQNjzhCI+8P5Q/XOxIMnGoLuTEBP/3jui9jj7XoXRpSITFRTq4ppKcloQ/G65D7SKcV4HW9vEjD7JKSMXtnZs0OInKpIsh+6/uqcRSzlnjMIumZUjjAHPRVCEMXDKJg49ELnaXzDjaUw/nWLW31PuOUZsgRwGlin6R5XJlMnBQtbFXGLPlFbIidCnRL5G/reoHPJ7snozuuMFzGLEXkB8fwq48H5jGDeW/vJd81DQsRqvgv85rGfw3YzXi8xUGDouCn7LZo9O7WY8woHkbbCYxcTSLj0tJMxZSmLYcyIGnOm77O3a1KOzipyuX2dd4P53Uiqnwh+0mZEHfD3cdohthzUSa3ps1Wprzft4FtzWjlRoGW9/kyJN7/tL5YunxYgGYebPARrvJ55J3cww98QcBtOV05tPMTeKWxJtjj6gTGzou5IV7x4JA1t3NV8Kc8VHyH5s/8GJ0wCRwCQ7WF+HgadE+TB27kGmBp8dDP+x02by8jUK4KmR1UqgsaJw1FT1DsA0q/Zv/jP9OcOgOHFYzr91vx0CtE8xYjWeNN/KcwLHi04VhTU1JBEmKhBQr0TD1YQzNH7/TdZ8szeJbblnuQj66Zt+0lbh0LKTJlIag2pARgrVaKwqeir9810IebyKVYTwN5+E3VEaiuCwm4XNvngRHUoKvcK/caq8wz3iIIhxLP02PSM5hs9FoYK42FN58cMVvo12WHYZeiwFQ89/OyHNJjNSwCk/KQgwe/MiJ6vRIp3ymASr9Mqr0lBXjkJo895UcV3RhFMdE3/cPoRahB8H0//Dnjm+QBv6CXSWX0dKRIUMfTiXX0Q0A+fXWEuUJ37uYu0sBIg0CFkvJdKpg0lu4psZfYvA0Ji4Jh3MgZF2yPsgoMZmpHJbrCES6n7RcGCriRjV9dxCxsdql7TSFFcRxnUHwF+5WIoPdcqCMYizO/F49q J5cWrwrJ W5aZd6/8SuKb2nkDffbmAnTvsTFcj0gjQo6CvaV7Ed3kf8dNp3+upda3j5eQh5AALv1DpWMWZ5og3oQhT3k8E5jxzg4m6aXGfaXtm057aWSNULYOYGDv9BabUNYbAMYPeXsVExxkZKOPx35LKoHa1xCFNfiuu+QBlWq4AIOJQRL10y1khhpXSB0CCnL3EM4pjpfvnv2iy4Hcsd9XAuYmPyB9aPPja45iF3y8dRaUX51e0gZZTSjM+lZvGOE43NaXpIds0QZpMG7RSPFCN8iCA7tixbv07SkO0s77+MKdMlNjkf6c26r7ZUBcgYQU5SKsWarUEVrKdWexnXJomMj27nR2zNctCEI1mlEm+9Od65TPtNnXN8jJu4hrmQh2Swf/Q9gSxjziUENy9ZeLb3ou4f0WsrHvVNWyBfJ12rU3FBazaGmbyyXeV9uju3eJDuQa/DCGIyuMqpstv1OBPorxR+mq8IHq1WnBvdTgwZqEfaFgWSFa9oTSsFt7ZAc1CWdDsruuTbSzeRMDwHoK/XJBkCRgKKFmkRNsJBd3bP85+L5U7+OV+zOYuCcI7FO57L2ivgPM/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.04.24 00:12, Andrew Morton wrote: > On Wed, 3 Apr 2024 23:21:30 +0200 David Hildenbrand wrote: > >> PAT handling won't do the right thing in COW mappings: the first PTE >> (or, in fact, all PTEs) can be replaced during write faults to point at >> anon folios. Reliably recovering the correct PFN and cachemode using >> follow_phys() from PTEs will not work in COW mappings. >> >> ... >> >> Reported-by: Wupeng Ma >> Closes: https://lkml.kernel.org/r/20240227122814.3781907-1-mawupeng1@huawei.com >> Fixes: b1a86e15dc03 ("x86, pat: remove the dependency on 'vm_pgoff' in track/untrack pfn vma routines") >> Fixes: 5899329b1910 ("x86: PAT: implement track/untrack of pfnmap regions for x86 - v3") > > These are really old. Should we backport this? I was asking that question myself. With the reproducer, the worst thing that happens on most systems is the warning. On !RAM and with PAT, there could be memory leaks and other surprises. Likely, we should just backport it to stable. Should not be too hard to backport to stable kernels I guess/hope. -- Cheers, David / dhildenb