linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>,
	akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org
Subject: This reply comments on the patch to fixes the missing a blank line warning
Date: Thu, 11 Feb 2021 11:36:58 +0100	[thread overview]
Message-ID: <bce53689-4a6e-c3c3-a09c-6e946a577f61@redhat.com> (raw)
In-Reply-To: <20210211072918.376837-1-adithya.chandrakasan@gmail.com>

^

Please create proper patch subjects. Nobody has a glue what you are 
doing when looking at the subject.

"mm/util: fix ??? warning"

Which raises the question, what is ???

Compiler? static code checker? ... ?


Thanks

On 11.02.21 08:29, Adithya Chandrakasan wrote:
> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>
> ---
>   mm/util.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/util.c b/mm/util.c
> index 8c9b7d1e7c49..60286876636d 100644
> --- a/mm/util.c
> +++ b/mm/util.c
> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
>   	unsigned int len;
>   	struct mm_struct *mm = get_task_mm(task);
>   	unsigned long arg_start, arg_end, env_start, env_end;
> +
>   	if (!mm)
>   		goto out;
>   	if (!mm->arg_end)
> 


-- 
Thanks,

David / dhildenb



  reply	other threads:[~2021-02-11 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11  7:29 [PATCH] The Patch " Adithya Chandrakasan
2021-02-11 10:36 ` David Hildenbrand [this message]
2021-02-11 17:59   ` [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Adithya Chandrakasan
2021-02-11 18:20   ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan
2021-02-12 10:14     ` David Hildenbrand
2021-02-12 10:22       ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce53689-4a6e-c3c3-a09c-6e946a577f61@redhat.com \
    --to=david@redhat.com \
    --cc=adithya.chandrakasan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox