From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF8FC4345F for ; Fri, 19 Apr 2024 09:14:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72CC36B007B; Fri, 19 Apr 2024 05:14:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DD946B0082; Fri, 19 Apr 2024 05:14:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 556E66B0083; Fri, 19 Apr 2024 05:14:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 38C9B6B007B for ; Fri, 19 Apr 2024 05:14:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D01678077E for ; Fri, 19 Apr 2024 09:14:30 +0000 (UTC) X-FDA: 82025720700.30.C65F3DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 441014000E for ; Fri, 19 Apr 2024 09:14:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dIE4jOrf; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713518068; a=rsa-sha256; cv=none; b=K4uCr2vA7g9iwOUGjM85QofP4cZxlnkESEz6l9gtV0D+iBY5osQBtDKshVnJ3wXe6/Q40U qgoI3vzmpEalpbrW0newFHSTgKJUtkDTIWv6qzUMzmFPZZtKcDeoagLoDCIbYR8PVPjcBb /g52BLJ+aEeB3p8kIVpIVKCM/v3wpRY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dIE4jOrf; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713518068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqwO0572yowA0TBakaonePZNHGnWtzDXOOjoM1DutVs=; b=Ix06ezJoQAHYfWiVp3YcrvyGAlEk0FEao0BX85Js3XjS00nujjXvpUW9xnwryELamE5vgH 8oJMZtY/caAAp/e7+ukVYLhttKCEs/WdrFWOWHFNEtDeV9byglzFPHWfjPJsHWuys2SVI1 a7epvw2YYs/L/6qxiqWUaZP1+Q9v31U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713518066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EqwO0572yowA0TBakaonePZNHGnWtzDXOOjoM1DutVs=; b=dIE4jOrfoTcm4ARMn2+jcQmrE3x+llUpBWzBS9lf5eVyz+EZRFiwRTaBRoctgEQf5ZbF83 0F1Fvs/R0kZ9L+DsaiTE03uGEv4KqV90pqYOZsA8w2lnGvYhyMwgJx+wyCCpYKEUBsCGDX /xMASaWKl2phmblyTduSLU3xG/HLVaA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-oODI6yKwOc-hBOxAfb0Zvw-1; Fri, 19 Apr 2024 05:14:25 -0400 X-MC-Unique: oODI6yKwOc-hBOxAfb0Zvw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-418f18458a0so7228145e9.0 for ; Fri, 19 Apr 2024 02:14:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713518060; x=1714122860; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EqwO0572yowA0TBakaonePZNHGnWtzDXOOjoM1DutVs=; b=g/Y181xAntQco1P+wgk1EL08pUXBRAlCvVt/uPkRbI1bd6I5RWfcJm5A8VDGWHda+A 3J5VL4lRNt6sxFtYKlmKMi66PIZv8TmOsNoOvrc+7rpBxDw1936bhu0hN9Qr7c82K6C6 0UDcH3yAzCpsJ7NgD++yME59tmAY6cKnaNr0qQpk+zK0hOtwsASyK8gGznFM3XrvkwnC YQo6sBXMXmB4uy+IDRNGMkCUuJhpgJ47PF/XNlVNX+D4E/b7afaik64zgiXaQ20hHeTg HnP5vYkIzkDUH4NlXsHbMdHVIm6QkOkaPI6IFOV7t0+otY9MwJ8lyTQtTrMxK3e393W4 hRtQ== X-Gm-Message-State: AOJu0YzBexsKmfz35RvsvIv6x+6jWnm6GvW+jMDsJGi8vQx1hFwcIUeX 0/kJPj5mtDeGeDfabAUqA2wEF86WxIhR9h9lp3CII6MV0luCYHOLSBnozXYqsJMgMCQ2zZWsg1S V6+4ISrPaXA913qlWRla9mqHUtojJNFyMIglHtCg1W+JcUKGy X-Received: by 2002:a05:600c:c16:b0:418:fdcc:7080 with SMTP id fm22-20020a05600c0c1600b00418fdcc7080mr1087556wmb.12.1713518060737; Fri, 19 Apr 2024 02:14:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5KCUiiuZF9OZuh6RkThz19zIB1mi9FMS0XWUZ94xu1t5eHJnPpGKa3Ly3AFrnJLxt6FqYug== X-Received: by 2002:a05:600c:c16:b0:418:fdcc:7080 with SMTP id fm22-20020a05600c0c1600b00418fdcc7080mr1087525wmb.12.1713518060295; Fri, 19 Apr 2024 02:14:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c716:f300:c9f0:f643:6aa2:16? (p200300cbc716f300c9f0f6436aa20016.dip0.t-ipconnect.de. [2003:cb:c716:f300:c9f0:f643:6aa2:16]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c358f00b00418ef96472asm4398962wmq.0.2024.04.19.02.14.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 02:14:19 -0700 (PDT) Message-ID: Date: Fri, 19 Apr 2024 11:14:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/18] mm/rmap: always inline anon/file rmap duplication of a single PTE To: "Yin, Fengwei" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-sh@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Peter Xu , Ryan Roberts , Yang Shi , Zi Yan , Jonathan Corbet , Hugh Dickins , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Chris Zankel , Max Filippov , Muchun Song , Miaohe Lin , Naoya Horiguchi , Richard Chang References: <20240409192301.907377-1-david@redhat.com> <20240409192301.907377-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 441014000E X-Stat-Signature: gumhdj4hzkr1jjtf6zt1tm7w66dhycm6 X-Rspam-User: X-HE-Tag: 1713518067-376446 X-HE-Meta: U2FsdGVkX1+ID4L4+ANIjpSVD8RVgdX5KBIoeAghDcC+DZ5aY1v1yiLrCOqsSoAugPXFXFqov5ovGIXCMID1/zwrySpj/xYejdkUpRLq+wm2cx4OqRGp+4+mw5c1KuxB3SAOMmsHQrmtR4RU2mfucfbTuMRTb5UICUxBDeKPoIpS0IgJPq5ttxArQpKtnRmEZ9ockuOQMaxO4Oy2YfN3hU0ZO6pWSdyEY703SahmioiQTi/DjqW4WyDfL7Uli0XNXbarTxuW/fHhTIjyNZWtTfAxM0lIYVftqaJHF26D+f+TmVcKZfs+8lTpWKCtfpjJNjS/Oxg9SDK8Virsi+GwgDGz3kzXgbB6lpbLVIk9Wobt1P5wzF6I+JtFO89W0ds+g5/Ibr607LtcB5sLHoKwdjKY5ohXvMW3RO04zk76K174uDmirNEyspTjZOfRlARXerGjBLSbYMOVId8aGTBChptwt/UOt4BVdaDTMEC5UjWU1aY5/ekmlWSuY+qQX0D5XND8UZcppf7xO4eBBhfuHXEqiGE2RKFWpb37mDFaRhVnM/zT+Oq7yLa2CfljzOCiy+OGcB4AE6ICNLnEQQ6Bp5fLeV9kpQ3QC+ocKy/nzK6ewZNbtAmF0C29C5SD1lNIW2d4mamY9MbbbI9nFcq8UIR89Q6q5cGTq5wxIxv7i6eqEfp+U2cN33BiO4FdKgP9sYRmE3x1+qVmRus3PiH5tAAnzTUbXcYFtwa5BvE79qMZHiKYYnIJnEtmrKqeXc7UbjbrCVedFdLy3IaI8bMBrL4IGfrdm5VCSN9/w0Ki0sAQDSPrtMnwSArjbQzrO+hEfTdICVbTjO9HBMNEtdP85wr/rEI9Wb6W/3JBWEhBQ733C+71hwyD9+NhqETAqXr+qxztblpBD0J2Ppsv6vl6Uxcqc4MGkBdprs5xrOSIcQGvQv1fIlHfUIwMM7EMgb+qM1i5kKuuCyZeMoQPXmu vw8PFibj SU/Aojs73GYnzB+eWf5UY1K8ygLH5OQ5/7EvBgP0y6WiwFPKYExd+WNvWuh2Uu9f6VqcfFz9xAAEQ2KtKet5SwMXSFs5GxvvVc4Uz/puLcksPi1evipoLdBtlofPlOzURVp1IazvJGzOZFKJmY48UUMYPYDbaA1t8OsZR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.04.24 04:25, Yin, Fengwei wrote: > > > On 4/10/2024 3:22 AM, David Hildenbrand wrote: >> As we grow the code, the compiler might make stupid decisions and >> unnecessarily degrade fork() performance. Let's make sure to always inline >> functions that operate on a single PTE so the compiler will always >> optimize out the loop and avoid a function call. >> >> This is a preparation for maintining a total mapcount for large folios. >> >> Signed-off-by: David Hildenbrand > The patch looks good to me. Just curious: Is this change driven by code > reviewing or performance data profiling? Thanks. It was identified while observing an performance degradation with small folios in the fork() microbenchmark discussed in the cover letter (mentioned here as "unnecessarily degrade fork() performance"). The added atomic_add() was sufficient for the compiler not inline and optimize-out nr_pages, inserting a function call to a function where nr_pages is not optimized out. -- Cheers, David / dhildenb