From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <willy@infradead.org>,
Matt Fleming <matt@readmodwrite.com>
Cc: adilger.kernel@dilger.ca, akpm@linux-foundation.org,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
luka.2016.cs@gmail.com, tytso@mit.edu,
Barry Song <baohua@kernel.org>,
kernel-team@cloudflare.com, Vlastimil Babka <vbabka@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Dave Chinner <david@fromorbit.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>
Subject: Re: Potential Linux Crash: WARNING in ext4_dirty_folio in Linux kernel v6.13-rc5
Date: Thu, 03 Apr 2025 15:32:45 -0400 [thread overview]
Message-ID: <bcccb7452b6683c235452b810c964950acbb0e08.camel@HansenPartnership.com> (raw)
In-Reply-To: <Z-7BengoC1j6WQBE@casper.infradead.org>
On Thu, 2025-04-03 at 18:12 +0100, Matthew Wilcox wrote:
[...]
> Ideas still on the table:
>
> - Convert all filesystems to use the XFS inode management scheme.
> Nobody is thrilled by this large amount of work.
> - Find a simpler version of the XFS scheme to implement for other
> filesystems.
What's wrong with a simpler fix: if we're in PF_MEMALLOC when we try to
run inode.c:evict(), send it through a workqueue? It will require some
preallocation (say using a superblock based work entry ... or simply
reuse the destroy_work) but it should be doable. The analysis says
that evicting from reclaim is very rare because it's a deletion race,
so it shouldn't matter that it's firing once per inode with this
condition.
Regards,
James
next prev parent reply other threads:[~2025-04-03 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 2:42 Luka
2025-03-06 5:13 ` Matthew Wilcox
2025-03-26 10:59 ` Matt Fleming
2025-04-03 12:29 ` Matt Fleming
2025-04-03 12:58 ` Vlastimil Babka
2025-04-03 14:33 ` Michal Hocko
2025-04-03 17:12 ` Matthew Wilcox
2025-04-03 19:32 ` James Bottomley [this message]
2025-04-04 9:09 ` Vlastimil Babka
2025-04-04 13:50 ` Matthew Wilcox
2025-04-07 23:00 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcccb7452b6683c235452b810c964950acbb0e08.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=baohua@kernel.org \
--cc=david@fromorbit.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luka.2016.cs@gmail.com \
--cc=matt@readmodwrite.com \
--cc=miklos@szeredi.hu \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox