From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA2CC83030 for ; Thu, 3 Jul 2025 11:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0F716B017E; Thu, 3 Jul 2025 07:59:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0246B017F; Thu, 3 Jul 2025 07:59:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAF376B0180; Thu, 3 Jul 2025 07:59:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9B48F6B017E for ; Thu, 3 Jul 2025 07:59:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 22FCB1D00D6 for ; Thu, 3 Jul 2025 11:59:46 +0000 (UTC) X-FDA: 83622809172.10.B7115BA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id D0DD94000A for ; Thu, 3 Jul 2025 11:59:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=l+DiTjLJ; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751543983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8S0ZBfU4RHCb3AVXDehiL0kJDHfRUZ8TZvb+ax9pGPQ=; b=sC9/wBA7S1gsBwr1vGc/r+83vMUw+ZON6jYnPO9f8Kkb35n9r/nippT+Z7kBQ3+z5g+hQx v42evKHveyp2YhJwmqFFLLvPw0U7pOFqIli6CKpFqzPKddobh4Z8KlmQdRZqQH+3KM93CW tZtQexojHTJG9Lq9SHc54idoD5od4/Q= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=l+DiTjLJ; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751543983; a=rsa-sha256; cv=none; b=elPdvKZk7Dcfeoa9mTXxat00Mr/9CM9W5Qo2MctsSh2/PvHu9gKjaA+n1+XfHorqaR6JPK y9ZI6/kJLmczH0lEqncN6g+edQEyiTjueNnv5pfWlpajQz4Dciqr2Xe99dZ8/BTr9wB6c+ 5pK6xqTOQJJ7Jj4JlB18b7rBtSRKlNg= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5639APLF031002; Thu, 3 Jul 2025 11:59:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=8S0ZBf U4RHCb3AVXDehiL0kJDHfRUZ8TZvb+ax9pGPQ=; b=l+DiTjLJNK6a+vfK/YB1cI sLRjiDrMxVL7kpui52BK7RXDohmKCZsEnlLx+EAWpARvIwKz4rrdbyxxuAtxzxsf /NQFsCnkCXlLna+i34xF0AIwOTNGYZ1l3odL8/+SBrnbYBOJGZ6D2a2Ku9Hn9WEV YKOOFddh0lyeJHsed6C2sURO2tszHWkbkPJsDhx3CqSvHcLjY+HqBmhl5/wfBUKH AT+/tv2kPlthbqBjAmMol++lHvwUdnSkax/aH8aXIw8yFFFF+8ZXl6EGtcgzn4h7 6HeqnYNYoknKAi2W0xF+EBEu2l4kfudsKFml2AL93CDZ/NTc8ZOvsInG0u3bM7Ww == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j6u232hv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 11:59:40 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 563B8DpU006881; Thu, 3 Jul 2025 11:59:39 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jvxmmew6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 11:59:39 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 563BxcXg21627404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 11:59:39 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACFB158055; Thu, 3 Jul 2025 11:59:38 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA55158059; Thu, 3 Jul 2025 11:59:36 +0000 (GMT) Received: from [9.109.245.113] (unknown [9.109.245.113]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 11:59:36 +0000 (GMT) Message-ID: Date: Thu, 3 Jul 2025 17:29:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] drivers/base/memory: add node id parameter to add_memory_block() To: Hannes Reinecke , David Hildenbrand Cc: Oscar Salvador , linux-mm@kvack.org References: <20250702073913.58247-1-hare@kernel.org> <20250702073913.58247-2-hare@kernel.org> Content-Language: en-US From: Donet Tom In-Reply-To: <20250702073913.58247-2-hare@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: xMi-vrAjdwI0EHkxe6j3JrKrseXhq0eE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDA5MyBTYWx0ZWRfX1BLZPnTcsW7i 0VUWaN1G5Sx+XsS0LnK+TUR64IM3Y6D5fzVUy41Awx0q0Ia1P2icuBnLPUO2pjdq+r97s1C9qsq 6HHACTL12Uxf2bBT0yyjQigmdoZMApeFCR1dGRWBT0QaBwqF0Dr9nMnbFuHNSrru1DNTis/Ffis uV3YQf+Rwt05bKegu2OcYSO89c9/SSz/JqewI1DdauAYHGGQzzBME5uGZ45EeNnm0DR8TziZEfs fcmrp0XykS8MoPySxf1mpGXpiBYOWo076WLSc491QsGu2fC58KS0ZFtOgGlNQOf4WU3dWP/r+V3 KWgyj6o0QFMXkAt2KtnJxfVkTpwfORF/lkIWdQ9L5nymiw+nY6DXQdtluuCQx5AYkrwD4+2Pobx VBnZsT15SczK5mr42NLsg0a1P4FwxHLrCwczXtX29MVXEAQBmCq6gYWUsle4EqEJGmGlsQM8 X-Proofpoint-GUID: xMi-vrAjdwI0EHkxe6j3JrKrseXhq0eE X-Authority-Analysis: v=2.4 cv=GrRC+l1C c=1 sm=1 tr=0 ts=686670ac cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=z9QZ-m7FHaHlOrnW364A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_03,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030093 X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D0DD94000A X-Stat-Signature: qgs9becj1uxiz4g7474e5p4t6g36ry9h X-HE-Tag: 1751543983-208204 X-HE-Meta: U2FsdGVkX1+Od3lKHkpVsxmoURT0OixUaLpc8RPEK4uztm0m6gvGAlNe8atHQavRLjOMvv1Zjx4961NvOstweT5CeN7rXrCZbbZiPE3ceyoTqbn27seyCN07sRSSZgqH8YhnaZtVEiyQ7rW7EnWarg3fIxFM+SyVQGHy7J9Pghr7dWam0GUO8VMjCVf4no8Ix4bfIAYNGT9JR9VJSr20pW98eX7w8gVs7tk+6vTUd10rGb2+ZXZRKxf7NzLA2f315hdgZHEV9CQ73L3MTISThGk67F7emcv57v5o/N0TwY1VjxwWjDie9yB6KbLGDrRRXIZQxyBUoZC2lgE3o28X3OLL7qiTPZZKfbW9aUcjmCsI5NaumZBxyG35NzuyC85/Epj3jeclRzw6Sj4eiKBbvFhyucg03fAEdzOSjHWmC2r4ulToqRNGf2RKWFqacosbkLtg2iUmVHVgygrk3hI2NJh6P1N0pXJ5jWBBI1xlNpk84fs9gBFjxebvJKmFCblKlWom/5FJM14Nk/P5x0hzr873rsh2/iqvGF9l3N4dJcHSq91hDyvk2HwHTuYJolq7VfOMCMOUlXOP9jGHGlLcgHtB3fioi7Y9jFG2bO/0PfBxi4TYcbR4MEWRC1Rr2+OxKb5OST6X0q5+qmOSjwiGzuBu84O1IibiX+bCdtCffED/+CECDrXdZPh01UxmTiBf/fNMn57u2T8DJ96iYfIlKAWYP4yjvDeyPoLK3Znmqk/1pe/dX4cGivQ6EK6gJOkzupu+oUBQtW4zZ0hWk6Wboss1BgqULSj+gWTms401IMt5RZpVTfN7AXshtlhlFCHeTMUw/P+KH/gec+DasbNA4lKd+kyHmZZoljvA/Zl3FYnnckS/6PAzxlSKQcpBXT7Y1EmZNTxqOwepbuQ8om8zB96Y1Fxogw/qAI1peM2syycm+rrYIfvL7qu9xS1kBg3l8IUSztrxgMC1kgY9IsP qf3Tn+vm x3ZzqlE2jSCxpq1Ncd1AfcjtX7MV9usPcsoHH80PQim7Xz4pzEk8oTXXyvg5AdePzongKq9smQC5piU1IoY6oKMZsN6rzhEbqt2S+42xhQAfCFwHkbiiaAUi9s3/x9gtn5yOOb5Z8kbEjk7dXOwKDIiNSlav2GMs/YFVJtKd9viKjvPUnQKl6vaBEqLjPrF/M51RMTDamfGhCYWffrJg/F74fzpnRvWXhPIsviI01EMocIFeQ5WfmGBuTew7D4TDwH8OTaSuRR0nL4c/+eVH1LvFNCWdAhrnCo8IELIXqY3Hnof5loZ2+FzY7w4LXmzlRSQhWlsyI6LCLaoo6mNp2qEDQiG9svXWg+oj6+fu8OB4jEXUtie6uitBd08/Gu81ePHPv6UnFXJfVcqM7an/45z0rp6FFEQmfHF1A3SiTr+21DSYq4gO3vqPT9iaqZZPJ4wWXkKIS/K0NzJXh2YfAOKQcvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/2/25 1:09 PM, Hannes Reinecke wrote: > Add a 'nid' parameter to add_memory_block() to initialize the memory > block with the correct node id. > > Signed-off-by: Hannes Reinecke > Acked-by: David Hildenbrand > Acked-by: Oscar Salvador > --- > drivers/base/memory.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index ed3e69dc785c..2b951e5f8a27 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -822,7 +822,7 @@ void memory_block_add_nid(struct memory_block *mem, int nid, > } > #endif > > -static int add_memory_block(unsigned long block_id, unsigned long state, > +static int add_memory_block(unsigned long block_id, int nid, unsigned long state, > struct vmem_altmap *altmap, > struct memory_group *group) > { > @@ -840,7 +840,7 @@ static int add_memory_block(unsigned long block_id, unsigned long state, > > mem->start_section_nr = block_id * sections_per_block; > mem->state = state; > - mem->nid = NUMA_NO_NODE; > + mem->nid = nid; > mem->altmap = altmap; > INIT_LIST_HEAD(&mem->group_next); > > @@ -867,13 +867,6 @@ static int add_memory_block(unsigned long block_id, unsigned long state, > return 0; > } > > -static int add_hotplug_memory_block(unsigned long block_id, > - struct vmem_altmap *altmap, > - struct memory_group *group) > -{ > - return add_memory_block(block_id, MEM_OFFLINE, altmap, group); > -} > - > static void remove_memory_block(struct memory_block *memory) > { > if (WARN_ON_ONCE(memory->dev.bus != &memory_subsys)) > @@ -913,7 +906,7 @@ int create_memory_block_devices(unsigned long start, unsigned long size, > return -EINVAL; > > for (block_id = start_block_id; block_id != end_block_id; block_id++) { > - ret = add_hotplug_memory_block(block_id, altmap, group); > + ret = add_memory_block(block_id, NUMA_NO_NODE, MEM_OFFLINE, altmap, group); > if (ret) > break; > } > @@ -1018,7 +1011,7 @@ void __init memory_dev_init(void) > continue; > > block_id = memory_block_id(nr); > - ret = add_memory_block(block_id, MEM_ONLINE, NULL, NULL); > + ret = add_memory_block(block_id, NUMA_NO_NODE, MEM_ONLINE, NULL, NULL); > if (ret) { > panic("%s() failed to add memory block: %d\n", > __func__, ret); This looks good to me. Feel free to add Reviewed-by: Donet Tom