Re: [PATCH 1/3] drivers/base/memory: add node id parameter to add_memory_block()

[Donet Tom <donettom@linux.ibm.com>]

On 7/2/25 1:09 PM, Hannes Reinecke wrote:
> Add a 'nid' parameter to add_memory_block() to initialize the memory
> block with the correct node id.
>
> Signed-off-by: Hannes Reinecke <hare@kernel.org>
> Acked-by: David Hildenbrand <david@redhat.com>
> Acked-by: Oscar Salvador <osalvador@suse.de>
> ---
>   drivers/base/memory.c | 15 ++++-----------
>   1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index ed3e69dc785c..2b951e5f8a27 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -822,7 +822,7 @@ void memory_block_add_nid(struct memory_block *mem, int nid,
>   }
>   #endif
>   
> -static int add_memory_block(unsigned long block_id, unsigned long state,
> +static int add_memory_block(unsigned long block_id, int nid, unsigned long state,
>   			    struct vmem_altmap *altmap,
>   			    struct memory_group *group)
>   {
> @@ -840,7 +840,7 @@ static int add_memory_block(unsigned long block_id, unsigned long state,
>   
>   	mem->start_section_nr = block_id * sections_per_block;
>   	mem->state = state;
> -	mem->nid = NUMA_NO_NODE;
> +	mem->nid = nid;
>   	mem->altmap = altmap;
>   	INIT_LIST_HEAD(&mem->group_next);
>   
> @@ -867,13 +867,6 @@ static int add_memory_block(unsigned long block_id, unsigned long state,
>   	return 0;
>   }
>   
> -static int add_hotplug_memory_block(unsigned long block_id,
> -				    struct vmem_altmap *altmap,
> -				    struct memory_group *group)
> -{
> -	return add_memory_block(block_id, MEM_OFFLINE, altmap, group);
> -}
> -
>   static void remove_memory_block(struct memory_block *memory)
>   {
>   	if (WARN_ON_ONCE(memory->dev.bus != &memory_subsys))
> @@ -913,7 +906,7 @@ int create_memory_block_devices(unsigned long start, unsigned long size,
>   		return -EINVAL;
>   
>   	for (block_id = start_block_id; block_id != end_block_id; block_id++) {
> -		ret = add_hotplug_memory_block(block_id, altmap, group);
> +		ret = add_memory_block(block_id, NUMA_NO_NODE, MEM_OFFLINE, altmap, group);
>   		if (ret)
>   			break;
>   	}
> @@ -1018,7 +1011,7 @@ void __init memory_dev_init(void)
>   			continue;
>   
>   		block_id = memory_block_id(nr);
> -		ret = add_memory_block(block_id, MEM_ONLINE, NULL, NULL);
> +		ret = add_memory_block(block_id, NUMA_NO_NODE, MEM_ONLINE, NULL, NULL);
>   		if (ret) {
>   			panic("%s() failed to add memory block: %d\n",
>   			      __func__, ret);


This looks good to me. Feel free to add

Reviewed-by: Donet Tom <donettom@linux.ibm.com>