From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08337C433EF for ; Tue, 8 Mar 2022 08:21:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68B408D0002; Tue, 8 Mar 2022 03:21:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63ACD8D0001; Tue, 8 Mar 2022 03:21:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 502A78D0002; Tue, 8 Mar 2022 03:21:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 428738D0001 for ; Tue, 8 Mar 2022 03:21:29 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 16E1A60493 for ; Tue, 8 Mar 2022 08:21:29 +0000 (UTC) X-FDA: 79220524656.05.35B37DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 7D8511C0010 for ; Tue, 8 Mar 2022 08:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646727687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TPGV7ehpSQqx+IAZ6Q4UMs4eKXTc5SZkrFf2pOnvCvw=; b=HpCUppJ0sDI2jQPxyzc7qaJveZAnXXbDtl2CoGkcLPW0dmiohWBfivP2J5JxT8fHzJwGUM aeLDp9Rx9HLIuQF3w01hChEy1Yxy+AHApwA8IG1nk8rSmEkcFYV6wnrbwbHU/3NYBzsHDA KetB3/WwHh3m6Su9DDzqgEv9MtnB2zY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-487-DjsiiLscPGSfU_QpMClqXw-1; Tue, 08 Mar 2022 03:21:26 -0500 X-MC-Unique: DjsiiLscPGSfU_QpMClqXw-1 Received: by mail-wr1-f72.google.com with SMTP id w17-20020adfec51000000b001f068bc3342so2961582wrn.6 for ; Tue, 08 Mar 2022 00:21:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=TPGV7ehpSQqx+IAZ6Q4UMs4eKXTc5SZkrFf2pOnvCvw=; b=DuwvHqceQ4lxEHiKd+1VYfSa8YiaMSEjVVGOPf+p1gmUlUhrSLCQjz2gwyhwnDNygq e2g1E4RfwhhzFDXbbt2BR0kNFx4ZbYTHM2YBstbkvY2VqcjL5jBo4C79iG+aD6/0lFoi tNxkA5rmzjQuP5fpFRfDejgdmnxQ+eYFE1remzqHoNQOtl8w/vUw81YCXU8OztryycZS zganuL8LHfxP7WCo3G5JKsyfWy+1hoXvHC5Jc7OYVRNuTAb6esuzMli9egLwtdTYO56k ho0Zfk3OQhJHtZtS7RLdYSBk436hHNleg1Ad+6Vup99O8R5aLgP+YAGyBsbfQNNBIaF4 13dg== X-Gm-Message-State: AOAM530kdSXvbNL3g3tiKuI1RAHj2g2S5iks+/OEAKpYVLrEl3R07xQy StM+Dvv7Uac8raFo6tAF08f59Rv8kzsmkR+gtOrh/UqDuj6QEBBLvNgU5aOPTQyxOqFiOB5dJse YQj1OMfa0jIA= X-Received: by 2002:adf:ea4a:0:b0:1f0:6501:80f7 with SMTP id j10-20020adfea4a000000b001f0650180f7mr11022652wrn.306.1646727685400; Tue, 08 Mar 2022 00:21:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIWBX20hLFQ6w9ka0x2WIFzYL3vL9HpkUa3WrvCMfxe9qTqYpiU8oGrTjavXY5gqT7TALjPw== X-Received: by 2002:adf:ea4a:0:b0:1f0:6501:80f7 with SMTP id j10-20020adfea4a000000b001f0650180f7mr11022617wrn.306.1646727684938; Tue, 08 Mar 2022 00:21:24 -0800 (PST) Received: from ?IPV6:2003:cb:c708:b000:acda:b420:16aa:6b67? (p200300cbc708b000acdab42016aa6b67.dip0.t-ipconnect.de. [2003:cb:c708:b000:acda:b420:16aa:6b67]) by smtp.gmail.com with ESMTPSA id r20-20020adfa154000000b001f0326a23e1sm13310899wrr.88.2022.03.08.00.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 00:21:24 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 09:21:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Linus Torvalds , Andreas Gruenbacher Cc: Alexander Viro , linux-s390 , Linux-MM , linux-fsdevel , linux-btrfs References: From: David Hildenbrand Organization: Red Hat Subject: Re: Buffered I/O broken on s390x with page faults disabled (gfs2) In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: is1ceubnw37ma91houztfy3tt9d6andh Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HpCUppJ0; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Queue-Id: 7D8511C0010 X-HE-Tag: 1646727688-797808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.03.22 00:18, Linus Torvalds wrote: > On Mon, Mar 7, 2022 at 2:52 PM Andreas Gruenbacher wrote: >> >> After generic_file_read_iter() returns a short or empty read, we fault >> in some pages with fault_in_iov_iter_writeable(). This succeeds, but >> the next call to generic_file_read_iter() returns -EFAULT and we're >> not making any progress. > > Since this is s390-specific, I get the very strong feeling that the > > fault_in_iov_iter_writeable -> > fault_in_safe_writeable -> > __get_user_pages_locked -> > __get_user_pages > > path somehow successfully finds the page, despite it not being > properly accessible in the page tables. As raised offline already, I suspect shrink_active_list() ->page_referenced() ->page_referenced_one() ->ptep_clear_flush_young_notify() ->ptep_clear_flush_young() which results on s390x in: static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~_PAGE_YOUNG; pte_val(pte) |= _PAGE_INVALID; return pte; } static inline int ptep_test_and_clear_young(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep) { pte_t pte = *ptep; pte = ptep_xchg_direct(vma->vm_mm, addr, ptep, pte_mkold(pte)); return pte_young(pte); } _PAGE_INVALID is the actual HW bit, _PAGE_PRESENT is a pure SW bit. AFAIU, pte_present() still holds: static inline int pte_present(pte_t pte) { /* Bit pattern: (pte & 0x001) == 0x001 */ return (pte_val(pte) & _PAGE_PRESENT) != 0; } pte_mkyoung() will revert that action: static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_YOUNG; if (pte_val(pte) & _PAGE_READ) pte_val(pte) &= ~_PAGE_INVALID; return pte; } and pte_modify() will adjust it properly again: /* * The following pte modification functions only work if * pte_present() is true. Undefined behaviour if not.. */ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) { pte_val(pte) &= _PAGE_CHG_MASK; pte_val(pte) |= pgprot_val(newprot); /* * newprot for PAGE_NONE, PAGE_RO, PAGE_RX, PAGE_RW and PAGE_RWX * has the invalid bit set, clear it again for readable, young pages */ if ((pte_val(pte) & _PAGE_YOUNG) && (pte_val(pte) & _PAGE_READ)) pte_val(pte) &= ~_PAGE_INVALID; /* * newprot for PAGE_RO, PAGE_RX, PAGE_RW and PAGE_RWX has the page * protection bit set, clear it again for writable, dirty pages */ if ((pte_val(pte) & _PAGE_DIRTY) && (pte_val(pte) & _PAGE_WRITE)) pte_val(pte) &= ~_PAGE_PROTECT; return pte; } Which leaves me wondering if there is a way in GUP whereby we would lookup that page and not clear _PAGE_INVALID, resulting in GUP succeeding but faults via the MMU still faulting on _PAGE_INVALID. -- Thanks, David / dhildenb