From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1678CC6FA82 for ; Sat, 10 Sep 2022 11:34:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 758246B0071; Sat, 10 Sep 2022 07:34:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 707FC8D0002; Sat, 10 Sep 2022 07:34:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D1078D0001; Sat, 10 Sep 2022 07:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FA456B0071 for ; Sat, 10 Sep 2022 07:34:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0259C1203F3 for ; Sat, 10 Sep 2022 11:34:05 +0000 (UTC) X-FDA: 79895966892.16.C279EDD Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf30.hostedemail.com (Postfix) with ESMTP id B8279800AF for ; Sat, 10 Sep 2022 11:34:05 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id dv25so9792277ejb.12 for ; Sat, 10 Sep 2022 04:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8Ag6mHz6RaJKAvIf3yWG8/NFxf6UdfL+MIDBEsLCyN8=; b=rt56lu4zDxtfFC0gCwopFBFWhVClMEv05ZLa6FVTJvWQfkY2PRelXahCVRkTH0W0EE SDi7Jg1T1Uk7Cgx8nOrb1llp4a5ljwV0hdWJLnKvHp44g8AGFKUUuXIYEu47fVHTnc+/ 8wGHkEV4bRaaeVojMOyW1sd84KJqpHyhoHmwKscMTML1EIFROO1ffCslzJIrMkPlYesA CBTvyvCmvmcJsItPrNfbGgD6LX3xXNlU+Uvr8Wo01rpF/CTHcxytcMd7P56VsFix0FeR nYU0jAzsSdPZvhNnm7dXkuhgwaXZBEfS/U1FJvc3Zvz9IP4l/XZZ4aGZLlBa7gaLGUT8 q2nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8Ag6mHz6RaJKAvIf3yWG8/NFxf6UdfL+MIDBEsLCyN8=; b=2jSbpy+PCI2BOxUt8J8P4/QcxqsYCMoDkD4kd6WduelsqntUeYTNxFZj2+Pgm9airB O+/bbk2eeq8mD4V/mQFkGLH0DKpQQLV2el+9L58zYwN+tbuPnZREwPEcoL8b1/GU11K6 76WBWpCEvpWeBiTP7pkvhHrIysA1NmaK+T3Y5BtMQaiLBksAkknZNwlhtCWsNgbwnxlW AeQpYmDR1pZylmPIqOqfgoGNwWuu6RNq1mAwEtOKpDYDGF0v0yzpc/gyc1S6x1Kuf5lG hDlyTWAOKr00orfdjbMnK2ugU8bSCdGOuYTpz2jcoQvD05QFi7v/l6KZWYF3SBl8Q3sp hEkg== X-Gm-Message-State: ACgBeo24nuxLdIujypj5mjQlc1lSts3C+bkvM4ByoW9o9Ty5kTiPa8iP +dG83P4SD86wjkgs8Wv+9tDkkA== X-Google-Smtp-Source: AA6agR6l/1o9KPVR6GtRSUN/6LhKnQUVR80O3xKSuOcDWQt5wKNsZnh3qcOtdZWGGeWimCE3wtzgXg== X-Received: by 2002:a17:906:9750:b0:77b:6f08:986f with SMTP id o16-20020a170906975000b0077b6f08986fmr1210041ejy.416.1662809644338; Sat, 10 Sep 2022 04:34:04 -0700 (PDT) Received: from [10.41.110.194] ([77.241.232.19]) by smtp.gmail.com with ESMTPSA id s1-20020a056402014100b0044e8d0682b2sm2014194edu.71.2022.09.10.04.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Sep 2022 04:34:03 -0700 (PDT) Message-ID: Date: Sat, 10 Sep 2022 05:34:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton Cc: Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-2-hch@lst.de> From: Jens Axboe In-Reply-To: <20220910065058.3303831-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662809645; a=rsa-sha256; cv=none; b=5f5LMxstNlY5Up7eT0ozRkpjRlnjePl+KkCgA9jmT9ASrpWMSTvt2TjCJ9VcNfCV6a0srZ 2HTNOND7y4kxgh0oZE91brvU0KAVNFZZmpwTro7xZUjaDBWvFj1VSjgLHfAmtTCtdwCQ6a 8FZ2KafRg6PTx+IRgjkztQ3yOpyLGMo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=rt56lu4z; spf=pass (imf30.hostedemail.com: domain of axboe@kernel.dk designates 209.85.218.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662809645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Ag6mHz6RaJKAvIf3yWG8/NFxf6UdfL+MIDBEsLCyN8=; b=VbxAmUGWYcsG9Ua8BZjviuqv85Dpkv8J2dfe2MJLWtPIOM7rczhz0ATmv76jncMfBdfbrl xrdpclrniSaXHMxGeXpB89zla3x44OSKlWDOzaOgtwd08QWXs7T4WPW53mg/BI115Sgc7m 2gqL2msGbGSEFXPQL6JEN3QhLbQJqJE= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=rt56lu4z; spf=pass (imf30.hostedemail.com: domain of axboe@kernel.dk designates 209.85.218.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-Rspam-User: X-Stat-Signature: qj8tgsybh1pncpxsmrspzw1wjo4kq4d6 X-Rspamd-Queue-Id: B8279800AF X-Rspamd-Server: rspam01 X-HE-Tag: 1662809645-110600 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/10/22 12:50 AM, Christoph Hellwig wrote: > @@ -2390,8 +2392,13 @@ static int filemap_read_folio(struct file *file, filler_t filler, > * fails. > */ > folio_clear_error(folio); > + > /* Start the actual read. The read will unlock the page. */ > + if (unlikely(workingset)) > + psi_memstall_enter(&pflags); > error = filler(file, folio); > + if (unlikely(workingset)) > + psi_memstall_leave(&pflags); > if (error) > return error; I think this would read better as: /* Start the actual read. The read will unlock the page. */ if (unlikely(workingset)) { psi_memstall_enter(&pflags); error = filler(file, folio); psi_memstall_leave(&pflags); } else { error = filler(file, folio); } if (error) return error; -- Jens Axboe